Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review

"Charles Eckel (eckelcu)" <eckelcu@cisco.com> Wed, 06 December 2017 19:34 UTC

Return-Path: <eckelcu@cisco.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 886A4127873 for <bfcpbis@ietfa.amsl.com>; Wed, 6 Dec 2017 11:34:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YmDhWsv7R29r for <bfcpbis@ietfa.amsl.com>; Wed, 6 Dec 2017 11:34:37 -0800 (PST)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 79A86126CC4 for <bfcpbis@ietf.org>; Wed, 6 Dec 2017 11:34:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10326; q=dns/txt; s=iport; t=1512588877; x=1513798477; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5hY4Q3paIHKt5cnEIPylX9HtEleXVqaDFzUhFt71Uz8=; b=GVCQbixUv2tK0qsCc/CqrAdeoV93F4lNLm7iDI9ABADJVhbVBHZmO/b6 IAumKGK8SSlCCjuwk/w4bfv2XAFVVsDxfbeH2v82uB92phByXt7ORUJvg besa4SyO8tTVEY159tZAnozPrUZLuOwkUCor4zLOv1xErMmf3M9XYLrkh 8=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AEBQDuRCha/5JdJa1bAhkBAQEBAQEBAQEBAQEHAQEBAQGDPWZuJweDe4ogjl0BHYF9gVqHGo4RghUKGAuESU8CGoU6PxgBAQEBAQEBAQFrKIUiAQEBBAEBGwYROgsMBAIBCBEDAQEBAwISEQMCAgIfBgsUAQgIAQEEAQ0FigsDFRCpAYInhzkNgw4BAQEBAQEBAQEBAQEBAQEBAQEBAQEdgQ+EIwEpgz8pgXSBDoJrSIFYHTECDguCQjGCMgWKRYdDhzeJAT0Ch3SIKIR7ghZjhS6LNI0BPYhoAhEZAYE5AR85gU5vFToqAYF+CYJJHIFneIc0gSSBFQEBAQ
X-IronPort-AV: E=Sophos;i="5.45,369,1508803200"; d="scan'208";a="327457849"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 19:34:35 +0000
Received: from XCH-RCD-012.cisco.com (xch-rcd-012.cisco.com [173.37.102.22]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id vB6JYZ4g020159 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 6 Dec 2017 19:34:35 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-RCD-012.cisco.com (173.37.102.22) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 6 Dec 2017 13:34:35 -0600
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1320.000; Wed, 6 Dec 2017 13:34:35 -0600
From: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>
CC: "Tom Kristensen (tomkrist)" <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>, "alan@pexip.com" <alan@pexip.com>
Thread-Topic: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review
Thread-Index: AdMCPCFSYamXLa2wSSi7CPCvHfiETwKoe+aAGBVp11AAYTHdAA==
Date: Wed, 06 Dec 2017 19:34:35 +0000
Message-ID: <42C58DF0-BDAB-45BB-91B1-1F55FC2E278C@cisco.com>
References: <7594FB04B1934943A5C02806D1A2204B4CC93DD7@ESESSMB109.ericsson.se> <BFFCDC28-BB45-4439-80C7-261F46F98B76@cisco.com> <7594FB04B1934943A5C02806D1A2204B6C03BCEF@ESESSMB109.ericsson.se>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B6C03BCEF@ESESSMB109.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.28.0.171108
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.154.176.43]
Content-Type: text/plain; charset="utf-8"
Content-ID: <39745D483703F042A8FBF60897F11E9F@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/Te739pMK1cljclNKlkAJQM-vjpQ>
Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 19:34:40 -0000

Hi Christer,

Please see inline.

-----Original Message-----
From: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Monday, December 4, 2017 at 11:50 AM
To: Charles Eckel <eckelcu@cisco.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>
Cc: Tom Kristensen <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>, "alan@pexip.com" <alan@pexip.com>
Subject: RE: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review

    Hi,
    
    Many of my WGLC comments have been addressed. However, I still have some issues.
    
    Q1: SDP 'floorctrl' attribute:
    -------------------------------------
    
    It is very unclear whether the attribute is mandatory in offers/answers or not.
    
    Section 11.1 says that it MUST be included in offers. However, section 4 seems to indicate that it may not be included in an offer.
    
    Section 11.2 says that it MUST be included in an answer, while section 4 indicates that it is only included if present in the offer.

[cue] Sections 11.1 says it MUST be included in offers IF the offerer acts as a floor control server.
[cue] Similarly, section 11.2 says it MUST be included in the answer IF the answerer acts as a floor control server.
[cue] This is consistent with section 4, which states a floor control server acting as an offerer or as an answerer MUST include this attribute in its session descriptions.
[cue] So I think this is technically correct, though as you point out, perhaps not the best wording. That said, it was reworded in this draft to try to make it more clear. Do you have a different wording that you think would be better?


    Q2: Previous comment on SECTION 5:
    ---------------------------------------------------
        
        Q5_1: In section 4, the name of the section is "Floor Control Server Determination", and then section 4.1 defines the associated SDP attribute.
        
        However, in section 5 you start by defining the 'confid' and 'userid' attributes. I think it would be good to have a similar structure as in section 4, where you first give an overview of the feature, and then define the attributes in subsections.
     
    [cue] This is a carryover from RFC 4583. While I agree with you, I’m not sure it is worth changing at this point. Do you have text you think would be helpful as an intro to the section?   
    
    [christer] My suggestion (more simple than my original suggestion) would be to name section 4 to 'SDP 'floorctrl' Attribute', and structure it in a similar way as sections 5 and 6.

[cue] I do not have a strong preference here.    
            
    Q3: Previous comment on  SECTION 11:
    -----------------------------------------------------
        
        Q11_1: I think the mux category for the 'bfcpver' attribute should be defined in the section that defines the attribute - not in the offer/answer procedures.
    
    [cue] Sounds good to me.
        
    [christer] The fix is good.
    
    I note that the mux categories for the other attributes are defined in draft-ietf-mmusic-mux-attributes. That would probably be good to mention that, and while draft-ietf-mmusic-mux-attributes references RFC 4583, the mux considerations also apply to this 4583bis.

[cue] I agree, that would be good to add.

Cheers,
Charles
        
    Regards,
        
    Christer
        
        
        -----Original Message-----
        From: Charles Eckel (eckelcu) [mailto:eckelcu@cisco.com] 
        Sent: 19 July 2017 12:23
        To: bfcpbis@ietf.org
        Cc: Tom Kristensen (tomkrist) <tomkrist@cisco.com>; Roman Shpount <rshpount@turbobridge.com>; Alan Ford <alan.ford@gmail.com>; Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>; Christer Holmberg <christer.holmberg@ericsson.com>; alan@pexip.com
        Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
        
        (As WG co-chair)
        
        Thanks to those who provided reviews. We have decided to extend WGLC an additional week, through July 25, to provide folks tied up with other IETF matters time to complete their reviews.
        
        Cheers,
        Charles 
        
        -----Original Message-----
        From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
        Date: Monday, July 17, 2017 at 10:10 AM
        To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
        Cc: Tom Kristensen <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>, Christer Holmberg <christer.holmberg@ericsson.com>
        Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
        
            (As WG co-chair)
            
            This is a reminder that WGLC ends tomorrow. I realize the time to review overlaps with IETF prep and meeting times. If you require more time to review the draft, please let me know. Otherwise, please share your review comments by the end of tomorrow.
            
            Thanks,
            Charles
            
            -----Original Message-----
            From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
            Date: Wednesday, July 5, 2017 at 5:59 PM
            To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
            Subject: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
            
                (As WG co-chair)
                
                This is to announce an additional working group last call for draft-ietf-bfcpbis-rfc4583bis, "Session Description Protocol (SDP) Format for Binary Floor Control Protocol (BFCP) Streams".
                http://datatracker.ietf.org/doc/draft-ietf-bfcpbis-rfc4583bis/
                
                This is intended as a Standards Track RFC, obsoleting RFC 4583.
                Please respond to the list by July 18th (i.e. 2 weeks) with any comments.
                
                We had a working group last call previous, but a significant amount of time and some substantial changes and additions have occurred to justify another review of the draft in its entirely. It is helpful to attempt to categorize your comment (e.g. technical issue vs. editorial), and also to provide any replacement text you feel is necessary.
                If you review the document and have no comments, please tell the chairs that you have reviewed it. This is always useful information in assessing the degree of WG review and consensus behind the document.
                Note, we have not scheduled a working group session for IETF 99 in Prague. This WGLC will close during IETF 99. If helpful, we can arrange a side meeting to discuss any significant issues, or with any luck, gather at a bar to celebrate the draft being ready to advance to the next step toward RFC.
                
                Cheers,
                Charles
                
                
                _______________________________________________
                bfcpbis mailing list
                bfcpbis@ietf.org
                https://www.ietf.org/mailman/listinfo/bfcpbis
                
            
            _______________________________________________
            bfcpbis mailing list
            bfcpbis@ietf.org
            https://www.ietf.org/mailman/listinfo/bfcpbis