Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review

Alan Ford <alan.ford@gmail.com> Tue, 12 December 2017 09:38 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBF1B1286B1 for <bfcpbis@ietfa.amsl.com>; Tue, 12 Dec 2017 01:38:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SxQX8_IgADZp for <bfcpbis@ietfa.amsl.com>; Tue, 12 Dec 2017 01:38:03 -0800 (PST)
Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 78389127978 for <bfcpbis@ietf.org>; Tue, 12 Dec 2017 01:38:02 -0800 (PST)
Received: by mail-wr0-x230.google.com with SMTP id x49so20367402wrb.13 for <bfcpbis@ietf.org>; Tue, 12 Dec 2017 01:38:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=tlTk/AXGYZaaUlHsHoZzEWu7L8oJqoh6zB95Lbz9GwM=; b=G8fZdCukAbQwBtolHsb8Muzht2JThd82saJ0MpO9q3uEf4BgZqgHoztgNkBl28V4cp Wu81aUgqTk/yRHmwRYa0W5Gk1P5FN4n9Iz/enttK03+2as6c6oYyoMR/SZxEswPHtoDR TK5tyucawPLOh6I12S0IBQRC6TnXhHsaJbNqRqakYV88lL7Ru+EmiueLyiaNwindJ1mg 00MFePWCQgGdxRXbcIVhCTZTr15W/WGT11eD0HxvU6ZckY+ituscFp4eXlTeKiQjmz9o zNOJnwSemg02QxVcjEk1vmyP5T6LXVh12Lq7bn0d0gT9FIUacuuHM+v63NF6fOirqVkk VBDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=tlTk/AXGYZaaUlHsHoZzEWu7L8oJqoh6zB95Lbz9GwM=; b=pIcn515hIbyf9+RweEdZtBerQkaRfj7aocpRRyPbpeKLgWoJbHSCDH+6iGoQrz3uIF t2RdwUUomXBE1vykiiTvJoh7bLxha0wpq0zvQFybyQBJ83dmeBvj2ICYhG6dwC2yqSWA zOAqz2V/DNm6Uv0uGzM69eLfpTMjhLv+ckmrxFks7PoYF+NQmGsLCudbNi5rOXVXPHKN XkT6wrei6y1e9wXQyW1UWHNycQrY2UhpDtKSEWv12u0awJMODKlFuGkve4Oa2loH8heI sCPwDlMxgLPoPihUGO3hSs977SHz56NWiBYnJW+sredOmxltE5Z7eMm9S6ePTZ2utT5w 0ecA==
X-Gm-Message-State: AKGB3mJEXm1DGDcudSthqQD1oqT5z5XLM4rVTu/msLUJ6Z79N/NKtjl/ Ftjwci1e56hIKet+haYBgCJi4qmu+fo=
X-Google-Smtp-Source: ACJfBotdhiSOhczldT9FJ00IHY1pA/6geHQ3xfmam+zJt7bxoHk0jCepwvZYPyFxNvfBi9xTnAUprA==
X-Received: by 10.223.198.3 with SMTP id n3mr3438476wrg.73.1513071480971; Tue, 12 Dec 2017 01:38:00 -0800 (PST)
Received: from alans-mbp.lan ([31.185.193.242]) by smtp.gmail.com with ESMTPSA id c2sm19960844wrg.57.2017.12.12.01.38.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Dec 2017 01:38:00 -0800 (PST)
Content-Type: multipart/alternative; boundary="Apple-Mail=_68916AD5-AA82-4FB1-9A4D-8CB673B98F32"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alan Ford <alan.ford@gmail.com>
In-Reply-To: <D64EC104.27124%christer.holmberg@ericsson.com>
Date: Tue, 12 Dec 2017 09:37:59 +0000
Cc: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "Tom Kristensen (tomkrist)" <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>
Message-Id: <D581A92A-AB14-4004-8EE4-1D77489E7166@gmail.com>
References: <7594FB04B1934943A5C02806D1A2204B4CC93DD7@ESESSMB109.ericsson.se> <BFFCDC28-BB45-4439-80C7-261F46F98B76@cisco.com> <7594FB04B1934943A5C02806D1A2204B6C03BCEF@ESESSMB109.ericsson.se> <42C58DF0-BDAB-45BB-91B1-1F55FC2E278C@cisco.com> <D64EC104.27124%christer.holmberg@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/hYYVJUzOA3DUPAdt7LWscf8oqmc>
Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2017 09:38:06 -0000

Hi all,

I agree with Christer re Section 4 here, the text has become slightly confused. Now the presence of this attribute in O/A has been raised to a MUST, the following paragraph serves no purpose any more and should be removed:

   If the 'floorctrl' attribute is not used in an offer/answer exchange,
   by default the offerer and the answerer will act as a floor control
   client and as a floor control server, respectively.

That would resolve the confusion highlighted here.

Regarding my own WGLC comments, I’m not going to kick up any more of a fuss about this, but in Section 6, although the text re “mstrm” has been improved to clarify being optional, I remain confused as to what the scenario actually is for a floorid without associated media stream(s). Does it affect all streams in that case? Or would it be used for floors that do not have any associated media streams (whatever that means)? I think it would be useful to define what the lack of mstrm means (unless it’s application-specific, in which case we can ignore it).

Other than that, I am happy with the document as it now stands.

Regards,
Alan

> On 7 Dec 2017, at 08:16, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi,
> 
>> 
>>   Q1: SDP 'floorctrl' attribute:
>>   -------------------------------------
>> 
>>   It is very unclear whether the attribute is mandatory in
>> offers/answers or not.
>> 
>>   Section 11.1 says that it MUST be included in offers. However,
>> section 4 seems to indicate that it may not be included in an offer.
>> 
>>   Section 11.2 says that it MUST be included in an answer, while
>> section 4 indicates that it is only included if present in the offer.
>> 
>> [cue] Sections 11.1 says it MUST be included in offers IF the offerer
>> acts as a floor control server.
>> [cue] Similarly, section 11.2 says it MUST be included in the answer IF
>> the answerer acts as a floor control server.
> 
> Section 4 does not talk about the role. The text says:
> 
>  "If an SDP media description in an offer contains a 'floorctrl'
>   attribute, the answerer accepting that media MUST include a
>   'floorctrl' attribute in the corresponding media description of the
>   answer.²
> 
> 
> 
>> [cue] This is consistent with section 4, which states a floor control
>> server acting as an offerer or as an answerer MUST include this attribute
>> in its session descriptions.
> 
> Based on the text in section 11.2, if the answerer does NOT include the
> attribute in the answer, it would mean that the answerer acts as floor
> control client. Right?
> 
> BUT, the text in section 4 says:
> 
>  "If the 'floorctrl' attribute is not used in an offer/answer exchange,
>   by default the offerer and the answerer will act as a floor control
>   client and as a floor control server, respectively.²
> 
> So, to me that means that if the answerer does NOT include the attribute
> in the answer, the answerer acts as server.
> 
> 
> 
>> [cue] So I think this is technically correct, though as you point out,
>> perhaps not the best wording. That said, it was reworded in this draft to
>> try to make it more clear. Do you have a different wording that you think
>> would be better?
> 
> In my opinion, section 4 should only define the attribute, and what it is
> used for. The offer/answer considerations should ONLY be in section 11.
> 
> Regards,
> 
> Christer
> 
> 
>>       -----Original Message-----
>>       From: Charles Eckel (eckelcu) [mailto:eckelcu@cisco.com]
>>       Sent: 19 July 2017 12:23
>>       To: bfcpbis@ietf.org
>>       Cc: Tom Kristensen (tomkrist) <tomkrist@cisco.com>; Roman Shpount
>> <rshpount@turbobridge.com>; Alan Ford <alan.ford@gmail.com>; Gonzalo
>> Camarillo <gonzalo.camarillo@ericsson.com>; Christer Holmberg
>> <christer.holmberg@ericsson.com>; alan@pexip.com
>>       Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
>> 
>>       (As WG co-chair)
>> 
>>       Thanks to those who provided reviews. We have decided to extend
>> WGLC an additional week, through July 25, to provide folks tied up with
>> other IETF matters time to complete their reviews.
>> 
>>       Cheers,
>>       Charles 
>> 
>>       -----Original Message-----
>>       From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles
>> Eckel <eckelcu@cisco.com>
>>       Date: Monday, July 17, 2017 at 10:10 AM
>>       To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
>>       Cc: Tom Kristensen <tomkrist@cisco.com>, Roman Shpount
>> <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo
>> Camarillo <Gonzalo.Camarillo@ericsson.com>, Christer Holmberg
>> <christer.holmberg@ericsson.com>
>>       Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
>> 
>>           (As WG co-chair)
>> 
>>           This is a reminder that WGLC ends tomorrow. I realize the
>> time to review overlaps with IETF prep and meeting times. If you require
>> more time to review the draft, please let me know. Otherwise, please
>> share your review comments by the end of tomorrow.
>> 
>>           Thanks,
>>           Charles
>> 
>>           -----Original Message-----
>>           From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles
>> Eckel <eckelcu@cisco.com>
>>           Date: Wednesday, July 5, 2017 at 5:59 PM
>>           To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
>>           Subject: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
>> 
>>               (As WG co-chair)
>> 
>>               This is to announce an additional working group last call
>> for draft-ietf-bfcpbis-rfc4583bis, "Session Description Protocol (SDP)
>> Format for Binary Floor Control Protocol (BFCP) Streams".
>> 
>> http://datatracker.ietf.org/doc/draft-ietf-bfcpbis-rfc4583bis/
>> 
>>               This is intended as a Standards Track RFC, obsoleting RFC
>> 4583.
>>               Please respond to the list by July 18th (i.e. 2 weeks)
>> with any comments.
>> 
>>               We had a working group last call previous, but a
>> significant amount of time and some substantial changes and additions
>> have occurred to justify another review of the draft in its entirely. It
>> is helpful to attempt to categorize your comment (e.g. technical issue
>> vs. editorial), and also to provide any replacement text you feel is
>> necessary.
>>               If you review the document and have no comments, please
>> tell the chairs that you have reviewed it. This is always useful
>> information in assessing the degree of WG review and consensus behind the
>> document.
>>               Note, we have not scheduled a working group session for
>> IETF 99 in Prague. This WGLC will close during IETF 99. If helpful, we
>> can arrange a side meeting to discuss any significant issues, or with any
>> luck, gather at a bar to celebrate the draft being ready to advance to
>> the next step toward RFC.
>> 
>>               Cheers,
>>               Charles
>> 
>> 
>>               _______________________________________________
>>               bfcpbis mailing list
>>               bfcpbis@ietf.org
>>               https://www.ietf.org/mailman/listinfo/bfcpbis
>> 
>> 
>>           _______________________________________________
>>           bfcpbis mailing list
>>           bfcpbis@ietf.org
>>           https://www.ietf.org/mailman/listinfo/bfcpbis
>> 
>> 
>> 
>> 
>> 
>> 
>