Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 04 December 2017 19:50 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B18151289C3 for <bfcpbis@ietfa.amsl.com>; Mon, 4 Dec 2017 11:50:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.221
X-Spam-Level:
X-Spam-Status: No, score=-4.221 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c-Dn8qmudJrh for <bfcpbis@ietfa.amsl.com>; Mon, 4 Dec 2017 11:50:38 -0800 (PST)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2408B128891 for <bfcpbis@ietf.org>; Mon, 4 Dec 2017 11:50:37 -0800 (PST)
X-AuditID: c1b4fb2d-d6fff700000036aa-c4-5a25a70b9bb8
Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id CA.D8.13994.B07A52A5; Mon, 4 Dec 2017 20:50:35 +0100 (CET)
Received: from ESESSMB109.ericsson.se ([169.254.9.225]) by ESESSHC024.ericsson.se ([153.88.183.90]) with mapi id 14.03.0352.000; Mon, 4 Dec 2017 20:50:34 +0100
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>
CC: "Tom Kristensen (tomkrist)" <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>, "alan@pexip.com" <alan@pexip.com>
Thread-Topic: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review
Thread-Index: AdMCPCFSYamXLa2wSSi7CPCvHfiETwKoe+aAGBVp11A=
Date: Mon, 04 Dec 2017 19:50:34 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B6C03BCEF@ESESSMB109.ericsson.se>
References: <7594FB04B1934943A5C02806D1A2204B4CC93DD7@ESESSMB109.ericsson.se> <BFFCDC28-BB45-4439-80C7-261F46F98B76@cisco.com>
In-Reply-To: <BFFCDC28-BB45-4439-80C7-261F46F98B76@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsUyM2J7lC73ctUog+575hYrz61gtti6ooPN 4t+6o0wWm2Z9YbO4/nQXi8WVI7/YHNg8pvzeyOqxc9Zddo8lS34yeRzdv4DRY+vfv2wBrFFc NimpOZllqUX6dglcGbNPvWMq2GVXsXTqLsYGxjc2XYycHBICJhLbjjQydjFycQgJHGaUaO+8 wQ7hLGaU+DTvEXMXIwcHm4CFRPc/bRBTRCBKYuM2IZASZoF7jBKr5s9gBRkkLBAsMX3JFmYQ W0QgRGLJ9m4mCNtK4vmy92BxFgEVicPnl7GA2LwCvhK33j5nhdjVwChx+/ZUsCJOAVuJ68e2 MYLYjAJiEt9PrQEbxCwgLnHryXwmiKsFJJbsOc8MYYtKvHz8jxXCVpJYsf0SI8ihzAKaEut3 6UO0KkpM6X7IDrFXUOLkzCcsExhFZyGZOguhYxaSjllIOhYwsqxiFC1OLS7OTTcy1kstykwu Ls7P08tLLdnECIy1g1t+6+5gXP3a8RCjAAejEg9v5yLVKCHWxLLiytxDjBIczEoivE/mA4V4 UxIrq1KL8uOLSnNSiw8xSnOwKInznvTkjRISSE8sSc1OTS1ILYLJMnFwSjUwzjcQUokT4clp Zmz49U1pZ4ZJz//DZbctyjiWLzhdmiY69bnl47mHPV9NaP/NwbO0IvoWo1mC4wwJUUWtmmbp oFsW61RZZj28cbAyOb/V0b+huNjPZV/eOYHLdnqvNlzwMimdHsMt3V2aPOdV+/pgWd5PKrKf /4v13Xv85UtJZADTqTDW6wZKLMUZiYZazEXFiQA6QV0jsQIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/mxgsGxAaiPSTEGBvQAyxRXMv_c8>
Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis - Christer's review
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2017 19:50:45 -0000

Hi,

Many of my WGLC comments have been addressed. However, I still have some issues.

Q1: SDP 'floorctrl' attribute:
-------------------------------------

It is very unclear whether the attribute is mandatory in offers/answers or not.

Section 11.1 says that it MUST be included in offers. However, section 4 seems to indicate that it may not be included in an offer.

Section 11.2 says that it MUST be included in an answer, while section 4 indicates that it is only included if present in the offer.


Q2: Previous comment on SECTION 5:
---------------------------------------------------
    
    Q5_1: In section 4, the name of the section is "Floor Control Server Determination", and then section 4.1 defines the associated SDP attribute.
    
    However, in section 5 you start by defining the 'confid' and 'userid' attributes. I think it would be good to have a similar structure as in section 4, where you first give an overview of the feature, and then define the attributes in subsections.
 
[cue] This is a carryover from RFC 4583. While I agree with you, I’m not sure it is worth changing at this point. Do you have text you think would be helpful as an intro to the section?   

[christer] My suggestion (more simple than my original suggestion) would be to name section 4 to 'SDP 'floorctrl' Attribute', and structure it in a similar way as sections 5 and 6.

        
Q3: Previous comment on  SECTION 11:
-----------------------------------------------------
    
    Q11_1: I think the mux category for the 'bfcpver' attribute should be defined in the section that defines the attribute - not in the offer/answer procedures.

[cue] Sounds good to me.
    
[christer] The fix is good.

I note that the mux categories for the other attributes are defined in draft-ietf-mmusic-mux-attributes. That would probably be good to mention that, and while draft-ietf-mmusic-mux-attributes references RFC 4583, the mux considerations also apply to this 4583bis.
    
Regards,
    
Christer
    
    
    -----Original Message-----
    From: Charles Eckel (eckelcu) [mailto:eckelcu@cisco.com] 
    Sent: 19 July 2017 12:23
    To: bfcpbis@ietf.org
    Cc: Tom Kristensen (tomkrist) <tomkrist@cisco.com>; Roman Shpount <rshpount@turbobridge.com>; Alan Ford <alan.ford@gmail.com>; Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>; Christer Holmberg <christer.holmberg@ericsson.com>; alan@pexip.com
    Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
    
    (As WG co-chair)
    
    Thanks to those who provided reviews. We have decided to extend WGLC an additional week, through July 25, to provide folks tied up with other IETF matters time to complete their reviews.
    
    Cheers,
    Charles 
    
    -----Original Message-----
    From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
    Date: Monday, July 17, 2017 at 10:10 AM
    To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
    Cc: Tom Kristensen <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>, Christer Holmberg <christer.holmberg@ericsson.com>
    Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
    
        (As WG co-chair)
        
        This is a reminder that WGLC ends tomorrow. I realize the time to review overlaps with IETF prep and meeting times. If you require more time to review the draft, please let me know. Otherwise, please share your review comments by the end of tomorrow.
        
        Thanks,
        Charles
        
        -----Original Message-----
        From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
        Date: Wednesday, July 5, 2017 at 5:59 PM
        To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
        Subject: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
        
            (As WG co-chair)
            
            This is to announce an additional working group last call for draft-ietf-bfcpbis-rfc4583bis, "Session Description Protocol (SDP) Format for Binary Floor Control Protocol (BFCP) Streams".
            http://datatracker.ietf.org/doc/draft-ietf-bfcpbis-rfc4583bis/
            
            This is intended as a Standards Track RFC, obsoleting RFC 4583.
            Please respond to the list by July 18th (i.e. 2 weeks) with any comments.
            
            We had a working group last call previous, but a significant amount of time and some substantial changes and additions have occurred to justify another review of the draft in its entirely. It is helpful to attempt to categorize your comment (e.g. technical issue vs. editorial), and also to provide any replacement text you feel is necessary.
            If you review the document and have no comments, please tell the chairs that you have reviewed it. This is always useful information in assessing the degree of WG review and consensus behind the document.
            Note, we have not scheduled a working group session for IETF 99 in Prague. This WGLC will close during IETF 99. If helpful, we can arrange a side meeting to discuss any significant issues, or with any luck, gather at a bar to celebrate the draft being ready to advance to the next step toward RFC.
            
            Cheers,
            Charles
            
            
            _______________________________________________
            bfcpbis mailing list
            bfcpbis@ietf.org
            https://www.ietf.org/mailman/listinfo/bfcpbis
            
        
        _______________________________________________
        bfcpbis mailing list
        bfcpbis@ietf.org
        https://www.ietf.org/mailman/listinfo/bfcpbis