Re: [Bier] Comments on draft-ietf-bier-bier-yang

Hi jinrong，

Thanks for your review. Please see inline...

Regards.

Ran

原始邮件

发件人：Xiejingrong <xiejingrong@huawei.com>
收件人：BIER WG <bier@ietf.org>
抄送人：draft-ietf-bier-bier-yang@ietf.org <draft-ietf-bier-bier-yang@ietf.org>
日 期 ：2018年07月28日 21:01
主 题 ：Re: [Bier] Comments on draft-ietf-bier-bier-yang

_______________________________________________
BIER mailing list
BIER@ietf.org
https://www.ietf.org/mailman/listinfo/bier

  some more comments:
one sub-domain should allow miltiple {BSL and the according label block}s as encapsulations, see the igp sub-sub-TLV.

[Ran] We will add them ,and  will add the enternet and IPv6 encapsulation type.

2. should the igp-type change to underlay-protocol-type to allow bgp?

[Ran ]will add it.

From:Xiejingrong

To:BIER WG,

Cc:draft-ietf-bier-bier-yang@ietf.org,

Date:2018-07-28 20:36:25

Subject:[Bier] Comments on draft-ietf-bier-bier-yang

Hi folks,

I have the following comments and on draft-ietf-bier-bier-yang.

--should the bier load-balance-number/ipa/bar be added to rt:routing/bier-global/sub-domain (like below)? I think they are some basic items.

 [Ran] "load-balance-number"?Do you means the maximum number of ECMP paths? OSPF YANG data model has defined it .In my opinion, it is neccesarry  to define this item here.

 For the ipa/bar will be added to  rt:routing/bier-global/sub-domain.

augment /rt:routing:

   +--rw bier

   |  +--rw bier-global

   |     +--rw encapsulation-type?   identityref

   |     +--rw bitstringlength?      bsl

   |     +--rw bfr-id?               bfr-id

   |     +--rw ipv4-bfr-prefix?   inet:ipv4-prefix

   |     +--rw ipv6-bfr-prefix?   inet:ipv6-prefix

   |     +--rw sub-domain* [sub-domain-id]

   |        +--rw sub-domain-id      sub-domain-id

   |        +--rw igp-type?          igp-type

   |        +--rw mt-id?             mt-id

   |        +--rw bfr-id?            bfr-id

   |        +--rw bitstringlength?   bsl

   |        +--rw multi-bift-number? load-balance-number

   |        +--rw igp-algorithm?     ipa

   |        +--rw bier-algorithm?    bar

--should the bier-mpls-label-range-size be changed to ‘max si’ or not ? The type is uint8 and thus seems having to change the meaning. 

 [Ran] Sure.

Thanks

Jingrong