Re: [Bier] Comments on draft-ietf-bier-bier-yang

Senthil Dhanaraj <senthil.dhanaraj.ietf@gmail.com> Mon, 15 April 2019 05:45 UTC

Return-Path: <senthil.dhanaraj.ietf@gmail.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A9FB120159; Sun, 14 Apr 2019 22:45:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ncDKsz6j4wpD; Sun, 14 Apr 2019 22:45:35 -0700 (PDT)
Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2EFE712003E; Sun, 14 Apr 2019 22:45:35 -0700 (PDT)
Received: by mail-ed1-x541.google.com with SMTP id u57so12893422edm.3; Sun, 14 Apr 2019 22:45:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hvl5U+7TgwTN9KVDJUxgQNpHmeCfyRrQo9ur9xr5zN0=; b=WrH951oLMlcfcdbhopw2pm3bGNvQS1qGN+xaZsQ1xSqy1NhU8goAzkFNRj88XmXho8 JKUHTY2kQJ+ozOvMj+q71e9EZUpB+JpbxBqd+naHVAtXRG1806N3bEGqT/cjtyD/vkTJ cST+XSjUNM/ZnI/7HuWRc7jrlqrcNWLgIDSBmsMWMmxvNu7Mnry4y+yy5YmzRYmMkSOT DfjVrw+HKC6keCsA4nYH894wQxRmsyJ+t1r2X6OgZW3rHWUZWkTi9ZkOe9ubjK802Jhc 8kZBNq4aNtyTuQFfbVyrWh5yHAsj0QWv51KccXZ6TL1RGMyiEE9nfrZJZZk+TD8cO6qf NELw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hvl5U+7TgwTN9KVDJUxgQNpHmeCfyRrQo9ur9xr5zN0=; b=qX9ne3UGI50uRbW1cy8Xn+Xm1AlEiSnOAbaFd30yB3T2woebKeaQ0Y9hpyEQ1551OG K99fKfMPwRx5dts36COIWAzQh0IJ/SbFPmw/Z67mkfIatgpxS92drwIT12isCkJjJ4vl XTp8M20OEUtTd8VUZx8AUVF88/BjaZmG4Vq22xjFTcq2qFQm2x4Vxxa9rsr36/3srXWm PY7lrGKNEqkFvaASLBSw6LBf2ZPAAnnN6LwItymEPFNL1bHLGw1igr+DJZdF7Lx4c4Di t8IEdMiP/gcV2aOijV5Wp4M7yUEHjkB0gwGWjph8p2MD9vu8QxvDFrqYub0IucBOMkxP T39w==
X-Gm-Message-State: APjAAAUvprn+lURV/VaPuePm1HvYsQ5cjYJSpv60XuqFoK1AG/sX+kFO xC51g5pJs0bnXYGUkIR6usRYhoiOQwREUPp+qPI=
X-Google-Smtp-Source: APXvYqxjKME6QcPzT81pmI/Mfmd8qtQ/yohw7RfBSvEe3PdVtyaYrkmriu2PWHpdmKwtaTweVnoaCjl9Buj7u4qLuJI=
X-Received: by 2002:a50:ca41:: with SMTP id e1mr11928194edi.30.1555307133634; Sun, 14 Apr 2019 22:45:33 -0700 (PDT)
MIME-Version: 1.0
References: <201809061603576337769@zte.com.cn> <16253F7987E4F346823E305D08F9115AAB872447@nkgeml514-mbx.china.huawei.com>
In-Reply-To: <16253F7987E4F346823E305D08F9115AAB872447@nkgeml514-mbx.china.huawei.com>
From: Senthil Dhanaraj <senthil.dhanaraj.ietf@gmail.com>
Date: Mon, 15 Apr 2019 07:46:57 +0200
Message-ID: <CAG9=0b+FRrdT+Jg69b4ox2_vObQ0LyxO0QaLBrg3BoQ_0sLjww@mail.gmail.com>
To: Xiejingrong <xiejingrong@huawei.com>
Cc: "chen.ran@zte.com.cn" <chen.ran@zte.com.cn>, "bier@ietf.org" <bier@ietf.org>, "draft-ietf-bier-bier-yang@ietf.org" <draft-ietf-bier-bier-yang@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000378f2905868b299b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/675s_BRDxpcexbnTOZgWMlFCHRE>
Subject: Re: [Bier] Comments on draft-ietf-bier-bier-yang
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 05:45:40 -0000

Dear Yang Authors,

1) I agree to Jingrong's comment that "Same sub-domain cannot be binded to
both IPv4 and IPv6 underlay". Pls refer the suggested model to handle this
at the end of the mail. Let me know your thoughts/comments.

2) About Jingrong's questions on "Whether same sub-domain can support
different encapsulation types like MPLS and Ethernet" ?
I would think - Yes, a single sub-domain can support many encapsulation
types. Architecturally it is possible that, for a sub-domain, each hop can
chose the encapsulation to be used based on next-hops capability. Yang
model should support it. However, we can discuss and clarify this.

3) A general request to BIER WG is that, we can discuss & progress the yang
work at better pace. Traditionally, yang standards progress slowly in IETF
resulting in implementation with private yang models :(

*Suggested BIER Yang Mode (sd is binded to either ipv4 or ipv6):*


   +--rw bier

   |  +--rw bier-global

   |     +--rw default-encapsulation-type?        identityref

   |     +--rw default-bitstringlength?           bsl

   |     +--rw default-bfr-id?                    bfr-id

   |     +--rw default-ipv4-bfr-prefix?           inet:ipv4-prefix

   |     +--rw default-ipv6-bfr-prefix?           inet:ipv6-prefix

   |     +--rw sub-domain* [sub-domain-id] [addr-family]

   |        +--rw sub-domain-id            sub-domain-id

   |        +--rw addr-family            addr-family

   |        +--rw bfr-prefix?  inet:ipv4-ipv6-prefix

   |        +--rw underlay-protocol-type?  underlay-protocol-type

   |        +--rw mt-id?                   mt-id

   |        +--rw bfr-id?                  bfr-id

   |        +--rw bitstringlength?         bsl

   |        +--rw igp-algorithm?           ipa

   |        +--rw bier-algorithm?          Bar

   |        +--rw load-balance-num         uint8

   |        +--rw encapsulation* [bitstringlength]

   |           +--rw bitstringlength               uint16

   |           +--rw encapsulation-type            enum

   |           +--rw max-si?                       rt-type: uint16

   |           +--rw bift-id-base?                 rt-types: bift-id

Thanks,
Senthil

On Mon, Apr 1, 2019 at 12:10 PM Xiejingrong <xiejingrong@huawei.com> wrote:

> Hi Chen Ran,
>
>
>
> [Ran] "load-balance-number"?Do you means the maximum number of ECMP paths?
> OSPF YANG data model has defined it .In my opinion, it is neccesarry  to
> define this item here.
>
>
>
> [XJR1]:
>
> Yes I found the load-balance(max-ecmp) configuration in OSPF-yang and
> ISIS-yang, but I think they are different things, and there should be a
> load-balance-number for BIER specifically:
>
> (1)     A BFR may not support BIER ECMP forwarding, while unicast ECMP is
> supported.
>
> (2)     There may be different number of paths to different BFERs, for
> example BFER2/BFER2 may have 3/5 paths separately on a BFR, and this BFR
> may want a special load-balance-number 15 for better balancing.
>
>
>
> [XJR2]:
>
> Second question:
>
> Is it allowed for both IPv4-encapsulation and IPv6-encapsulation being
> under a single Sub-domain ?
>
>
>
> augment /rt:routing:
>
>    +--rw bier
>
>    |  +--rw bier-global
>
>    |     +--rw sub-domain* [sub-domain-id]
>
>    |        +--rw sub-domain-id            sub-domain-id
>
>    |        +--rw underlay-protocol-type?  underlay-protocol-type
>
>    |        +--rw mt-id?                    mt-id
>
>    |        +--rw bfr-id?                   bfr-id
>
>    |        +--rw bitstringlength?          bsl
>
>    |        +--rw igp-algorithm?            ipa
>
>    |        +--rw bier-algorithm?           bar
>
>    |        +--rw af
>
>    |           +--rw ipv4* [bitstringlength bier-mpls-label-base]
>
>    |           |  +--rw bitstringlength               uint16
>
>    |           |  +--rw bier-mpls-label-base          rt-types:mpls-label
>
>    |           |  +--rw max-si?                       max-si
>
>    |           +--rw ipv6* [bitstringlength bier-mpls-label-base]
>
>    |              +--rw bitstrin+--glength            uint16
>
>    |              +--rw bier-mpls-label-base          rt-types:mpls-label
>
>    |              +--rw max-si?                       max-si
>
>    |
>
>
>
> The RFC8279 said, a BIER sub-domain must be associated with a single
> routing underlay (see below). I would understand IPv4 and IPv6 as different
> underlay.
>
>    If multiple routing underlays are used in a single BIER domain, each
>
>    BIER sub-domain MUST be associated with a single routing underlay
>
>    (though multiple sub-domains may be associated with the same routing
>
>    underlay).
>
>
>
> [XJR3]:
>
> Third question, maybe for the BIER WG.
>
> It may also be helpful to discuss and conclude, if it is allowed for both
> BIER-MPLS encapsulation and BIER-Ethernet encapsulation being under a
> single sub-domain?
>
> I feel it unnecessary since one can use different BIER Sub-domains
> carrying different encapsulations, and thus an MVPN service using BIER
> doesn’t have to specify the encapsulation-type.
>
>
>
>
>
> *From:* chen.ran@zte.com.cn [mailto:chen.ran@zte.com.cn]
> *Sent:* Thursday, September 06, 2018 4:04 PM
> *To:* Xiejingrong <xiejingrong@huawei.com>
> *Cc:* bier@ietf.org; draft-ietf-bier-bier-yang@ietf.org
> *Subject:* Re: Re: [Bier] Comments on draft-ietf-bier-bier-yang
>
>
>
> Hi jinrong,
>
> Thanks for your review. Please see inline...
>
>
>
> Regards.
>
> Ran
>
>
>
> 原始邮件
>
> *发件人:*Xiejingrong <xiejingrong@huawei.com>
>
> *收件人:*BIER WG <bier@ietf.org>
>
> *抄送人:*draft-ietf-bier-bier-yang@ietf.org <
> draft-ietf-bier-bier-yang@ietf.org>
>
> *日 期 :*2018年07月28日 21:01
>
> *主 题 :Re: [Bier] Comments on draft-ietf-bier-bier-yang*
>
> _______________________________________________
> BIER mailing list
> BIER@ietf.org
> https://www.ietf.org/mailman/listinfo/bier
>
>
>
> some more comments:
>
> 1.  one sub-domain should allow miltiple {BSL and the according label
> block}s as encapsulations, see the igp sub-sub-TLV.
>
> [Ran] We will add them ,and  will add the enternet and IPv6 encapsulation
> type.
>
> 2. should the igp-type change to underlay-protocol-type to allow bgp?
>
> [Ran ]will add it.
>
> *From:*Xiejingrong
>
> *To:*BIER WG,
>
> *Cc:*draft-ietf-bier-bier-yang@ietf.org,
>
> *Date:*2018-07-28 20:36:25
>
> *Subject:*[Bier] Comments on draft-ietf-bier-bier-yang
>
>
>
> Hi folks,
>
>
>
> I have the following comments and on draft-ietf-bier-bier-yang.
>
> --should the bier load-balance-number/ipa/bar be added to
> rt:routing/bier-global/sub-domain (like below)? I think they are some basic
> items.
>
>  [Ran] "load-balance-number"?Do you means the maximum number of ECMP
> paths? OSPF YANG data model has defined it .In my opinion, it is neccesarry
>  to define this item here.
>
>  For the ipa/bar will be added to  rt:routing/bier-global/sub-domain.
>
> augment /rt:routing:
>
>    +--rw bier
>
>    |  +--rw bier-global
>
>    |     +--rw encapsulation-type?   identityref
>
>    |     +--rw bitstringlength?      bsl
>
>    |     +--rw bfr-id?               bfr-id
>
>    |     +--rw ipv4-bfr-prefix?   inet:ipv4-prefix
>
>    |     +--rw ipv6-bfr-prefix?   inet:ipv6-prefix
>
>    |     +--rw sub-domain* [sub-domain-id]
>
>    |        +--rw sub-domain-id      sub-domain-id
>
>    |        +--rw igp-type?          igp-type
>
>    |        +--rw mt-id?             mt-id
>
>    |        +--rw bfr-id?            bfr-id
>
>    |        +--rw bitstringlength?   bsl
>
>    |        +--rw multi-bift-number? load-balance-number
>
>    |        +--rw igp-algorithm?     ipa
>
>    |        +--rw bier-algorithm?    bar
>
>
>
> --should the bier-mpls-label-range-size be changed to ‘max si’ or not ?
> The type is uint8 and thus seems having to change the meaning.
>
>  [Ran] Sure.
>
>
>
> Thanks
>
> Jingrong
>
>
>
>
> _______________________________________________
> BIER mailing list
> BIER@ietf.org
> https://www.ietf.org/mailman/listinfo/bier
>