Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard

tom petch <daedulus@btconnect.com> Wed, 23 September 2020 10:05 UTC

Return-Path: <daedulus@btconnect.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8C6533A0F1A; Wed, 23 Sep 2020 03:05:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OaIOvFCtbI25; Wed, 23 Sep 2020 03:05:49 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10135.outbound.protection.outlook.com [40.107.1.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 75BF73A0F15; Wed, 23 Sep 2020 03:05:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5VyebPXJAbJ/wSbJ8/vnoDDQ9DNjzV36ffAtLw0WvPlUIzs8o/bIcr2rtNp94Cr/36Lbs4ruuhKVJDObt+ccGwYURJG9TIwL6CImna/vnxWTdz42AoHFxbFP3csz6X8tArpXKxBXSoDIum4dzrOyh6IYvuKhizDqr7NBerR5VHe1yTIJvLfIusNYd/zNi6T26oX4cvnQb8Xaq2kMXO/O/v21N96U2R5iL6HEAobaZPtO7ESbXf1KoNQdM5WUM00qFD2uxa9gIeK6zHqLPfRg4YN26IicTU53aMA13PAOoauNisVGFU2q1gBb48ZtSNwckE5w6rosZrho2DKNcOO9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cvazFBU7CF9bUiKF1h2zcF0vHkQB6iGxT3sZg4Rpi/U=; b=oeAhfC9LfoaSVkhOlvQ/Xn7Dfda60Ssmv6loyiTUM9AKF4iJkiX+IHuEVcNnjIyFXhOJXHIQnsr06wfOKmsXxCLpRXYAcAbJ1dEvz8jD5OJoVMOH0a45NSuOyaWK5Jjjt7oSmy/3LsbQG1zFU5m+H1X8nAy2Ai6aM2xw3/9YcPYDu+prqr8F2uQNHFVqTK1pjYBKz/Mm9UkrrZGR6157Ytbj3Jdb+w3Owxj+ZTbBu6QPCUEFKVo/NSwl2CjR7E89VQ9AtSjf8/khiku347NW40wgZkNzZl4MlJJfX8r8OmxXmHJ692UdI8vPPXrtv7nXwBugd0ogo4g1KDxV2IVy7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cvazFBU7CF9bUiKF1h2zcF0vHkQB6iGxT3sZg4Rpi/U=; b=YlTSwo7i5ipHnEqZ44oQalOkyb2toHYuJc9moDr7S1UtebSoqumkKUKIBNtAhMrVofQ1HxatUv6M9+9FskKig8T36XhAPcQGjHbeojDJFcE13tGbuNnmWywVVLRXyKj5LnSIdXAFrm7lIjjNkSxz6Ao8dhZLphTntqtt5jzqTeg=
Authentication-Results: att.com; dkim=none (message not signed) header.d=none;att.com; dmarc=none action=none header.from=btconnect.com;
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8) by VI1PR07MB4144.eurprd07.prod.outlook.com (2603:10a6:803:34::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.11; Wed, 23 Sep 2020 10:05:45 +0000
Received: from VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::6165:9c1c:e5b1:15db]) by VI1PR07MB6704.eurprd07.prod.outlook.com ([fe80::6165:9c1c:e5b1:15db%5]) with mapi id 15.20.3412.020; Wed, 23 Sep 2020 10:05:45 +0000
To: last-call@ietf.org
References: <160028912088.19211.8121836627102846350@ietfa.amsl.com> <5F6339B2.9090501@btconnect.com>
Cc: ccamp@ietf.org, ccamp-chairs@ietf.org, Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>, draft-ietf-ccamp-wson-yang@ietf.org, db3546@att.com
From: tom petch <daedulus@btconnect.com>
Message-ID: <5F6B1DF6.3080009@btconnect.com>
Date: Wed, 23 Sep 2020 11:05:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <5F6339B2.9090501@btconnect.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR07MB6704.eurprd07.prod.outlook.com (2603:10a6:800:18b::8)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.65] (86.153.136.175) by LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3412.20 via Frontend Transport; Wed, 23 Sep 2020 10:05:44 +0000
X-Originating-IP: [86.153.136.175]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a438fd3-6c45-4738-10f7-08d85fa83ce0
X-MS-TrafficTypeDiagnostic: VI1PR07MB4144:
X-Microsoft-Antispam-PRVS: <VI1PR07MB414448E39BE9DFB7EFDCCBF1C6380@VI1PR07MB4144.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: F3g4CmvfoLV1hPFaVGr/waw9pbOOEHboTALwBH4gsk9KZo1xpRu4hK4LUkqsmcmSFQa2B5MkWpmF9r9op804gSbL8Ejkj1t2F3sv6J2YF4AoNBoUHJ/GABA4uSFwM7M5O125+vJPVTwzt5bgMmQhVnqU6znRyGyDSoL7WFI80v+KTCIG3coyMFZKAmOqQVQhJpehSaYj0QxZ2wNaw5n9zJ/9+ij9oHj2ZB6oLp9OHtBtwU1mO49uo/HytebiPcCQfroCxmx5XVd+1SJBRNG0jQZMoRHEZz7bC0Tqqu8RiiaUK7fMHCu6hMw1fGFuElJsEjA7RIx/pjkhZnu2TlZN6+m32NrIS5zP6S0R3C/BBddXYRrlOdzadPojAatkw4w40at+7p9go1KTDhE/e74Csze+TtI3UEdARyuhfU0j0YH//W4MsFCB8umwn+o5XWvR2404b0GvfQos0ZSrRFMSnw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB6704.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(366004)(136003)(39860400002)(376002)(66946007)(87266011)(5660300002)(2906002)(478600001)(26005)(53546011)(52116002)(6486002)(316002)(8936002)(83380400001)(16526019)(966005)(16576012)(956004)(86362001)(186003)(36756003)(4326008)(66556008)(33656002)(6916009)(66476007)(8676002)(2616005); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: K0zf94c0ZW3BruRv9jN3XWHgJLgrtCcgNS2V4j25f8isRdFoI5Oq59puYFsYanpDUTkPJNxyaFIqTJ0OvCm570d57xNcQJ/sDWYSnvAVvE/LLZh+ooHh1nGXO+q4OQmKY//5bX57rJuDldg2GtHT/ggXhKnzB3O0mljTfYPX1ofZV/QFkUoresjWy9ni/pfVUGDPcyd01n+goTZabNt5huDyeRvokg2qp8u9/kGROo17VUZZdZNIzqRZfKQrSPRkrKT9E49OEMCPRrDQbqjr4WFpkRMc6RUknp+f5TiNZs0pqEqK1N6t/aXXJV1HnJzg3RD8joXuJx1zhELRn0ncIvTKCzg+vLmikY5HagLvNShAGylkS6oDbzMBsQ33/bGYkR3ERVLSuFW7DTUzRnjBUeJ7QCoXLuMxShRiomD3ANiK9ilW4tIZBudSg1y74dPRL8InAGA+HHRBJi39LmE/ROhspBmi39jEC9TG4nRuHB1kfx0JzgjTyTi15m9lIdaeYPqc4YpRYpHM+WNzBqY4nWot3h+K8GAWPQSmPFO16YaKd/lHKCh54o+IjHZs69QRiMtFSW4mP+TmSDyDcZKydu227wA6Y8fNVqck04r3MjQmd0AR+9TKzele98tK92MJm7uHSEjQl2FbAFbo4EBULg==
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a438fd3-6c45-4738-10f7-08d85fa83ce0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB6704.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2020 10:05:45.8623 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I5IdoplMjiaglNxOj/CKdwhfbwcV5ujH0dbcet5MUDKttSXyqgCY4i2QJYYAB+N/S/wehhvbXWKzsl0eTLJ/OQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB4144
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/quPaNcyIlbOrq2r9uQ-ckypw0cw>
Subject: Re: [CCAMP] [Last-Call] Last Call: <draft-ietf-ccamp-wson-yang-25.txt> (A YANG Data Model for WSON (Wavelength Switched Optical Networks)) to Proposed Standard
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Sep 2020 10:05:52 -0000

A new verson of this I-D has been posted with substantial changes.  In 
particular, the sequence of definitions in the YANG module has been 
changed while the YANG tree diagram has not been updated to match.  Look 
for example at augments 4, 5, 6 and 7.  In the tree diagram, as in -25, 
they are to label-start, label-end, label-step, label-hop; in the module 
they are to 'from', 'to' and then switch from node attributes to 
information source.

It is technically possible for me to review -26 against -25 but it would 
take so long that I am not going to do it.  My review is to compare, 
side by side, old and new, so resequencing destroys that and with a 62 
page I-D I will not contemplate any other approach.

A new tree diagram, to match the YANG module, again would not make it 
feasible.  The module sequence needs to be the same as in -25 for me.

Tom Petch

On 17/09/2020 11:25, tom petch wrote:
> On 16/09/2020 21:45, The IESG wrote:
>>
>> The IESG has received a request from the Common Control and
>> Measurement Plane
>> WG (ccamp) to consider the following document: - 'A YANG Data Model
>> for WSON
>> (Wavelength Switched Optical Networks)'
>>    <draft-ietf-ccamp-wson-yang-25.txt> as Proposed Standard
>>
>> The IESG plans to make a decision in the next few weeks, and solicits
>> final
>> comments on this action. Please send substantive comments to the
>> last-call@ietf.org mailing lists by 2020-09-30. Exceptionally,
>> comments may
>> be sent to iesg@ietf.org instead. In either case, please retain the
>> beginning
>> of the Subject line to allow automated sorting.
>
> Two glitches and some trivia:
>
> Introduction
> /impairement/impairment/
>
> The only key word I see is a 'should' in IANA which is going to go so
> whether or not Requirements Language should be included is a moot point.
>
> YANG import for layer0-types references the wrong I-D
>
> YANG module description talks of two encoding documents but omits RFC7581
>
> grouping wson-node-attributes has the same 'e.g.' for both true and
> false which looks odd; and I wonder if 'i.e.' is intended
>
> the e-mail address for Aihua Guo is different for the YANG module and
> for Authors' Addresses
>
> Tom Petch
>
>> Abstract
>>
>>
>>     This document provides a YANG data model for the routing and
>>     wavelength assignment (RWA) TE topology in wavelength switched
>>     optical networks (WSONs).  The YANG data model defined in this
>>     document conforms to the Network Management Datastore Architecture
>>     (NMDA).
>>
>>
>>
>>
>> The file can be obtained via
>> https://datatracker.ietf.org/doc/draft-ietf-ccamp-wson-yang/
>>
>>
>>
>> No IPR declarations have been submitted directly on this I-D.
>>
>>
>> The document contains these normative downward references.
>> See RFC 3967 for additional information:
>>      draft-ietf-ccamp-optical-impairment-topology-yang: A Yang Data
>> Model for Optical Impairment-aware Topology (None - IETF stream)
>>      draft-ietf-ccamp-flexigrid-yang: YANG data model for Flexi-Grid
>> Optical Networks (None - IETF stream)
>>
>>
>>
>>
>> _______________________________________________
>> IETF-Announce mailing list
>> IETF-Announce@ietf.org
>> https://www.ietf.org/mailman/listinfo/ietf-announce
>> .
>>
>