Re: [DNSOP] Secdir last call review of draft-ietf-dnsop-server-cookies-04

Ondřej Surý <ondrej@isc.org> Wed, 02 December 2020 18:27 UTC

Return-Path: <ondrej@isc.org>
X-Original-To: dnsop@ietfa.amsl.com
Delivered-To: dnsop@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9CE863A17A9; Wed, 2 Dec 2020 10:27:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x7KqxIiYkcCH; Wed, 2 Dec 2020 10:27:04 -0800 (PST)
Received: from mx.pao1.isc.org (mx.pao1.isc.org [IPv6:2001:4f8:0:2::2b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CDF383A1903; Wed, 2 Dec 2020 10:26:01 -0800 (PST)
Received: from zmx1.isc.org (zmx1.isc.org [149.20.0.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.pao1.isc.org (Postfix) with ESMTPS id 8A9103AB0DB; Wed, 2 Dec 2020 18:26:01 +0000 (UTC)
Received: from zmx1.isc.org (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTPS id 6AB55160046; Wed, 2 Dec 2020 18:26:01 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1]) by zmx1.isc.org (Postfix) with ESMTP id 57ED216006E; Wed, 2 Dec 2020 18:26:01 +0000 (UTC)
Received: from zmx1.isc.org ([127.0.0.1]) by localhost (zmx1.isc.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rDQYEsV1rJwU; Wed, 2 Dec 2020 18:26:01 +0000 (UTC)
Received: from [10.10.10.141] (unknown [78.80.211.217]) by zmx1.isc.org (Postfix) with ESMTPSA id D31EB160046; Wed, 2 Dec 2020 18:26:00 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Ondřej Surý <ondrej@isc.org>
Mime-Version: 1.0 (1.0)
Date: Wed, 02 Dec 2020 19:25:58 +0100
Message-Id: <17AFD6F5-11DA-41BC-8C37-E1893648041D@isc.org>
References: <160693121881.9413.5642470305677631145@ietfa.amsl.com>
Cc: secdir@ietf.org, last-call@ietf.org, draft-ietf-dnsop-server-cookies.all@ietf.org, dnsop@ietf.org
In-Reply-To: <160693121881.9413.5642470305677631145@ietfa.amsl.com>
To: Stephen Farrell <stephen.farrell@cs.tcd.ie>
X-Mailer: iPhone Mail (18B121)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnsop/cmdSRXn99PNQhBr1dYJRI6YZQDY>
Subject: Re: [DNSOP] Secdir last call review of draft-ietf-dnsop-server-cookies-04
X-BeenThere: dnsop@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: IETF DNSOP WG mailing list <dnsop.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnsop>, <mailto:dnsop-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnsop/>
List-Post: <mailto:dnsop@ietf.org>
List-Help: <mailto:dnsop-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnsop>, <mailto:dnsop-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2020 18:27:13 -0000

Stephen,

ad 1) the performance is crucial for DNS over UDP and PRF such as SipHash is more efficient than HMACs. No, it wasn’t consulted with CFRG, and I can’t speak for Willem, but I am confident enough to make the decision. SipHash is widely used for hash tables virtually anywhere now.

ad 2) we need a value that’s synchronized well enough and monotonic. I honestly don’t see any value in using 64-bit value here. Using unixtime has a value in itself, it’s a well-known and there’s a little room for any implementor to make a mistake in an implementation. The interoperability is more important than the actual value of the counter. It’s write only counter, nobody is going to interpret it after it has been generated, and it’s wide enough to prevent brute forcing.

Cheers,
Ondřej
--
Ondřej Surý — ISC (He/Him)

> On 2. 12. 2020, at 18:47, Stephen Farrell via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Stephen Farrell
> Review result: Has Issues
> 
> I see two issues here worth checking:
> 
> 1. I don't recall SipHash being used as a MAC in
> any IETF standard before. We normally use HMAC,
> even if truncated. Why make this change and was
> that checked with e.g. CFRG? (And the URL given
> in the reference gets me a 404.)
> 
> 2. Is it really a good idea to use a 32 bit seconds
> since 1970-01-01 in 2020? I'd have thought that e.g.
> a timestamp in hours since then or seconds since
> some date in 2020 would be better.
> 
> Here's a couple of nits too:
> - section 1: what's a "strong cookie"?
> - "gallimaufry" - cute! but not sure it'll help readers to learn that word.
> 
> 
> 
>