[eman] Comments on draft-ietf-eman-battery-mib-12
Alan Luchuk <luchuk@snmp.com> Wed, 12 March 2014 17:57 UTC
Return-Path: <luchuk@snmp.com>
X-Original-To: eman@ietfa.amsl.com
Delivered-To: eman@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E7771A074D for <eman@ietfa.amsl.com>; Wed, 12 Mar 2014 10:57:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.449
X-Spam-Level:
X-Spam-Status: No, score=-2.449 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.547, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UPEcMCGkoteM for <eman@ietfa.amsl.com>; Wed, 12 Mar 2014 10:57:37 -0700 (PDT)
Received: from mailbox.snmp.com (mailbox.snmp.com [192.147.142.80]) by ietfa.amsl.com (Postfix) with ESMTP id 883C61A0729 for <eman@ietf.org>; Wed, 12 Mar 2014 10:57:32 -0700 (PDT)
Received: from adminfs.snmp.com (adminfs.snmp.com [192.147.142.39]) by mailbox.snmp.com (8.9.3p2-20030922/m.0080228) with ESMTP id NAA23036; Wed, 12 Mar 2014 13:57:16 -0400 (EDT)
Received: (from luchuk@localhost) by adminfs.snmp.com (8.9.3p2-20030922/snmpclient.mc-990525) id NAA24671; Wed, 12 Mar 2014 13:57:06 -0400 (EDT)
Date: Wed, 12 Mar 2014 13:57:06 -0400
From: Alan Luchuk <luchuk@snmp.com>
Message-Id: <201403121757.NAA24671@adminfs.snmp.com>
To: eman@ietf.org
Archived-At: http://mailarchive.ietf.org/arch/msg/eman/d8ligeMDyDn291obuVXNEmdac44
Subject: [eman] Comments on draft-ietf-eman-battery-mib-12
X-BeenThere: eman@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussions about the Energy Management Working Group <eman.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/eman>, <mailto:eman-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/eman/>
List-Post: <mailto:eman@ietf.org>
List-Help: <mailto:eman-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/eman>, <mailto:eman-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Mar 2014 17:57:42 -0000
Hello, Here are comments on draft-ietf-eman-battery-mib-12.txt. I think only the last issue in the list may be a true problem; it is easily fixed. There is one technical issue that might be worthy of further consideration. The rest are these are typos or grammatical nits. I hope these are helpful to the EMAN WG. Regards, --Alan Page 3, Introduction (typo) ---------------------------- The second paragraph from the bottom contains the sentence: Many battery-driven devices have existing instrumentation for monitoring the battery status, because this is already needed for local control of the battery by the device. I think the comma is not needed; perhaps the sentence should read: Many battery-driven devices have existing instrumentation for monitoring the battery status because this is already needed for local control of the battery by the device. Page 4, Introduction (typo) --------------------------- The first paragraph from the top contains the sentence: The former allows tracing a battery and allows continuous monitoring even if the battery is e.g. installed in another device." I think the "e.g." is not needed; perhaps the sentence should read: The former allows tracing a battery and allows continuous monitoring even if the battery is installed in another device." Page 5, MIB Module Structure (grammer) -------------------------------------- The third paragraph from the top reads: If batteries are replaced, and the replacing battery uses the same ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ physical connector as the replaced battery, then the replacing battery SHOULD be indexed with the same value of object entPhysicalIndex as the replaced battery. In the first clause the subject is plural, in the second clause, the subject is singular. Perhaps the sentence should read: If a battery is replaced, and the replacing battery uses the same ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ physical connector as the replaced battery, then the replacing battery SHOULD be indexed with the same value of object entPhysicalIndex as the replaced battery. The same text appears in the description clause for the batteryTable on page 10. Page 5, MIB Module Structure (nit) ---------------------------------- The last paragraph on page 5 and the first paragraph on page 6 mention three groups of objects: objects with OIDs ending with 1-10, objects with OIDs ending with 11-18, and objects with OIDs ending with 20-25. The batteryCellIdentifier object ends with SID 19 and is not included in any of the three groups. Page 13, DESCRIPTION for batteryTechnology ------------------------------------------ The DESCRIPTION for batteryTechnology reads: "This object indicates the technology used by the battery. Numbers identifying battery types are registered at IANA. A current list of assignments can be found at <http://www.iana.org/assignments/eman>. Value 0 (unknown) MUST be used if the type of battery cannot be determined. Value 1 (other) can be used if the battery type is known but not one of the types already registered at IANA." I tried to access the URL shown above, and could not. I assume it has not yet been created by IANA. Also, the values and enumeration names do not match the table shown in section 3.2 on page 7. I think this part of the DESCRIPTION should read: "Value 1 (unknown) MUST be used if the type of battery cannot be determined. Value 2 (other) can be used if the battery type is known but not one of the types already registered at IANA." Page 14, batteryMaxChargingCurrent (possible technical issue) ------------------------------------------------------------- Between drafts -11 and -12, the battery capacity values were increased in size from an Unsigned32 to an Unsigned64TC to accomodate very high capacity batteries. For batteries with a capacity large enough to require an Unsigned64TC is it sufficient to have a batteryMaxChargingCurrent limited to an Unsigned32? For example, if a battery is ever built that has a capacity that must be reported with the maximum value of the Unsigned64TC batteryDesignCapacity, the maximum allowed charging current for that battery might be too large to report with the Unsigned32 batteryMaxChargingCurrent. This same issue might apply to the batteryTrickleChargingCurrent MIB object on Page 14, as well as the batteryActualCurrent MIB object on Page 19. Not sure what the best course of action is here. Page 16, DESCRIPTION for batteryChargingCycleCount -------------------------------------------------- The second paragraph of the DESCRIPTION for batteryChargingCycleCount reads: "For batteries of type primary(1) the value of this object is always 0." This enumeration name/number does not match the enumerated values listed for the batteryType MIB object on page 12/13: batteryType OBJECT-TYPE SYNTAX INTEGER { unknown(1), other(2), primary(3), rechargeable(4), capacitor(5) } Also, I think the charging cycle count only applies to a batteryType of rechargeable(4), so would rewording this second paragraph make sense? "For batteries of any type other than rechargeable(4), the value of this object is always 0." Page 17, DESCRIPTION for batteryChargingAdminState (nit) -------------------------------------------------------- The first sentence of the first paragraph of the DESCRIPTION for batteryChargingAdminState reads: "The value of this object indicates the desired status of the charging state of the battery. Perhaps the following text is a little more concise: "The value of this object indicates the desired charging state of the battery. Page 28, batteryTemperatureNotification (problem) ------------------------------------------------- OBJECT batteryTemperatureNotification MIN-ACCESS read-only DESCRIPTION "A compliant implementation is not required to support set operations to this object." A MIB checker squawked about batteryTemperatureNotification is not defined as an OBJECT-TYPE. Should this be removed from the BATTERY-MIB?
- [eman] Comments on draft-ietf-eman-battery-mib-12 Alan Luchuk
- Re: [eman] Comments on draft-ietf-eman-battery-mi… Juergen Quittek
- Re: [eman] Comments on draft-ietf-eman-battery-mi… Juergen Quittek
- Re: [eman] Comments on draft-ietf-eman-battery-mi… John Parello (jparello)
- Re: [eman] Comments on draft-ietf-eman-battery-mi… Alan Luchuk