Re: [Gen-art] Genart last call review of draft-ietf-idr-rfc8203bis-06

"Jakob Heitz (jheitz)" <jheitz@cisco.com> Thu, 03 December 2020 01:25 UTC

Return-Path: <jheitz@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 941C73A0640; Wed, 2 Dec 2020 17:25:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.62
X-Spam-Level:
X-Spam-Status: No, score=-9.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=j9t4pGHw; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=dArGxkYN
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SW5GOj08_5iM; Wed, 2 Dec 2020 17:25:07 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ECD403A064A; Wed, 2 Dec 2020 17:25:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4496; q=dns/txt; s=iport; t=1606958707; x=1608168307; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Zf8jVGL7qQmazUEIDHW9E4jnY177czdM3H9XSqeDqpg=; b=j9t4pGHwdImJhTL4RcxJIEedKFQByUUMatPxBUmKAMY2aB61YsCR3L49 c86eCCkF8gxHnRHPnPyi97rH51f2TSgvBKMKhZ55fblDwaRsIL8r25XRk e2lVUB4DoXlRZInFdzPZoIcoZMTlnWoytsOkTgHGWHGWoreLu87i7cILk U=;
X-IPAS-Result: =?us-ascii?q?A0DfAADWPchffYwNJK1iHQEBAQEJARIBBQUBQIE9BgELA?= =?us-ascii?q?YFRKSh8Wy8uhDyDSAONXI8JiX+BLhSBEQNUCwEBAQ0BASMKAgQBAYRKAheBf?= =?us-ascii?q?QIlNgcOAgMBAQEDAgMBAQEBBQEBAQIBBgQUAQGGPAyFcgEBAQEDEhERDAEBN?= =?us-ascii?q?wELBAIBCBEDAQEBAwImAgICMBUICAIEAQ0FCBqDBYJVAy4BDqF+AoE8iGl2g?= =?us-ascii?q?TKDBAEBBYE3AoNzGIIQAwaBDioBgnKDdoZXG4FBP4ERQ4JVPoJdAQEDgR4JA?= =?us-ascii?q?QsHASODFTOCLJEBB4J6h06DCpoiCoJyiRmNB4U1gyGKIZRik3KLCJFUFQGEI?= =?us-ascii?q?wIEAgQFAg4BAQWBXQonaXBwFYEVgg9QFwINjiGBJQECgkmFFIVEdDcCBgoBA?= =?us-ascii?q?QMJfI0ygkYBAQ?=
IronPort-PHdr: =?us-ascii?q?9a23=3AKa7xMRBZqTfZYa5dq7yYUyQJPHJ1sqjoPgMT9p?= =?us-ascii?q?ssgq5PdaLm5Zn5IUjD/qw03A3AR4TS5/RJzeHRtvOoVW8B5MOHt3YPONxJWg?= =?us-ascii?q?QegMob1wonHIaeCEL9IfKrCk5yHMlLWFJ/uX3uN09TFZX3fVzbrnu/qzUVH0?= =?us-ascii?q?a3OQ98PO+gHInUgoy+3Pyz/JuGZQJOiXK9bLp+IQ/wox/Ws5wdgJBpLeA6zR?= =?us-ascii?q?6arw=3D=3D?=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.78,388,1599523200"; d="scan'208";a="606783045"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 03 Dec 2020 01:25:06 +0000
Received: from XCH-ALN-001.cisco.com (xch-aln-001.cisco.com [173.36.7.11]) by alln-core-7.cisco.com (8.15.2/8.15.2) with ESMTPS id 0B31P5te020266 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 3 Dec 2020 01:25:05 GMT
Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-001.cisco.com (173.36.7.11) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Dec 2020 19:25:05 -0600
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 2 Dec 2020 19:25:05 -0600
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (72.163.14.9) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 2 Dec 2020 19:25:05 -0600
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mw6nzK+uNqpTQHekzonA/p5dWPbtro2piWCwUkMmi6/O303sf1iOsK1DeljAddIjBC8QchPugpGJGa2xZql2KH0AdDjKnaa1jhxVm+0/8zRAdFTPQ/PtvXca/ref0MGrKedzeI0EYfOESTOSLrM1B9/yTKkquQjF9vwP9v+vI5YgaQa3acriv8mo0uxsnM1hoAOBPAOfBUoNVbE8bZxJpBugKytcvJMs/UvAWuSqFJYK6eQm7XdH5J6u1gM+5ro3IMiUcocgKSXMCGFu45ZkH/alzlPViD1iR1J+xmPsNj5SRaato+I4Ie4ONI4B8/zHKkkUJxMcn9AMtInWs4wgAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zf8jVGL7qQmazUEIDHW9E4jnY177czdM3H9XSqeDqpg=; b=CTr8rFidBqWzkPpPcLQ1l55h0Obq+hXNO3iQ2BxToG+K4GQnL9YXN0YEb34sJgrvBRSub6+joWhG6V7Xnm9f0slMrK7VrqNsSQkueEBBdvP8bBPrDxZiarftM2lOOp8tBM55lSWzU6A4TLPte4Beet4TgPiuXdL1uFZAiljIGODsGLbe8kIrS0qAjy17GVckaiG1HBkMuBbuxDlUFKR1mPOBPIAmlv2WZ2mDHFDqk5Tg/hmVc0pLOlfS9U2tidbqH9RCRSkqTtt6psUVelZS3N3PbZz5dpUQ1e+/B0aCCyuG8UdJyLLA/QmWOp4iSAenCin4/BMjbKh4Zkt9rmMfOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zf8jVGL7qQmazUEIDHW9E4jnY177czdM3H9XSqeDqpg=; b=dArGxkYN5t3etJx1AMxsWpLMvfoS8m6MbrmaaVkJtbX2t4T1nkrcBYESWAsFpknAmUW2w0x9m+0C/u/1OYR0Uav/2tFr9TpAy8vS6CI1uglFOVTDqvhfTyjO6cuC5E+v9WfN9VAip7K+39TwF9DMDxfWs7K25/QJwOUhR0HwHEE=
Received: from BYAPR11MB3207.namprd11.prod.outlook.com (2603:10b6:a03:7c::14) by BYAPR11MB3014.namprd11.prod.outlook.com (2603:10b6:a03:91::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Thu, 3 Dec 2020 01:25:03 +0000
Received: from BYAPR11MB3207.namprd11.prod.outlook.com ([fe80::7103:f747:b0a8:5808]) by BYAPR11MB3207.namprd11.prod.outlook.com ([fe80::7103:f747:b0a8:5808%3]) with mapi id 15.20.3611.031; Thu, 3 Dec 2020 01:25:03 +0000
From: "Jakob Heitz (jheitz)" <jheitz@cisco.com>
To: Dale Worley <worley@ariadne.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-idr-rfc8203bis.all@ietf.org" <draft-ietf-idr-rfc8203bis.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "idr@ietf.org" <idr@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-idr-rfc8203bis-06
Thread-Index: AQHWWY98eUNJDDr3pUi2j11sRc3lbKnlbSTQ
Date: Thu, 3 Dec 2020 01:25:03 +0000
Message-ID: <BYAPR11MB32078568AD586BE7CED3AF48C0F20@BYAPR11MB3207.namprd11.prod.outlook.com>
References: <159469756416.23871.9871951323378623271@ietfa.amsl.com>
In-Reply-To: <159469756416.23871.9871951323378623271@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ariadne.com; dkim=none (message not signed) header.d=none;ariadne.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [2601:647:5701:46e0:44f0:9a0a:c597:245e]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cfa08d60-41c3-48a9-ff3f-08d8972a4275
x-ms-traffictypediagnostic: BYAPR11MB3014:
x-microsoft-antispam-prvs: <BYAPR11MB30147B862EA61BB5473B3FC9C0F20@BYAPR11MB3014.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: L3BWpYF0aaHstzZXSdDwtvTLZZavjaIKMRQ9lVPy5jgbwt7sog2MahjN+OksvMLVpBWGlpB/ROPIn5Ds2UDCJnb1AAEB3JQua32JW+xF8inQW5Ra5MRAguQUOJgPFq3lCVvq80aiUJ4PGdihYFZylG/m+MIOR499ilR2bY6bOYHIcgh7jcSYJW7vUHWeFa83dE65v//+cXlHExbiIpSjprNk2+S7lQ6kgG4uyX22vLL0R6tUVxEtBVGQ5tIIAfR7I8AdrP9m4aqC5KnB1ajFZDebVc1s37pFLEhcg6twH5mnvCBKBKJw2D3c4nArTJ2bGfFLNKJVN54XPHP3uljoon+IQwuUikPFtAxO42Z+Sd1zYkIIc1MdQ9j85HDbiCJDMyJVcc1WQH/jF4LHLDjQGg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(366004)(136003)(39860400002)(376002)(54906003)(186003)(86362001)(66476007)(83380400001)(316002)(9686003)(55016002)(52536014)(2906002)(5660300002)(966005)(110136005)(71200400001)(33656002)(8676002)(76116006)(4326008)(8936002)(7696005)(53546011)(64756008)(66556008)(478600001)(66946007)(66446008)(6506007); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?utf-8?B?NVBOdkNyMFVsV1RCZGRlc3JYZ2RBYjlieGJDOWN4MnErOFp3TnZpUkdlSFdq?= =?utf-8?B?b2wvU1NtYnU2RVZVdzFlc25HalNmbkNzSGJEQ3FNUFpYNnNySXQ0TERLbWhj?= =?utf-8?B?aE1iMEJZZE1xaHRoWEFUUzZxNDk3S1NRZ1JDNTdMQktHd1BpaVBCcWs0NDkz?= =?utf-8?B?aVgraFFiVnJqanJVR2liNjFPSlFCUEwyeEhmcTFoeExvQlQzSzBrV0Q0Rllr?= =?utf-8?B?Umw4cXJyR2M2Yjh0TXM5dmpjRjlvaUVpQzgraUlPbk14Y0ZZMy9iYks0NTY5?= =?utf-8?B?K0IyRUVDRUdUODNnR2NiTllTQTNxQ1ZJN2h3V3ZzQ1h3aGZ2VjJ4QjNVa3dh?= =?utf-8?B?c09Tb24vV3RkL1Y4UkV6U3g1RVpGdk1WK3NDdHdGWmJ6M2xFek1EL2ZXSkdp?= =?utf-8?B?M2duUFhJRThpY0E3OFdUZEhOL3pzNVUzZjh5Rm84d2Q5UnhwYXBRUy9ZaTh5?= =?utf-8?B?RE56eHZQMXJPbmdtdFFUSnNicUxmSU10VTQzOFh0bDB0c2VYdWl5cndGY25I?= =?utf-8?B?MXRLMUJwWXh1eUtLM1RXdEdCNWRubmdXRU1RdlFmQzF6SUJZczJMV1FTVTFj?= =?utf-8?B?RitqeE9CZXFqSE9vWForRFRCcnFUYkdZN1JLbzhzaVZvS2g4empaRTE3VWZR?= =?utf-8?B?R1pNNVViYWhjQTBPdXFjSHdZQ3FYYU1MK3lmekpLYzFvN0hqU0dLVUZBeXFU?= =?utf-8?B?QmZaamtKeVBrd1ZDa2JVYjBwYklYUktBeWRjT2JpaFcvUkwyMmpTV0xsM0Vk?= =?utf-8?B?a01RN2RZNkV6MmZlL3BFYmZUb0RkRWEwMlI4WWFGTGpOSDl5dExOSXV4OFJR?= =?utf-8?B?bHREMStTaWE2TDBXOGhFNHVueVFObnlGVXFNOVZ2YWRMK0JwczFxMXFQWEgy?= =?utf-8?B?blptK2Flb0Q1TnlNN1h0K1NkQW80ajFrOWsvNm1ZUEw0NFM5WTlPSm9PNFEr?= =?utf-8?B?cmRjNUFxa0lwQmxCRlVBeUdwYy9TVHp4Y1pvTnV6aDFKMzViUk5aV3lkSHQx?= =?utf-8?B?Vlp6YVFMTjFjVEx3QmtTSWQ3T3JWN0tpOUhGV1ZqT2kybkhMazNqZHRSQW16?= =?utf-8?B?MWVoT0FNQWZRcVUybW92VFNxTjl5M0tBMVJZeEJFZjVuL1N6L1VwV0k1alBF?= =?utf-8?B?L21WQWJxSWRYM0NPdXZNZDJWWU1wNVdYMTExcWF4Qkc3bVo5ZlpENWVJSjZr?= =?utf-8?B?bVNBWThUQmR4QTY3cEtYQWtMTUwvcDdCZUlsaWY0cit1VjlsMGRXT2hFYXVP?= =?utf-8?B?ZnV4a3R3QWZsbjhJYnhwbUl4QndKS0lYTzBhL1ZHOEpvdStyRlhieHo4aVBE?= =?utf-8?B?aGhla0tWMjVVemE4Tk1nQThpZzQ1Rk5NTjNKTktjSXRVY0F3TFJPZ09VSm45?= =?utf-8?Q?xTai2jY5Uu21kshJIRsuzJe3h/qtFs+4=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3207.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cfa08d60-41c3-48a9-ff3f-08d8972a4275
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2020 01:25:03.0676 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g1GY8kLP9YnDlVOzK760PLK6BwQdJLiogymAYX9WGVtC+05SpQtQZXFpQ+FDq1gzG+i4/+xpA25Yyad6SrNQ8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3014
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.11, xch-aln-001.cisco.com
X-Outbound-Node: alln-core-7.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/1uQ2xzNY3eg4fX_Zhl6-n4h06Gg>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-rfc8203bis-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Dec 2020 01:25:10 -0000

Dale,

Sorry for not responding directly to your email.
Your concerns were addressed in -07 and more so in
https://tools.ietf.org/html/draft-ietf-idr-rfc8203bis-08

Regards,
Jakob.

-----Original Message-----
From: Dale Worley via Datatracker <noreply@ietf.org> 
Sent: Monday, July 13, 2020 8:33 PM
To: gen-art@ietf.org
Cc: draft-ietf-idr-rfc8203bis.all@ietf.org; last-call@ietf.org; idr@ietf.org
Subject: Genart last call review of draft-ietf-idr-rfc8203bis-06

Reviewer: Dale Worley
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document:  draft-ietf-idr-rfc8203bis-06
Reviewer:  Dale R. Worley
Review Date:  2020-07-13
IETF LC End Date:  2020-07-14
IESG Telechat date:  not known

Summary:

    This draft is basically ready for publication, but has nits that
    should be fixed before publication.

* Minor issues:

3.  Operational Considerations

See the comments about Appendix B.

Appendix B.  Changes to RFC 8203

xThis appendix should describe upward-compatibility considerations.
The body says that the Communication should be limited to 128 octets
if feasible.  But there could be situations where the sender sends a
longer Communication without knowing that the receiver implements
8203bis, and the receiver in fact does not.  How to recover from that
situation?  E.g., will the NOTIFICATION be rejected with a specific
error message?  Can the sender detect the problem by the subsequent
behavior of the receiver?  Is it even well-defined that the receiver
will reject the message?  Can the situation be compensated by
immediately sending another NOTIFICATION without the Communication?

Indeed these considerations probably should be put in section 3.

* Nits/editorial comments:

Abstract

It seems like it would be useful to note here "This document updates
RFC 4486 and obsoletes RFC 8203 by defining an Extended BGP
Administrative Shutdown Communication >>>of up to 255 octets<<< to
improve communication using multibyte character sets." since the
length extension is the only significant change this document
introduces.

1.  Introduction

   via offline methods such email or telephone calls.  This document

Insert "such >>>as<<< email".

2.  Shutdown Communication

      This field is not NULL terminated.

The best phrasing is "NUL terminated", as the name of the character is
NUL.  (See RFC 20.)  However, it is common to say "null terminated",
which is valid because "null" is a common adjective (i.e., not a
proper adjective) that describes the variety of termination.  But
"NULL terminated", though not infrequently used, isn't reallly
correct.  (Unless the RFC Editor says otherwise!)

6.  Security Considerations

   UTF-8 "Shortest Form" encoding is
   REQUIRED to guard against the technical issues outlined in [UTR36].

It might be useful to repeat this restriction in the description of
the Communication field in section 2.

[END]