Re: [Gen-art] Gen-ART review of draft-ietf-dime-app-design-guide-19
Martin Thomson <martin.thomson@gmail.com> Mon, 16 June 2014 23:54 UTC
Return-Path: <martin.thomson@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8BB0C1A02D1 for <gen-art@ietfa.amsl.com>; Mon, 16 Jun 2014 16:54:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3JS7Wsom4UoZ for <gen-art@ietfa.amsl.com>; Mon, 16 Jun 2014 16:54:32 -0700 (PDT)
Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com [IPv6:2a00:1450:400c:c05::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E8D221A02D0 for <gen-art@ietf.org>; Mon, 16 Jun 2014 16:54:31 -0700 (PDT)
Received: by mail-wi0-f172.google.com with SMTP id hi2so4921060wib.11 for <gen-art@ietf.org>; Mon, 16 Jun 2014 16:54:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pStFYNfrXMQxePEC50pmkoM+Zg2prfBPjcMQPuhHe00=; b=you6oI1pmSFJ2WDlG6glBWSUpg1tn2zHqRA/sjf1k7W3GguUBvA0MbLvoGBcEWIDM0 Gw+vWhp3fWpi98Ff+9NI+PRksbv/7XNP0HschxypOyNLkj6KEUs6A8DxCehV5NXJ7GWS c0GbpvhNC9D0UykNw8ahTapJUhwWz67SbMOM2PmlmCQgSfHXX3ObSnvz039lKYUGmyx+ 3iPTaVjed99rUQ4e00hfgjZi6WjveS1V1OwUXNoyLP2md1KUYNZqg9V21yWSY3Oxc3IL gCWo7a5+FErsGEQZZgxB8iiD7Co0YYb1v4FMWce/21EYHZtHts0wHDYwNJ7+31bcL5VK lmGw==
MIME-Version: 1.0
X-Received: by 10.180.19.233 with SMTP id i9mr31780954wie.38.1402962870297; Mon, 16 Jun 2014 16:54:30 -0700 (PDT)
Received: by 10.194.51.134 with HTTP; Mon, 16 Jun 2014 16:54:30 -0700 (PDT)
In-Reply-To: <1231BCB9-DA24-4321-BDEF-F651D8145B8F@gmail.com>
References: <CABkgnnW_JWMC3CVoCpt6gVWzdJWv6ii_rUMtk=bt-=HEBMYGqg@mail.gmail.com> <1231BCB9-DA24-4321-BDEF-F651D8145B8F@gmail.com>
Date: Mon, 16 Jun 2014 16:54:30 -0700
Message-ID: <CABkgnnVt0M-UXroopj_CKy3J++GsaAg9-Hwc0JzWzKKDYFs0JQ@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: Jouni Korhonen <jounikor@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/7cz6i2r0Tf0bP1ZmvmgyBwUBbwc
Cc: draft-ietf-dime-app-design-guide.all@tools.ietf.org, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-dime-app-design-guide-19
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jun 2014 23:54:34 -0000
I just read through the diff of -24. I'm assuming that my feedback was lost somewhere. On 14 September 2013 09:41, Jouni Korhonen <jounikor@gmail.com> wrote: > Martin, > > Thanks for the detailed review. I'll let the authors respond to these if they > have further questions or clarifications to ask. > > - Jouni > > > > On Sep 14, 2013, at 3:13 AM, Martin Thomson <martin.thomson@gmail.com> wrote: > >> I am the assigned Gen-ART reviewer for this draft. For background on >> Gen-ART, please see the FAQ at >> >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >> >> Please resolve these comments along with any other Last Call comments >> you may receive. >> >> Document: draft-ietf-dime-app-design-guide-19 >> Reviewer: Martin Thomson >> Review Date: 2013-09-13 >> IETF LC End Date: unknown, early review >> IESG Telechat date: (if known) >> >> Summary: This document is ready, with some minor issues and nits. >> >> Minor issues: >> I would find it a lot easier to read this document if it did as the >> goals state (the first objective from the introduction) and clarify >> what the extensibility rules in Diameter say with respect to each of >> the described extensions. It's not easy to glean this information >> from RFC 6733, which makes reviewing this a little tricky. >> >> For instance, Section 4.1 doesn't really say what the expectations are >> with respect to implementations that receive unknown or unsupported >> commands. I think that I could guess, but I'd rather not. (I just >> read the relevant parts of 6733, and it turns out that my guess was >> wrong.) >> >> The same applies to Section 4.2, presumably through applying the same >> principles. The question here is: what would be the expected behavior >> if a node was operating on the new application definition and that >> node received a deleted command? (The old implementation presumably >> has no problem with the absence of the command if it's being removed.) >> >> The same applies to Section 5. >> >> Sections 4.4.2 and particularly 5.6 lead me to infer that the >> extensibility for enumerated types is fundamentally broken, so maybe >> those properties need to be expanded upon a little here too. >> >> The placement of the guidance in Section 5.6 seems fairly important >> for Section 4, lest that important information be lost to someone just >> looking to tweak a command. >> >> Section 4.3.1, perhaps add to the M-bit criteria: Would the presence >> or value of the AVP alter the interpretation of the command (or any >> other AVP) in any way? (nit: s/AVPs/AVP on second bullet here.) >> >> I didn't find the list in Section 6 particularly compelling. It >> seemed a little like motherhood statements. The description of what >> it was this was talking about: good; the description of how these >> "often" (always?) manifest is also useful. I wonder though whether >> it's safe to generalize when you only see generic protocols extensions >> as optional AVPs. Perhaps you need to refocus on exactly that, and >> leave the other forms of extension to speculation. >> >> Nits/editorial comments: >> The last paragraph of Section 3 is confusing to me. Firstly, the >> subject of the reminder is missing from the first sentence. I think >> that the intent of that sentence is to say that extending by adding >> applications or commands is to be avoided, but then subsequent >> sentences make it clear that doing so is easy. The last sentence >> seems to be talking about something else entirely, which is the value >> that IANA registries provide. I am going to have to suggest that this >> be reworded entirely. >> >> In Section 4.1, I'd like to see the note turned into real text. The >> size and complexity of an application seems to be a fairly significant >> factor in determining whether a new application imports commands, or >> whether separate applications are defined. >> >> I read the first bullet in Section 4.3.2 as a sentence, several times, >> before realizing that it's a title. Please reconsider the formatting >> of this list. At a very minimum, remove the period. >> >> --Martin >> >> p.s., I'm on vacation starting approximately ...now, since I'm out of >> time for this review... so apologies for any slow responses to the >> review. >
- [Gen-art] Gen-ART review of draft-ietf-dime-app-d… Martin Thomson
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Jouni Korhonen
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Martin Thomson
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Jouni Korhonen
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… lionel.morand
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Martin Thomson
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Jari Arkko
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… lionel.morand
- Re: [Gen-art] Gen-ART review of draft-ietf-dime-a… Jari Arkko