Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07

"jouni.nospam" <jouni.nospam@gmail.com> Tue, 18 October 2016 06:23 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 42E4C12955C; Mon, 17 Oct 2016 23:23:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cu-p0jCja9IX; Mon, 17 Oct 2016 23:23:28 -0700 (PDT)
Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com [IPv6:2607:f8b0:400e:c00::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90A341294F3; Mon, 17 Oct 2016 23:23:28 -0700 (PDT)
Received: by mail-pf0-x22a.google.com with SMTP id e6so88580778pfk.3; Mon, 17 Oct 2016 23:23:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JeWtCWaD6+CfuzKeuVkS6KB8b7+tBw2NPDHXFGypEes=; b=rgOdnELZKhbFWO3OsCM2KHbnUla7mzsZ1g2KNl5WBJzqOTRnwNaHSuiZMQ+8bQ5YJZ odh0atPvSMOvQpIXMN/aAkHZ9m5aZNodGu2IWSyKFOawDgy8z7BDdHuCCMDP/RZP6yxS ebmGO7qCMXkU2iUCVuD9C7vIvFiNsMofNWfGIaha/JYG3RMhgH33LRb5SrAVFv81ZtVI YE8Sj6Sgk29iK1oPFHEg7vxps20vwmYwVwUnMZT6HFX/DDiZeARHspp5Kt+hdfr8K78M oJAACriXnnL1wnn7EjtTJGaVuTsNlTFnkN4O3VzqeszFs2vbYMz0T9B/di23mUAp9q3x t9Kg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=JeWtCWaD6+CfuzKeuVkS6KB8b7+tBw2NPDHXFGypEes=; b=cGynma9lF6tYVlFYiCAt+lRlW091QIvhaTJ6oRqVUTMLO4SbfIB4bnd6LctNQlsrtN +eSXop1y2b3ODZfwikd0UtKARyOURBJnOIf5F0OzEUgqdKtHa8vY46xbNlSpjZ4VpTOg +cePQHpcp3hcg/S1IkcZt9beaFqC/6byTAERJapgVKs6unh50L5rFzef7jOHGJWHPt6V 7xhmyJm4Q8XjhlW/3whOaRikPJ1OCd6ra2oN4U+mMreK0n/XLsoVGvSviB8vnUFpuBsl D3yMQiKe5V8/mRT242q8opXK3w8Ah9rnxxb9VhSKd+NHJNunv6ONlpClrP7fcgL+SSM+ IzCA==
X-Gm-Message-State: AA6/9RmPjBavN01fg9zmplGkcEsP4h4UQByvAnMmPft/vTunPl37G2ngdGg0a5N+x14s8A==
X-Received: by 10.98.19.208 with SMTP id 77mr1996081pft.102.1476771808183; Mon, 17 Oct 2016 23:23:28 -0700 (PDT)
Received: from ?IPv6:2601:647:4200:e520:6038:75a6:9e01:5584? ([2601:647:4200:e520:6038:75a6:9e01:5584]) by smtp.gmail.com with ESMTPSA id id6sm52631979pad.28.2016.10.17.23.23.26 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Oct 2016 23:23:27 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: "jouni.nospam" <jouni.nospam@gmail.com>
In-Reply-To: <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F69B@szxema506-mbs.china.huawei.com>
Date: Mon, 17 Oct 2016 23:23:25 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <822E4CBD-2543-4429-8AE1-F482A45E4316@gmail.com>
References: <499E4913-F08F-439A-82CA-68F91F507E5D@gmail.com> <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F3DA@szxema506-mbs.china.huawei.com> <B9164531-55D4-4655-B6D6-ACC44BB52BF3@gmail.com> <9C5FD3EFA72E1740A3D41BADDE0B461F9CE1F69B@szxema506-mbs.china.huawei.com>
To: "Yemin (Amy)" <amy.yemin@huawei.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/RkTeh7qQsGH9gVXXVLcyDJypEag>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-ccamp-ospf-availability-extension.all@ietf.org" <draft-ietf-ccamp-ospf-availability-extension.all@ietf.org>
Subject: Re: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Oct 2016 06:23:30 -0000

Hi,

> On Oct 17, 2016, at 8:16 PM, Yemin (Amy) <amy.yemin@huawei.com> wrote:
> 
> Hi Jouni,
>  
> You're right that the current draft text doesn't provide any information about the discussion.
> So how about add the following text at the end of section 3.1:
> This document only defines the Availability TLV, how the existing Switching Capability makes use of the Availability TLV will be addressed in a different document. An example is to define a new type code for the Availability TLV, if the Switching Capability-specific information (SCSI) supports TLV format.  

With some rewording I could be OK.. I am not going to be stubborn trying to block this document. Just add that the “different document” is “different future document” or something like that.

Anyway, I am still somewhat surprised there is now a document (this draft under review) defining a new extension to RFC4203 before there is a document that actually describes how to do that in a proper way, specifically if this draft does not want to do that. The order is imho wrong.. just saying..

- Jouni




>  
> Section 3 of RFC7688 provides clear definition for new SC and SCSI. But since the conclusion is to use another different document, other than this document to explain the technology specific usage(including the SC/SCSI allocation), it’s preferred not to include the such text in this document.
>  
> BR,
> Amy
> -----Original Message-----
> From: jouni.nospam [mailto:jouni.nospam@gmail.com] 
> Sent: Monday, October 17, 2016 11:21 PM
> To: Yemin (Amy)
> Cc: gen-art@ietf.org; draft-ietf-ccamp-ospf-availability-extension.all@ietf.org
> Subject: Re: Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
>  
> Hi,
>  
>  
> > On Oct 17, 2016, at 1:06 AM, Yemin (Amy) <amy.yemin@huawei.com> wrote:
> > 
> > Hi Jouni,
> > 
> > Thanks very much for the comments. I fixed the nits in the draft.
> > 
> > Regarding the Switching Capability-specific information field, we had the discussion in WG, and here's the summary/conclusion:
> > It's decided that this document will just define the availability TLV, and a new draft will define its technology specific usage. 
>  
> Ok, thanks for sharing this. This document had no mention or guidance of this kind of decision. I would have assumed some text since the extension defined in this document is seemingly backwards incompatible without some glue. As the text is now, is not sufficient.
>  
> I would appreciate text along lines that can be found in Section 3 of RFC7688 with an addition of the details you point out below regarding the allocation of new Switching-capability types. Also, it would not hurt describing (with the Switching-capability types text) how the situation where an existing non-TLV Switching Capability-specific information and the new TLV-based information have to coexist.. or whether that kind format is not supported.
>  
> - Jouni
>  
>  
> > For example, for the SCSI which supports TLV(e.g., OTN/WSON), a new type code is needed to make use of availability TLV.
> > For the SCSI who doesn’t support TLV(e.g., PSC), a new SC types is needed.
> > 
> > BR,
> > Amy
> > 
> > -----Original Message-----
> > From: jouni.nospam [mailto:jouni.nospam@gmail.com]
> > Sent: Monday, October 17, 2016 5:50 AM
> > To: gen-art@ietf.org
> > Cc: draft-ietf-ccamp-ospf-availability-extension.all@ietf.org
> > Subject: Gen-ATR review of 
> > draft-ietf-ccamp-ospf-availability-extension-07
> > 
> > I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
> > 
> > For more information, please see the FAQ at
> > 
> > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> > 
> > Document: draft-ietf-ccamp-ospf-availability-extension-07
> > Reviewer: Jouni Korhonen
> > Review Date:        2016-10-16
> > IETF LC End Date:   2016-10-24
> > IESG Telechat date: 2016-11-03
> > 
> > Summary:
> > 
> > Document is ready with nits.
> > 
> > Major issues:
> > 
> > None.
> > 
> > Minor issues:
> > 
> > It is not clear to me how the ISCD Availability sub-TLV is encoded
> > into RFC4203 Switching Capability-specific information field. This is
> > because RFC4203 lists specific encodings depending on “Switching Cap”
> > field and those encoded information fields seem not to be TLVs. I
> > would like to see some text that deals with switching cap, its
> > relation to the TLV described in this document and the coexistence
> > with existing capability specific information fields described in
> > RFC4203. If I did not understand something regarding the encoding that
> > is supposed to be trivial I am happy to told that ;)
> > 
> > Nits/editorial comments:
> > 
> > o Line 21: ISCD is not expanded.
> > o Line 142: unnecessary extra space in "a < availability”.
> > o Line 150: Space needed before the reference "protocol[ETPAI].”
> > o Line 142-.. TE is never expanded or part of the list acronyms.
> > o Lines 176-178: formatting issue with indentation, line spacing  and 
> > line endings (not a fullstop but ‘;’).
> > o Line 162: TLV is never expanded or  part of the list acronyms.
> > 
> > __________________________________________