Re: [Gen-art] Gen-ART telechat review of draft-ietf-dime-congestion-flow-attributes-01

"Black, David" <david.black@emc.com> Mon, 08 June 2015 22:33 UTC

Return-Path: <david.black@emc.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18F8F1AC426; Mon, 8 Jun 2015 15:33:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.911
X-Spam-Level:
X-Spam-Status: No, score=-2.911 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0IeGUzjUM9lj; Mon, 8 Jun 2015 15:33:19 -0700 (PDT)
Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB6F81AC41A; Mon, 8 Jun 2015 15:33:19 -0700 (PDT)
Received: from maildlpprd53.lss.emc.com (maildlpprd53.lss.emc.com [10.106.48.157]) by mailuogwprd54.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t58MXGbY031940 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 8 Jun 2015 18:33:17 -0400
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd54.lss.emc.com t58MXGbY031940
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1433802797; bh=4JBw3vhdGX6I17zZvJU3uPzmFag=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=Dx1UrnbCEyVzy3qhOd2ekgpl6tRfYYK/gkgtcjWPTfWynDJp7YU2raZ9biH2w2Jqk jzKj0Ssw08UsBQ/V3au+oJyeMVpyw8571oSlwdWtbnjboRzVS9SJ8AqdOdvVvZ9g/C cIS8vgKppDFsgaJg/G7e6F2RXLWqgVUH17+DuSE4=
X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd54.lss.emc.com t58MXGbY031940
Received: from mailusrhubprd01.lss.emc.com (mailusrhubprd01.lss.emc.com [10.253.24.19]) by maildlpprd53.lss.emc.com (RSA Interceptor); Mon, 8 Jun 2015 18:32:57 -0400
Received: from mxhub07.corp.emc.com (mxhub07.corp.emc.com [128.222.70.204]) by mailusrhubprd01.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t58MX4gt031362 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 8 Jun 2015 18:33:04 -0400
Received: from MXHUB206.corp.emc.com (10.253.68.32) by mxhub07.corp.emc.com (128.222.70.204) with Microsoft SMTP Server (TLS) id 8.3.327.1; Mon, 8 Jun 2015 18:33:04 -0400
Received: from MX104CL02.corp.emc.com ([169.254.8.123]) by MXHUB206.corp.emc.com ([10.253.68.32]) with mapi id 14.03.0224.002; Mon, 8 Jun 2015 18:33:04 -0400
From: "Black, David" <david.black@emc.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>, "draft-ietf-dime-congestion-flow-attributes.all@ietf.org" <draft-ietf-dime-congestion-flow-attributes.all@ietf.org>, General Area Review Team <gen-art@ietf.org>
Thread-Topic: [Gen-art] Gen-ART telechat review of draft-ietf-dime-congestion-flow-attributes-01
Thread-Index: AQHQn0ZGcpdEl6i1yE+ps9GOwezbSZ2jLvHw
Date: Mon, 08 Jun 2015 22:33:03 +0000
Message-ID: <CE03DB3D7B45C245BCA0D243277949360B362EFE@MX104CL02.corp.emc.com>
References: <CE03DB3D7B45C245BCA0D243277949360B3455C0@MX104CL02.corp.emc.com> <55712262.3050802@gmail.com>
In-Reply-To: <55712262.3050802@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.238.44.140]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Sentrion-Hostname: mailusrhubprd01.lss.emc.com
X-RSA-Classifications: DLM_1, public
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/boBiAv_RWiet7q7XMdSvsT_gMPQ>
Cc: "tsv-ads@tools.ietf.org" <tsv-ads@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART telechat review of draft-ietf-dime-congestion-flow-attributes-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2015 22:33:22 -0000

> 1) I suggest that somebody with ECN smarts should glance at it (e.g. David
> Black).

I found an ECN concern, and hence added the TSV ADs to the CC line.

Section 3.2 says:

   The Congestion-Treatment AVP (AVP Code TBD) is of type Grouped and
   indicates how congested traffic, i.e., traffic that has Explicit
   Congestion Notification Congestion Experienced marking set or some
   other administratively defined criteria, is treated.  

That appears to say that the congestion treatment may be applied
solely to packets that have the CE (Congestion Experienced) marking.
That would be a problem, because the defined semantics of a CE marking
is that it applies to the entire flow (e.g., causes TCP to react as if
a packet has been dropped), hence the congestion treatment ought
to apply to the entire flow.

In other words, one wants to be able to use the ECN-IP-Codepoint
AVP as part of the condition that determines whether the filter rule
matches, but ignore that AVP (i.e., wildcard it) in determining what
traffic the action applies to, so that the response to detecting a
congested flow (i.e., packets with ECN field containing CE) applies
to all packets in the flow, regardless of the value in the CE field.

Otherwise, the result may be ineffective, as it won't encompass packets
in the congested flow that aren't CE-marked.

Am I reading the draft correctly?

Thanks,
--David

> -----Original Message-----
> From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Brian E Carpenter
> Sent: Friday, June 05, 2015 12:16 AM
> To: draft-ietf-dime-congestion-flow-attributes.all@ietf.org; General Area
> Review Team
> Subject: [Gen-art] Gen-ART telechat review of draft-ietf-dime-congestion-flow-
> attributes-01
> 
> Nothing to add to my earlier review (i.e. Ready with comments).
> 
>     Brian
> 
> -------- Forwarded Message --------
> Subject: RE: Gen-ART Last Call review of draft-ietf-dime-congestion-flow-
> attributes-01
> Date: Thu, 4 Jun 2015 16:57:49 +0000
> From: Black, David <david.black@emc.com>
> To: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>, Brian E Carpenter
> <brian.e.carpenter@gmail.com>,
> <lionel.morand@orange.com> <lionel.morand@orange.com>
> CC: draft-ietf-dime-congestion-flow-attributes.all@ietf.org <draft-ietf-dime-
> congestion-flow-attributes.all@ietf.org>, General
> Area Review Team <gen-art@ietf.org>, Black, David <david.black@emc.com>
> 
> > 1) I suggest that somebody with ECN smarts should glance at it (e.g. David
> Black).
> 
> Last Call on this draft happened while I was on vacation; I’ll try to take a
> look early next week before the telechat.
> 
> Thanks,
> --David
> 
> From: Kathleen Moriarty [mailto:kathleen.moriarty.ietf@gmail.com]
> Sent: Thursday, June 04, 2015 11:41 AM
> To: Brian E Carpenter; <lionel.morand@orange.com>
> Cc: draft-ietf-dime-congestion-flow-attributes.all@ietf.org; General Area
> Review Team; Black, David
> Subject: Re: Gen-ART Last Call review of draft-ietf-dime-congestion-flow-
> attributes-01
> 
> Brian,
> 
> Thank you for your review.  I agree, the shepherd report should be amended to
> remove the 'updates' language since the extensions
> are optional.
> 
> Thank you,
> Kathleen
> 
> On Sun, May 24, 2015 at 11:59 PM, Brian E Carpenter
> <brian.e.carpenter@gmail.com<mailto:brian.e.carpenter@gmail.com>> wrote:
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Please resolve these comments along with any other Last Call comments
> you may receive.
> 
> Document: draft-ietf-dime-congestion-flow-attributes-01.txt
> Reviewer: Brian Carpenter
> Review Date: 2015-05-25
> IETF LC End Date: 2015-06-01
> IESG Telechat date:
> 
> Summary:  Ready
> --------
> 
> Comment:
> --------
> 
> This is a clear and well-written document. I do have two comments, however:
> 1) I suggest that somebody with ECN smarts should glance at it (e.g. David
> Black).
> 2) The shepherd suggests in the writeup that it should formally update RFC
> 5777.
> But since it describes optional extensions to RFC 5777 that are strictly
> compatible,
> I don't think that's right.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art