Re: [Gen-art] Gen-ART LC review of draft-ietf-trill-loss-delay-05

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 04 August 2014 17:19 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F8761A0026 for <gen-art@ietfa.amsl.com>; Mon, 4 Aug 2014 10:19:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qmv2BKwXuXHv for <gen-art@ietfa.amsl.com>; Mon, 4 Aug 2014 10:19:15 -0700 (PDT)
Received: from waldorf.isode.com (ext-bt.isode.com [217.34.220.158]) by ietfa.amsl.com (Postfix) with ESMTP id 7D2BC1A006C for <gen-art@ietf.org>; Mon, 4 Aug 2014 10:19:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1407172750; d=isode.com; s=selector; i=@isode.com; bh=RmtWfw2KIHQmO5lz2lwYOUejXd9hZE/T25bNSwiDQZQ=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=h3dHBnrEh38tQE0MPk/rwhgB/SZATAJ7NlZeQPAxkxEOqqjL78UfjfLUiBVIO4xTdjn6hR ncr8UQkz5bjvlAHC/V9k96irltlb2ZfnLJKUSvsNlPOB9k3jR0W3Y6EgdSyhevR0jKV+fg 7cWyd59uy3anRWeD+2cf34YnEzWJOWY=;
Received: from [172.20.1.47] ((unknown) [217.34.220.158]) by waldorf.isode.com (submission channel) via TCP with ESMTPA id <U9=AiwAvQ16y@waldorf.isode.com>; Mon, 4 Aug 2014 18:19:10 +0100
X-SMTP-Protocol-Errors: NORDNS
Message-ID: <53DFC08C.90005@isode.com>
Date: Mon, 04 Aug 2014 18:19:08 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
To: Donald Eastlake <d3e3e3@gmail.com>
References: <53DE7FDF.2010907@isode.com> <CAF4+nEGUmH6KUdBEu1FS1N-1fwxR+g1Vzs_m55y=FQsGAyG0pg@mail.gmail.com>
In-Reply-To: <CAF4+nEGUmH6KUdBEu1FS1N-1fwxR+g1Vzs_m55y=FQsGAyG0pg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/lCnkBvGybn7f08XLlBx2bBjCW9I
Cc: "draft-ietf-trill-loss-delay.all@tools.ietf.org" <draft-ietf-trill-loss-delay.all@tools.ietf.org>, "gen-art@ietf.org Review Team" <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART LC review of draft-ietf-trill-loss-delay-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2014 17:19:17 -0000

On 04/08/2014 18:16, Donald Eastlake wrote:
> Hi Alexey,
Hi Donald,
> On Sun, Aug 3, 2014 at 2:30 PM, Alexey Melnikov
> <alexey.melnikov@isode.com> wrote:
>> I am the assigned Gen-ART reviewer for this draft. For background on
>> Gen-ART, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>>
>> Please resolve these comments along with any other Last Call comments you
>> may receive.
>>
>> Document: draft-ietf-trill-loss-delay-05
>> Reviewer: Alexey Melnikov
>> Review Date: 3 August 2014
>> IETF LC End Date: 21 July 2014
>> IESG Telechat date: 7 August 2014
>>
>> Summary: This draft is ready for publication as a Standards Track RFC.
>> [Ready with nits]
>>
>> Major issues: None
>>
>> Minor issues:
>>
>> Section 6.4: who allocated opcodes? I.e. is there a registry?
> These OAM OpCodes were created by and originally all under the control
> of IEEE 802.1; however, 802.1 allocated the block of 32 OpCodes from
> 32 to 63 to ITU-T as documented in [802.1Q]. I don't think ITU-T
> maintains an explicit registry other than the listing of assigned
> OpCodes out of their range that appears in [Y.1731] but I could be
> wrong.
>
> Perhaps a sentence could be added to the end of Section 6.4 such as
> "These OpCodes are from the range of values that has been allocated by
> IEEE 802.1 [802.1Q] for control by ITU-T."
I think that would be very helpful. Otherwise there is a question why 
there is no IANA registry for these and your extra sentence would 
address that.
>> Nits:
>>
>> I think it would be better to say that all "Reserved" fields are set to 0 by
>> the sender and ignored by the receiver.
> I'll check with the other authors on that.
Thank you.