Re: [Idr] TCP & BGP: Some don't send terminate BGP when holdtimer expired, because TCP recv window is 0

Jeffrey Haas <jhaas@pfrc.org> Fri, 18 December 2020 21:49 UTC

Return-Path: <jhaas@pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBE333A0977 for <idr@ietfa.amsl.com>; Fri, 18 Dec 2020 13:49:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KTdV2U4tiNh9 for <idr@ietfa.amsl.com>; Fri, 18 Dec 2020 13:49:47 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 457ED3A0978 for <idr@ietf.org>; Fri, 18 Dec 2020 13:49:47 -0800 (PST)
Received: from dresden.attlocal.net (99-59-193-67.lightspeed.livnmi.sbcglobal.net [99.59.193.67]) by slice.pfrc.org (Postfix) with ESMTPSA id 158CF1E354; Fri, 18 Dec 2020 17:07:15 -0500 (EST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Jeffrey Haas <jhaas@pfrc.org>
In-Reply-To: <CABNhwV05Y+M0neri07kgW9E1zc9xjND6ptVY2e54rPCvNv9E5w@mail.gmail.com>
Date: Fri, 18 Dec 2020 16:49:48 -0500
Cc: Greg Mirsky <gregimirsky@gmail.com>, Brian Dickson <brian.peter.dickson@gmail.com>, "Jakob Heitz (jheitz)" <jheitz=40cisco.com@dmarc.ietf.org>, "idr@ietf.org" <idr@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0F8752F1-D2AC-4A82-92EE-38FBBB9AA204@pfrc.org>
References: <9D6268BD-C555-4B9A-A883-9B55EEB5D5DA@juniper.net> <91D9B9F7-0DBE-45E6-84D5-2E3D9F8C44A1@tix.at> <X9kweQ5EtTL7tOAM@bench.sobornost.net> <CAOj+MMFySPXpE8QxcO+7szKzQ78faQASYKnBUYg_h_aLd=P4Lg@mail.gmail.com> <BYAPR11MB3207412804697588E4AA3F03C0C60@BYAPR11MB3207.namprd11.prod.outlook.com> <20201216093614.GI68083@diehard.n-r-g.com> <4E9BEA12-998A-4AD1-B342-4F26AA6EBA69@cisco.com> <20201216174319.GM68083@diehard.n-r-g.com> <BYAPR11MB320759EE6ABC8AB863BC1838C0C50@BYAPR11MB3207.namprd11.prod.outlook.com> <CAH1iCipjgS4-NPTjNhc7Cj73bitWgTcw=ufax7iOCCnT+xGiZQ@mail.gmail.com> <20201216220122.GE24940@pfrc.org> <CAH1iCiotC-9tQcfNkcJKH=OcEovi1ztZoJ_eiKg_mA-Wp+FJNw@mail.gmail.com> <CDC2CE54-6DC3-48AB-B9C1-3562F279D2C1@pfrc.org> <CABNhwV05Y+M0neri07kgW9E1zc9xjND6ptVY2e54rPCvNv9E5w@mail.gmail.com>
To: Gyan Mishra <hayabusagsm@gmail.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/su8X82SZlUMleLNbCDEehuhQ6c4>
Subject: Re: [Idr] TCP & BGP: Some don't send terminate BGP when holdtimer expired, because TCP recv window is 0
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Dec 2020 21:49:49 -0000

Gyan,


> On Dec 18, 2020, at 3:44 PM, Gyan Mishra <hayabusagsm@gmail.com> wrote:
> 
> Jeffrey 
> 
> + Greg Mirsky 
> 
> Would a simple solution be to use BFD RFC 5880 for liveliness detection single hop in async mode with BGP to bring down the protocol BGP registered with BFD.

BFD is used for BGP regularly.  The use of it for ISP to ISP connections, as in the issue described, is not very typical.  Resiliency of the session is far more important for ISP to ISP communication than fast failure.

For BFD sessions to customers, fast failure is sometimes used.


> 
> As the application is not a file transfer between end hosts, and is two routers running BGP I don’t know if BGP implementation has a IPC call that signals BGP to hang on let’s wait for the receiver RTB to clear his buffer and signal with non zero ack.  If BGP could sense the TCP receive window 0 via IPC that would be best and immediately tear down BGP and send notification hold timer expired.

BGP implementations vary quite a bit.  Simpler implementations that pay only attention to basic socket APIs would simply see things like EWOULDBLOCK, EAGAIN or similar if doing async stuff.  If they're doing blocking sockets (unusual!), the implementation simply hangs.

FWIW, blocked sockets for this sort of thing is usually a socket programmer's first introduction to things that cause zero-windowing.

> During this time until the BGP hold time expires default 90 seconds traffic is not able to reroute on an alternate path and we are black holding traffic until RTRB sends BGP notification hold time expired followed by TCP RST and BGP peer session torn down.

It's important for the general case to realize that just because BGP is wedged up (control plane) that the forwarding plane may - or may not - be fine.  You can't tell from BGP.

What you do know in the abstract is that you care about the sessions being healthy in particular:
1. If you're not able to receive updates from your peer, you may end up with stale forwarding via that peer.
2. If you have stuff to send to the peer, they may end up with stale forwarding to you.

In that second case, you have a better local sense as to how urgent being stuck is.  If you have thousands of updates queued, it's probably dire.  If you have a few... is it?  If it's for a low priority network, maybe not.  If it's for google, probably much more important.

But in general, being stuck or out of sync is a problem.

But similarly, in general, the cost of dropping and re-establishing a peering session is very high.  So, there's resistance to knocking a session over because it's had some level of "temporary" hiccup.  Your definition of "temporary" will vary, and thus part of the motivation for this conversation.

> In this case we are guessing that the TCP receive buffer is full because the link is congested and so cannot process any more packets on the NIC including BGP or BFD control packets.

The fate is potentially shared, but not a guarantee.  If the congestion is happening because traffic is selectively dropping for your BGP session, BFD may behave fine.  Perhaps you have a congestion issue to your  router's CPU, but the line card's BFD is fine.


> 
> So in this particular case with BFD Asynchronous mode enabled let’s say with interval 50ms and multiplier 3 as soon as soon as Receiver RTR-B misses 3 consecutive BFD control packets it pulls down the BGP session within 150ms at which time RTR-B sends notification log message that the hold time has expired and TCP RST is sent closing the session to RTR-A.

This would be way too short for most ISP scenarios. 

> BFD used UDP 6784 and is checking link integrity liveliness which would be fine and not fail if the link is not congested.  So then if BGP is having an issue with the TCP session being in a paused state is their IPC TCP to BGP to BFD.

TCP session state is very decoupled from UDP state, so the best inference you can make is "BFD works, TCP hopefully can get through?"  But as I noted above, there's no guarantee of that.

For a different flavor of this type of problem, IS-IS doesn't use IP transport.  This means IP forwarding can be broken but you can get ISO packets through.

> I think this second scenario where the link is not congested and TCP is stuck can be easily tested in a lab with a Spirent traffic generator.

I'd suggest playing with selective packet loss for a link for a busy TCP session.  You should find that with no more than 15% of TCP packet loss that your throughput becomes terrible, and sessions may simply fail because the TCP ACK necessary to advance the window may simply not get through.

-- Jeff