[Int-dir] Intdir telechat review of draft-ietf-bess-evpn-fast-df-recovery-09
Dave Thaler via Datatracker <noreply@ietf.org> Tue, 13 August 2024 17:41 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: int-dir@ietf.org
Delivered-To: int-dir@ietfa.amsl.com
Received: from [10.244.2.52] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 154EBC151553; Tue, 13 Aug 2024 10:41:33 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Dave Thaler via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.22.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172357089271.963513.5728716417559734076@dt-datatracker-6df4c9dcf5-t2x2k>
Date: Tue, 13 Aug 2024 10:41:32 -0700
Message-ID-Hash: B3HXXORBASLEQZADF2NAOA36G7YR4N2P
X-Message-ID-Hash: B3HXXORBASLEQZADF2NAOA36G7YR4N2P
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-int-dir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: bess@ietf.org, draft-ietf-bess-evpn-fast-df-recovery.all@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Dave Thaler <dave.thaler.ietf@gmail.com>
Subject: [Int-dir] Intdir telechat review of draft-ietf-bess-evpn-fast-df-recovery-09
List-Id: "This list is for discussion between the members of the Internet Area directorate." <int-dir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/int-dir/_k0K5M06_7CSAl2pf2b-iKWKGiw>
List-Archive: <https://mailarchive.ietf.org/arch/browse/int-dir>
List-Help: <mailto:int-dir-request@ietf.org?subject=help>
List-Owner: <mailto:int-dir-owner@ietf.org>
List-Post: <mailto:int-dir@ietf.org>
List-Subscribe: <mailto:int-dir-join@ietf.org>
List-Unsubscribe: <mailto:int-dir-leave@ietf.org>
Reviewer: Dave Thaler Review result: Ready with Nits I am the assigned INTDIR reviewer. I found the document well written and easy to read, other than a number of typos and grammatical errors. A PDF with my comments marked up inline can be found at: https://1drv.ms/b/s!Aqj-Bj9PNivcn_xoEc8XRepNkAgJaQ?e=7keL4H A few of my comments are listed below, but see the PDF for many more trivial ones. Section 1.4: "The fast DF recovery solution maintains backwards-compatibility (see Section 4) by ensuring that PEs any unrecognized new BGP Extended Community." I can't parse grammar around "PEs any unrecognized". Perhaps a word missing? Section 2.1: Is it worth adding that the seconds are encoded in network byte order? This might be assumed by most readers but might not hurt to say explicitly. Up to you. Section 3: "To maintain the preference for minimal loss over duplicate traffic, PE1 should carve slightly before PE2 (with skew)." Should the "should" be MUST or SHOULD? Section 4: "[RFC7432] and do not rely on the new SCT BGP extended community." And what? Seems like something is missing here. Dave
- [Int-dir] Intdir telechat review of draft-ietf-be… Dave Thaler via Datatracker
- [Int-dir] Re: [bess] Intdir telechat review of dr… Luc André Burdet