Re: [Isis-wg] comments on draft-litkowski-isis-yang-isis-cfg-01

<stephane.litkowski@orange.com> Tue, 22 July 2014 20:03 UTC

Return-Path: <stephane.litkowski@orange.com>
X-Original-To: isis-wg@ietfa.amsl.com
Delivered-To: isis-wg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 874C01A038E for <isis-wg@ietfa.amsl.com>; Tue, 22 Jul 2014 13:03:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NAJ41W4nPU5n for <isis-wg@ietfa.amsl.com>; Tue, 22 Jul 2014 13:03:24 -0700 (PDT)
Received: from relais-inet.francetelecom.com (relais-ias91.francetelecom.com [193.251.215.91]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 044B61A023E for <isis-wg@ietf.org>; Tue, 22 Jul 2014 13:03:24 -0700 (PDT)
Received: from omfedm07.si.francetelecom.fr (unknown [xx.xx.xx.3]) by omfedm10.si.francetelecom.fr (ESMTP service) with ESMTP id 409A7264FE9; Tue, 22 Jul 2014 22:03:22 +0200 (CEST)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [10.114.31.30]) by omfedm07.si.francetelecom.fr (ESMTP service) with ESMTP id 1B5E44C015; Tue, 22 Jul 2014 22:03:22 +0200 (CEST)
Received: from OPEXCLILM34.corporate.adroot.infra.ftgroup ([169.254.4.77]) by OPEXCLILH02.corporate.adroot.infra.ftgroup ([10.114.31.30]) with mapi id 14.03.0181.006; Tue, 22 Jul 2014 22:03:22 +0200
From: <stephane.litkowski@orange.com>
To: "Wunan (Eric)" <eric.wu@huawei.com>, "isis-wg@ietf.org" <isis-wg@ietf.org>
Thread-Topic: comments on draft-litkowski-isis-yang-isis-cfg-01
Thread-Index: Ac+l4qtZhrh5j6gJR3OwDOjb/Qkn+QAA+Bmw
Date: Tue, 22 Jul 2014 20:03:21 +0000
Message-ID: <4223_1406059402_53CEC38A_4223_4491_1_9E32478DFA9976438E7A22F69B08FF92044506@OPEXCLILM34.corporate.adroot.infra.ftgroup>
References: <0F26584357FD124DB93F1535E4B0A65036804905@szxema508-mbx.china.huawei.com>
In-Reply-To: <0F26584357FD124DB93F1535E4B0A65036804905@szxema508-mbx.china.huawei.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.5]
Content-Type: multipart/alternative; boundary="_000_9E32478DFA9976438E7A22F69B08FF92044506OPEXCLILM34corpor_"
MIME-Version: 1.0
X-PMX-Version: 6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2014.7.22.141219
Archived-At: http://mailarchive.ietf.org/arch/msg/isis-wg/CqrhC0T10_A2kQUPyFKPuCo2i7I
Subject: Re: [Isis-wg] comments on draft-litkowski-isis-yang-isis-cfg-01
X-BeenThere: isis-wg@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: IETF IS-IS working group <isis-wg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/isis-wg/>
List-Post: <mailto:isis-wg@ietf.org>
List-Help: <mailto:isis-wg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/isis-wg>, <mailto:isis-wg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jul 2014 20:03:27 -0000

Hi,

Thanks for your comment.
It seems that your are IOS CLI familiar :)
As I pointed to OSPF wg meeting, Yang datamodel does not require to be a CLI mirror.

Inline answers ...

From: Wunan (Eric) [mailto:eric.wu@huawei.com]
Sent: Tuesday, July 22, 2014 15:26
To: LITKOWSKI Stephane SCE/IBNF; isis-wg@ietf.org
Cc: Lizhenbin; Yangang
Subject: comments on draft-litkowski-isis-yang-isis-cfg-01


Hi Stephane,



Some comments below. Please check.



1. +--rw isis

Should be a list here with a key like [name] or [local-id] here?



[SLI] The name of the protocol instance comes from the "routing-protocol* [name]" container in core routing model.





2. +--rw nsap-address in isis-cfg container,

"nsap-address" is used here but "system-id" is used isis-state. Suggest to use same one.

And one isis can have at least three NSAP since area address can be different.



[SLI] NSAP address type is AREA+SYSTEMID+NSEL while system-id type is only systemid that's why I needed two types.

I agree that we may extend to multiple area ... this is just a first shot , so some parts are missing ...





3. +--rw ipv4-router-id?

    +--rw ipv6-router-id?

Not sure the use here.



[SLI] Definition of address of TLV134 and 140



4. Missing vrf association ?



[SLI] No the protocol definition is within a routing-instance in the core datamodel .



5. Missing nsf ?



[SLI] NSF is cisco :( you may  refer to GR or NSR stuffs ? HA features are not there yet.



6. Missing traffic engineering ?



[SLI] Only wide metrics are there , but not traffic-eng. I was wondering if TE should be part of a separate datamodel (using augmentation) and so can be used for both OSPF and ISIS protocols ... point to discuss ...



7. Missing Timer related cfg ?



[SLI] Some timers are there ... some may be missing. Which timer are your referering to ?



8. Missing redistribution related cfg ?



[SLI] Route-filters are part of the core data model. But maybe we need to augment stuffs ... I did not look at it yet.



9. Multi-topology should allow to configure more besides ipv4-uni, ipv6-uni, ipv4-multi, ipv6-multi

These are commonly used configuration which should not be omitted.



[SLI] Please provide more details on what you want.



10. isis route configuration and operation should be included in isis-cfg and isis-state ?



[SLI] Don't understand the comment ...



11. interfaces and TE state should be included in isis-state



[SLI] Interface state is not there yet ... for TE, it must be part of the TE modeling discussion ...



_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.