Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08
"Adrian Farrel" <adrian@olddog.co.uk> Wed, 25 January 2017 10:12 UTC
Return-Path: <adrian@olddog.co.uk>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B65CD12985C; Wed, 25 Jan 2017 02:12:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SUZmhGE0KFif; Wed, 25 Jan 2017 02:12:12 -0800 (PST)
Received: from asmtp2.iomartmail.com (asmtp2.iomartmail.com [62.128.201.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F0EBB129842; Wed, 25 Jan 2017 02:12:11 -0800 (PST)
Received: from asmtp2.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id v0PAC2Ae019312; Wed, 25 Jan 2017 10:12:02 GMT
Received: from 950129200 ([176.241.250.4]) (authenticated bits=0) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id v0PABwA3019253 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 25 Jan 2017 10:12:00 GMT
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'wangzitao' <wangzitao@huawei.com>, 'Ron Bonica' <rbonica@juniper.net>, lime@ietf.org, draft-ietf-lime-yang-oam-model.all@ietf.org
Date: Wed, 25 Jan 2017 10:11:56 -0000
Message-ID: <02a401d276f3$77b84060$6728c120$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdJ280EYKdbWQvUeS+KxVe4f7/VzSQ==
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.1.0.1062-22844.005
X-TM-AS-Result: No--24.358-10.0-31-10
X-imss-scan-details: No--24.358-10.0-31-10
X-TMASE-MatchedRID: H0/uSqZo4D6nykMun0J1wvHkpkyUphL9Ud7Bjfo+5jQ5CCUkHUNu7qSZ V8xpDzhZsrkI/KGx8vAKRLt/1s9XbWm9EZ0V6jiDaqa/YVBLYUkITdx0fxCcBdOwk6TvElPUp7w 8lBHFpo8j9ieCZ7IcnosSL9QovDDczMLMZrH3XeP0hv/rD7WVZOiY+s2L3xQEEEa3bn/bcwiwv7 cq/6p3lEb5rFbSbHVK/AVTczXT78uLI5pTMqjebzEBZ9jBEiDRAZn/4A9db2S0Vg+MnSE2GLouM 63AneY0vAL79ZNefDxHRIpOdliZ+9XQ2R27CZyz+cLcTg72Fvz4uJ1REX4MHWxcaWaRBbCwQQ/s 9vEJJnenEV8M9iZlA6+Hd7B+w2tcqCNd72dlxcuzI1v7J4hECiHAogh2SU5Xu77GjTkTwiDGEfo tTZgUJQS7nljjkymVwJ791RsjtuAXwXUmM6vIadjDJsU1r62bgYy8y+HaPlZO447EfatP8XWCd6 QvVzbepD2/oONjde6hLzi65Nj7MpsYdIGP6PlZbQ9aoPSmWJEhotH7bEpEMqfnINz0/CVcMY+4O QNXcFG91PzpUv9d/1mfzDNjcCxqH5chC2o3feKt0sUUpHt26X0tCKdnhB58avU8OIEwowLUZxEA lFPo846HM5rqDwqtlExlQIQeRG0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/PdpdLMRrH_GxNdmD5GNNzM0sva0>
Subject: Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jan 2017 10:12:13 -0000
Thanks Michael, That all looks good. Adrian > -----Original Message----- > From: wangzitao [mailto:wangzitao@huawei.com] > Sent: 25 January 2017 02:22 > To: adrian@olddog.co.uk; 'Ron Bonica'; lime@ietf.org; draft-ietf-lime-yang-oam- > model.all@ietf.org > Subject: RE: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 > > Thank Adrian for these valuable comments, please find my reply inline. > > Best Regards! > -Michael > > -----邮件原件----- > 发件人: Adrian Farrel [mailto:adrian@olddog.co.uk] > 发送时间: 2017年1月25日 7:38 > 收件人: 'Ron Bonica'; lime@ietf.org; draft-ietf-lime-yang-oam- > model.all@ietf.org > 主题: RE: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 > > Hi, > > I read through this document again and think it is ready for publication. > > Here are some minor things to ix along the way. > > Thanks, > Adrian > === > You might sort out the line lengths. > [Michael]: Yes, I can fix it. > > --- > Abstract is missing a final period. > [Michael]: Thanks, I will fix it in next version. > --- > Some of the references in sections 1 8 and 9 seem to be duplicated. > [Michael]: Yes, I will fix it. > --- > The last sentence of section 2 presumably belongs with the first paragraph. > [Michael]: Indeed, it need to be fixed. > --- > The text in section 2 that defines the notation used in the trees that are found in > this document is useful, but I suspect it of being generic. > (It would be nice if this was in a separate document so that everyone can > reference it, but that is not the job of these authors or this WG.) > > I did find several parts of the text confusing and I wondered whether: > - you can can drop the statuses that are not used in this document > (I think there are no deprecated or obsoleted objects) > [Michael]: Yep, the deprecated/obsolete statement is not used. Moving this flag > from the section make sense for me. > > - add the other flags that are used (I see, "w" although I am surprised > to find what is effective a write-only object so perhaps that is an > error?) > [Michael]: Agree. > - give simple examples (because "x" and "-x" may be hard to distinguish) > [Michael]: Agree. > --- > In 4 you have > Under each MA, there can be two or more MEPs (Maintenance Association > End Points). > But your primary expansion of MEP in section 2.1 is different. > [Michael]: Yes, it need to be fixed. > --- > Sections 1 and 2.1 use "RPC" the rest of the document uses "rpc" > [Michael]: Yes, it need to be synchronized. I'd like to fix it. > --- > Section 4.4 has > Please refer to Section 4 for the complete > data hierarchy > which is a bit odd given that we are in the middle of section 4. > [Michael]: Yes, it seems odd, I think it can be modified to "Please refer to Section > 4.5 for the complete > data hierarchy". > --- > Not asking you to do it, but why after the whole of section 4, why are there no > "fragments" in section 4.5? > --- > A number of description clauses need to begin with capital letters. > [Michael]:You are right, I will fix it in next version. > --- > loss-of-continuity refers to the receiving MEP's configured CC-V reception period. > I cannot find where I can read the value of that. > [Michael]: I'd like to discuss with my coauthor to decide whether we need this > attributes > --- > Any reason why sometimes > > leaf cc-transmit-interval { > type Interval; > description > "Interval between echo requests"; > } > > and sometimes > > leaf interval { > type Interval; > description > "Interval between echo requests"; > } > [Michael]: according to previous discussion, for continuity check, there is a little of > difference on same terminology For example: > for mpls-tp, there are transmit-interval and receive-interval, therefore, we > defined this attribute as cc-transmit-interval. > --- > Why is there a minimum packet-size of 64 octets? > Why can't I send smaller CC and CV packets? > [Michael]: I agree with your concern, especially consider for future technologies, > restrict the minimum packet-size as 64 octets seems not good idea. > I would like to discuss with coauthor and may be change it in next version. > --- > Stray text "YANG module of OAM" right at the end of the module? > [Michael]: yes, it need to be fixed. > --- > 6.2 has MEPID and MEP-ID and MEP ID. > [Michael]: Yes, it need to be synchronized. > --- > 6.2 has > In this document we propose to extend the range to 0 to > 65535. > s/propose to extend/extend/ > [Michael]: Agree. > --- > 6.3 has "MAID" unexpanded. This is probably just the ID of the MA, but ... > [Michael]: Yes, you are right, I would like to fix it. > Section 7 has > This section demonstrates the usability of the connection-oriented > YANG OAM data model to various connection-oriented OAM technologies, > e.g., TRILL and MPLS-TP. > This should probably be > This section demonstrates the applicability of the connection-oriented > YANG OAM data model to TRILL and MPLS-TP. > [Michael]: This section demonstrates the CO model's applicability, it introduce the > method of augmenting the CO model to derived technology specific model. > Trill and MPLS-TP are just some examples. > --- > I think the affiliations and emails of the Contributors and Authors need to be > double-checked. > [Michael]: Agree.
- [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Ron Bonica
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 顾 戎
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Adrian Farrel
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Adrian Farrel
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Greg Mirsky
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Greg Mirsky
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Ron Bonica
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Huub van Helvoort