Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08
"Adrian Farrel" <adrian@olddog.co.uk> Tue, 24 January 2017 23:38 UTC
Return-Path: <adrian@olddog.co.uk>
X-Original-To: lime@ietfa.amsl.com
Delivered-To: lime@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E0C99129587; Tue, 24 Jan 2017 15:38:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.62
X-Spam-Level:
X-Spam-Status: No, score=-2.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c4pRvFx0DwiK; Tue, 24 Jan 2017 15:38:18 -0800 (PST)
Received: from asmtp5.iomartmail.com (asmtp5.iomartmail.com [62.128.201.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1569129563; Tue, 24 Jan 2017 15:38:17 -0800 (PST)
Received: from asmtp5.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp5.iomartmail.com (8.13.8/8.13.8) with ESMTP id v0ONcFw2003072; Tue, 24 Jan 2017 23:38:15 GMT
Received: from 950129200 ([176.241.250.4]) (authenticated bits=0) by asmtp5.iomartmail.com (8.13.8/8.13.8) with ESMTP id v0ONc9Qj002995 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Tue, 24 Jan 2017 23:38:12 GMT
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Ron Bonica' <rbonica@juniper.net>, lime@ietf.org, draft-ietf-lime-yang-oam-model.all@ietf.org
References: <BLUPR0501MB205177A13A7296589844029AAE7E0@BLUPR0501MB2051.namprd05.prod.outlook.com>
In-Reply-To: <BLUPR0501MB205177A13A7296589844029AAE7E0@BLUPR0501MB2051.namprd05.prod.outlook.com>
Date: Tue, 24 Jan 2017 23:38:07 -0000
Message-ID: <01ea01d2769a$ee14fe00$ca3efa00$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQJSzyBK/6xgK1hxCKL+ZH9ZsAIB8aBHlH0w
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.1.0.1062-22844.003
X-TM-AS-Result: No--7.915-10.0-31-10
X-imss-scan-details: No--7.915-10.0-31-10
X-TMASE-MatchedRID: X4bcv0S75KldpLkh5p97g/v+//lqU1h6JgRcbv1OyK+WSyNgdonoDh/X WBLkU7futWuxKvia8BALxwEDmpwfROOnBr3Mmp5GMQFn2MESINEBmf/gD11vZLRWD4ydITYYui4 zrcCd5jS8Avv1k158PEdEik52WJn71dDZHbsJnLNc/msUC5wFQX5Lmbb/xUuaHzB6p8SFnxFaLB gc5OD1gOLU6iRp2zHXJMkL05Agwhd48YB5KfXbgsCMrUomCWc6pfVcx39Kq+7czkKO5k4APn88J 2DCeEZt9aAK/U6GfKjMbaBg/PQOubvhKf49TtYADB+ErBr0bAOscK/K2DlvjkFF7QZ35lZ3LqZd 1G/sK1kriEKQi78d2ERZVAyieX2hj2hRzH1UwuA5f9Xw/xqKXdivpTdmVCR2xEHRux+uk8hUW0/ J/LzLMJ8xG3WrGPL0OCIE+mUe8tzHFV2hZgXqf0OJbBb+mJnN/i1tttGDU1Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/lime/mIFglh0FIvFDS_5MwqA5oYWWjwY>
Subject: Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08
X-BeenThere: lime@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: "Layer Independent OAM Management in Multi-Layer Environment \(LIME\) discussion list." <lime.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lime>, <mailto:lime-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lime/>
List-Post: <mailto:lime@ietf.org>
List-Help: <mailto:lime-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lime>, <mailto:lime-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2017 23:38:20 -0000
Hi, I read through this document again and think it is ready for publication. Here are some minor things to ix along the way. Thanks, Adrian === You might sort out the line lengths. --- Abstract is missing a final period. --- Some of the references in sections 1 8 and 9 seem to be duplicated. --- The last sentence of section 2 presumably belongs with the first paragraph. --- The text in section 2 that defines the notation used in the trees that are found in this document is useful, but I suspect it of being generic. (It would be nice if this was in a separate document so that everyone can reference it, but that is not the job of these authors or this WG.) I did find several parts of the text confusing and I wondered whether: - you can can drop the statuses that are not used in this document (I think there are no deprecated or obsoleted objects) - add the other flags that are used (I see, "w" although I am surprised to find what is effective a write-only object so perhaps that is an error?) - give simple examples (because "x" and "-x" may be hard to distinguish) --- In 4 you have Under each MA, there can be two or more MEPs (Maintenance Association End Points). But your primary expansion of MEP in section 2.1 is different. --- Sections 1 and 2.1 use "RPC" the rest of the document uses "rpc" --- Section 4.4 has Please refer to Section 4 for the complete data hierarchy which is a bit odd given that we are in the middle of section 4. --- Not asking you to do it, but why after the whole of section 4, why are there no "fragments" in section 4.5? --- A number of description clauses need to begin with capital letters. --- loss-of-continuity refers to the receiving MEP's configured CC-V reception period. I cannot find where I can read the value of that. --- Any reason why sometimes leaf cc-transmit-interval { type Interval; description "Interval between echo requests"; } and sometimes leaf interval { type Interval; description "Interval between echo requests"; } --- Why is there a minimum packet-size of 64 octets? Why can't I send smaller CC and CV packets? --- Stray text "YANG module of OAM" right at the end of the module? --- 6.2 has MEPID and MEP-ID and MEP ID. --- 6.2 has In this document we propose to extend the range to 0 to 65535. s/propose to extend/extend/ --- 6.3 has "MAID" unexpanded. This is probably just the ID of the MA, but ... --- Section 7 has This section demonstrates the usability of the connection-oriented YANG OAM data model to various connection-oriented OAM technologies, e.g., TRILL and MPLS-TP. This should probably be This section demonstrates the applicability of the connection-oriented YANG OAM data model to TRILL and MPLS-TP. --- I think the affiliations and emails of the Contributors and Authors need to be double-checked.
- [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Ron Bonica
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 顾 戎
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Adrian Farrel
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Adrian Farrel
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Greg Mirsky
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 wangzitao
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Greg Mirsky
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Ron Bonica
- Re: [Lime] WGLC: draft-ietf-lime-yang-oam-model-08 Huub van Helvoort