Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo

Robert Raszuk <robert@raszuk.net> Tue, 18 August 2020 17:10 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F6B03A1025 for <lsr@ietfa.amsl.com>; Tue, 18 Aug 2020 10:10:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OkCTTR85UmYz for <lsr@ietfa.amsl.com>; Tue, 18 Aug 2020 10:10:36 -0700 (PDT)
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 724C03A1020 for <lsr@ietf.org>; Tue, 18 Aug 2020 10:10:36 -0700 (PDT)
Received: by mail-ed1-x52e.google.com with SMTP id cq28so15858709edb.10 for <lsr@ietf.org>; Tue, 18 Aug 2020 10:10:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZvSLv+hrqVw6sBbawRdei+RUVl4PXidhqMo3s0GagW0=; b=KB9SUrVuzysFRo/VjEkT73wA/lGxhAKjaPAoPE1nPo7uoBdjepTn1b93WOU/hNdu/d m6QhpgxEYI8o8My7xJylLngx2br3hJYeFXb1+i0sh99Zio09s725NjPBefVNjbWGJWhR WKvATiUEaii1zFhaPsMwL/2Lf+NaZYqD001unAgT8IM4YS8jl77atAG2gVDKz1cfnA0w P8bLZ7Fj/VJbwf7AIFDvMZtKbEenrgdm+qLQHRcHpPPanz0f777Rugz1nRarrdLPKkKn ViG2zkONO5ilutwL0/m3+8EgEFOgIg4G2Tsm6pDH8w9/QiTXBL0whZtIzzr7UqPxdcGQ lbOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZvSLv+hrqVw6sBbawRdei+RUVl4PXidhqMo3s0GagW0=; b=FNWL12gbnoB1TdeNIB5tUAFw+zcy/Upc2DOJA/zUURrYrQeLwXCDq+vCZ8Zv8S/Ifg viaNS9xvmk1U4nSvTseW67ZKa0DWBspflaOcm+YB57czWqgJpfryHTghsGWpwnqOwCBA pYPtLQ81jHAHsqLUWc2MzXm9vwp5wVOaw1Teerk54YzZQoMheKkeqizAgUNSPOEgqjlw sK5FO8YAwMC44TtT2qGdINTGVfg/1SDGc5RbHNuAT8l523WLdmi0XgmhC0xxjRaRQZHl 4f5yjik9VX9b/zT+uFqzD8GF2I4Fi66tlP3FoYycZ8xtKdFQMLFQ5zsNHtGtBsez0/XM y2Uw==
X-Gm-Message-State: AOAM532iMdxrU0IvM1maXlumyb7wirusi6FqGBvTKanTYcRAL/J0Q9Bd /+9kbzpjYu3eMFU5jZe0ENl9lViUwHPE0ehtIHe9vg==
X-Google-Smtp-Source: ABdhPJwkPT4ztLKiInMld2JNhwCp4Fk7k5viaXDO+oXnHOq03mIwrpgXX652iDNkyIE6gTcdXwh2lCx2cD3zhmyojYo=
X-Received: by 2002:a05:6402:a5b:: with SMTP id bt27mr21197923edb.120.1597770634779; Tue, 18 Aug 2020 10:10:34 -0700 (PDT)
MIME-Version: 1.0
References: <9094873B-3A03-4F48-B438-55AB0CA75396@chopps.org> <E9DF9CDA-D031-4995-BB69-7A9CEE312707@tony.li> <dff9ca08-8950-ef1c-5926-39944e94c98b@cisco.com> <E6A4AB1E-6A37-4424-8E27-2F0BFE7E3313@tony.li> <BY5PR11MB4337D97F838FFD8B250BACB1C15C0@BY5PR11MB4337.namprd11.prod.outlook.com> <CAOj+MMG9_yBK7-qWLA6Xfsq-4u4hpXz4x5FSdLA0arBw9cdc+g@mail.gmail.com> <7D686875-46CA-4E3C-8F1A-3A02DB162499@tony.li>
In-Reply-To: <7D686875-46CA-4E3C-8F1A-3A02DB162499@tony.li>
From: Robert Raszuk <robert@raszuk.net>
Date: Tue, 18 Aug 2020 19:10:24 +0200
Message-ID: <CAOj+MMGDTTW7mpq0JsWL2Xu58C2RassvRrxH9nDOuY5c5QKtBQ@mail.gmail.com>
To: Tony Li <tony.li@tony.li>
Cc: "Les Ginsberg (ginsberg)" <ginsberg=40cisco.com@dmarc.ietf.org>, Peter Psenak <ppsenak@cisco.com>, "lsr@ietf.org" <lsr@ietf.org>, "lsr-ads@ietf.org" <lsr-ads@ietf.org>, Christian Hopps <chopps@chopps.org>, "Acee Lindem (acee)" <acee@cisco.com>, "draft-ietf-lsr-flex-algo.all@ietf.org" <draft-ietf-lsr-flex-algo.all@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000001e776405ad29f728"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/HT7YPcmUQYZw8khBlDeI16lYhXU>
Subject: Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 17:10:39 -0000

Hi Tony,

I am not sure what the deal is :)

But fact is that we never defined a type which this draft is referring to

"Min Unidirectional Link Delay" just does not exist in any IANA registry so
even any search for that will fail.

Perhaps authors assumed that:

Min/Max Unidirectional Link Delay means both "Min Unidirectional Link
Delay" & "Max Unidirectional Link Delay" but this is just asking
for ambiguity.

Cheers,
R.

On Tue, Aug 18, 2020 at 7:02 PM <tony.li@tony.li> wrote:

>
> Robert,
>
> Thank you, exactly.
>
> We just need a clarification of the document.  I don’t understand why this
> is such a big deal.
>
> Tony
>
>
> On Aug 18, 2020, at 9:22 AM, Robert Raszuk <robert@raszuk.net> wrote:
>
> Les,
>
> I think this is not very obvious as Tony is pointing out.
>
> See RFC 8570 says:
>
>       Type    Description
>       ----------------------------------------------------
>        33     Unidirectional Link Delay
>
>        34     Min/Max Unidirectional Link Delay
>
>
> That means that is someone implementing it reads text in this draft
> literally (meaning Minimum value of Unidirectional Link Delay) it may pick
> minimum value from ULD type 33 :)
>
> If you want to be precise this draft may say minimum value of Min/Max
> Unidirectional Link Delay (34) and be done.
>
> That's all.
>
> Cheers,
> R.
>
>
>
> On Tue, Aug 18, 2020 at 6:04 PM Les Ginsberg (ginsberg) <ginsberg=
> 40cisco.com@dmarc.ietf.org> wrote:
>
>> Tony –
>>
>>
>>
>> As an author of both RFC 8570 and I-D.ietf-isis-te-app, I am not sure why
>> you are confused – nor why you got misdirected to code point 33.
>>
>>
>>
>> RFC 8570 (and its predecessor RFC 7810) define:
>>
>>
>>
>> 34           Min/Max Unidirectional Link Delay
>>
>>
>>
>> This sub-TLV contains two values:
>>
>>
>>
>> “Min Delay:  This 24-bit field carries the minimum measured link delay
>>
>>       value (in microseconds) over a configurable interval, encoded as
>>
>>       an integer value.
>>
>>
>>
>>    Max Delay:  This 24-bit field carries the maximum measured link delay
>>
>>       value (in microseconds) over a configurable interval, encoded as
>>
>>       an integer value.”
>>
>>
>>
>> It seems clear to me that the flex-draft is referring to Min
>> Unidirectional Link Delay in codepoint 34.
>>
>>
>>
>> I agree it is important to be unambiguous in specifications, but I think
>> Peter has been very clear.
>>
>> Please explain how you managed to end up at code point 33??
>>
>>
>>
>>    Les
>>
>>
>>
>>
>>
>>
>>
>> *From:* Lsr <lsr-bounces@ietf.org> *On Behalf Of * tony.li@tony.li
>> *Sent:* Tuesday, August 18, 2020 7:44 AM
>> *To:* Peter Psenak (ppsenak) <ppsenak@cisco.com>
>> *Cc:* lsr@ietf.org; lsr-ads@ietf.org; Christian Hopps <chopps@chopps.org>;
>> Acee Lindem (acee) <acee@cisco.com>;
>> draft-ietf-lsr-flex-algo.all@ietf.org
>> *Subject:* Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
>>
>>
>>
>>
>>
>> Hi Peter,
>>
>>
>>
>>
>>
>> section 5.1 of the draft-ietf-lsr-flex-algo says:
>>
>>
>> Min Unidirectional Link Delay as defined in [I-D.ietf-isis-te-app].
>>
>> We explicitly say "Min Unidirectional Link Delay", so this cannot be
>> mixed with other delay values (max, average).
>>
>>
>>
>>
>>
>> The problem is that that does not exactly match “Unidirectional Link
>> Delay” or “Min/Max Unidirectional Link Delay”, leading to the ambiguity.
>> Without a clear match, you leave things open to people guessing. Now, it’s
>> a metriic, so of course, you always want to take the min.  So type 33 seems
>> like a better match.
>>
>>
>>
>>
>>
>> section 7.3. of ietf-isis-te-app says:
>>
>> Type   Description                          Encoding
>>                                            Reference
>> ---------------------------------------------------------
>> 34      Min/Max Unidirectional Link Delay    RFC8570
>>
>>
>>
>>
>>
>> And it also says:
>>
>>
>>
>> 33      Unidirectional Link Delay            RFC8570 <https://tools.ietf.org/html/rfc8570>
>>
>>
>>
>>
>>
>> This does not help.
>>
>>
>>
>>
>>
>> So, IMHO what we have now is correct and sufficient, but I have no issue
>> adding the text you proposed below.
>>
>>
>>
>>
>>
>> What you have now is ambiguous. We have a responsibility, as writers of
>> specifications, to be precise and clear.  We are not there yet.
>>
>>
>>
>>
>>
>> BTW, before I posted 09 version of flex-algo draft, I asked if you were
>> fine with just referencing ietf-isis-te-app in 5.1. I thought you were, as
>> you did not indicate otherwise.
>>
>>
>>
>>
>>
>> My bad, I should have pressed the issue.
>>
>>
>>
>>
>>
>> Anyway, I consider this as a pure editorial issue and hopefully not
>> something that would cause you to object the WG LC of the flex-algo draft.
>>
>>
>>
>>
>>
>> I’m sorry, I think that this is trivially resolved, but important
>> clarification.
>>
>>
>>
>> You also have an author’s email that is bouncing, so at least one more
>> spin is required.
>>
>>
>>
>> Sorry,
>>
>> Tony
>>
>>
>> _______________________________________________
>> Lsr mailing list
>> Lsr@ietf.org
>> https://www.ietf.org/mailman/listinfo/lsr
>>
>
>