Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo

Robert Raszuk <robert@raszuk.net> Tue, 18 August 2020 19:20 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B9083A0A83 for <lsr@ietfa.amsl.com>; Tue, 18 Aug 2020 12:20:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oJzzI_IPJL6v for <lsr@ietfa.amsl.com>; Tue, 18 Aug 2020 12:20:41 -0700 (PDT)
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B5A7C3A0A74 for <lsr@ietf.org>; Tue, 18 Aug 2020 12:20:40 -0700 (PDT)
Received: by mail-ed1-x530.google.com with SMTP id i6so16149820edy.5 for <lsr@ietf.org>; Tue, 18 Aug 2020 12:20:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FO0O6GX5OppsuvgUy/teNn6doOWHBtz7Kh+rZhtXh4o=; b=b6uls/tV9zegmpXQIeSb4BW63xGqwkgpFaVHe6AEH02MQ8X2o2eHJQlytTHyTB0wt5 9LGTHu76ddhDIg1RS8/+JpvCaEVSPGzGODCqDyjmDso8UX+8Lhp/599qjbybdIspDCas 9u1O0HIZWJSDloKPRaTZWykUPjBkwneIDyEd3OfgvHepcL0j8QjlByrCMFDjMLd0/bT5 /SjkPUz+P4MVPvR1t7eS16KDAps8KxSgJEb7Ynidp5XAKV/LjGFG0dMhFw3pnAiiraXZ KPBshjbwJj4JkmFu2dxlmJUIhmTjirGbni7Hyh0Ov/nkkZW8GHaxgG8HKa10Xr/ZafMe wLDQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FO0O6GX5OppsuvgUy/teNn6doOWHBtz7Kh+rZhtXh4o=; b=RAoM8XeJVydWqy6GpFnGkq/7rShsb5aVpp4PGOrI5vLuAgoZ8mAXKJe5W6atr01Q92 7MQd4G1EUVERJAS2wfooCyQHrH7swSQxZCBuGcnzxxnVtw+lmr79BbXFCNNvKx2ed44h IkjWMEuCvURMsnTvhep8Wy9Guqem82yA8ccQ78qomaroOsOGg5vq0rJ72ZHeQJFB+AJI 8OSbjppKSWyunHFHpOsfIjEotQRBAU8YT6UiIvcXYnWY1IxQT0QvbP7ur1CJ2eLaJ6s8 Wc5THm/mDFaVw0jIaY1nDofBdMI9uk8JX9QIkWX8Q0y5ARKlWOdpcG2e1K+AfuLGIbjl Ll8w==
X-Gm-Message-State: AOAM532ZArLBYoVzd3+FwVlluHQ297iDDtJwMruhVYY+2R/ovIKOSUrV olwGy/dhxAhmvUd0TdKChWAOZbyDbw5rmJkz+FckRQ==
X-Google-Smtp-Source: ABdhPJxQ/18kGAK77LRCQrbvSq6nFEAzrxZCeaZdhH9KMllLCydDG2a3V4hmjVe0HAvupJOAjuLmkqEhithSoy+TRhg=
X-Received: by 2002:aa7:c70b:: with SMTP id i11mr20923297edq.272.1597778439078; Tue, 18 Aug 2020 12:20:39 -0700 (PDT)
MIME-Version: 1.0
References: <9094873B-3A03-4F48-B438-55AB0CA75396@chopps.org> <E9DF9CDA-D031-4995-BB69-7A9CEE312707@tony.li> <dff9ca08-8950-ef1c-5926-39944e94c98b@cisco.com> <E6A4AB1E-6A37-4424-8E27-2F0BFE7E3313@tony.li> <BY5PR11MB4337D97F838FFD8B250BACB1C15C0@BY5PR11MB4337.namprd11.prod.outlook.com> <CAOj+MMG9_yBK7-qWLA6Xfsq-4u4hpXz4x5FSdLA0arBw9cdc+g@mail.gmail.com> <7D686875-46CA-4E3C-8F1A-3A02DB162499@tony.li> <BY5PR11MB4337563B637688679BC847A1C15C0@BY5PR11MB4337.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB4337563B637688679BC847A1C15C0@BY5PR11MB4337.namprd11.prod.outlook.com>
From: Robert Raszuk <robert@raszuk.net>
Date: Tue, 18 Aug 2020 21:20:29 +0200
Message-ID: <CAOj+MMHp6J0bV1gsfJ3+83Ymosqc_7pAq0=WDQYsHxPy0GDU0w@mail.gmail.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
Cc: "tony.li@tony.li" <tony.li@tony.li>, Christian Hopps <chopps@chopps.org>, "draft-ietf-lsr-flex-algo.all@ietf.org" <draft-ietf-lsr-flex-algo.all@ietf.org>, "Les Ginsberg (ginsberg)" <ginsberg=40cisco.com@dmarc.ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "lsr-ads@ietf.org" <lsr-ads@ietf.org>, "Acee Lindem (acee)" <acee@cisco.com>, "Peter Psenak (ppsenak)" <ppsenak@cisco.com>
Content-Type: multipart/alternative; boundary="0000000000004aa55d05ad2bc8d8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/czAv2RpmTJHwUYbPmU8oJCePgzc>
Subject: Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 19:20:43 -0000

Les,

> and conclude that this is really “Unidirectional Link Delay” is a leap
that I cannot follow.

I would never suggest to do that.

My suggestion was to rename "Min Unidirectional Link Delay" to "minimum
value of Min/Max Unidirectional Link Delay" and move on.

Cheers,
R.



On Tue, Aug 18, 2020 at 9:18 PM Les Ginsberg (ginsberg) <ginsberg@cisco.com>
wrote:

> Tony/Robert –
>
>
>
> Whatever clarification Peter may choose to make would be fine – but I do
> question your casual ignoring of adjectives. 😊
>
>
>
> There are three values being advertised:
>
>
>
> 33 - Unidirectional Link Delay
>
> 34 – Min/Max Unidirectional Link Delay
>
>          Meaning two values are advertised in this codepoint:
>
>          Min Unidirectional Link Delay
>
>          Max Unidirectional Link Delay
>
>
>
> Now, the flex algo draft states: Min Unidirectional Link Delay
>
>
>
> If you want to argue that “Min Unidirectional Link Delay” != “Min/Max
> Unidirectional Link Delay” – I think you are pedantically correct.
>
>
>
> But how that leads you to simply truncate “Min” and conclude that this is
> really “Unidirectional Link Delay” is a leap that I cannot follow.
>
>
>
> Perhaps you don’t really like the fact that RFC 8570 encoding combined
> Min/Max in a single codepoint – but that ship sailed years ago.
>
>
>
> Given that RFC 8570 is very clear in showing that the encoding includes:
>
>
>
> <snip>
>
>    0                   1                   2                   3
>
>      0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
>
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>     |   Type        |     Length    |
>
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>     |A| RESERVED    |                   Min Delay                   |
>
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
>     |   RESERVED    |                   Max Delay                   |
>
>     +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>
> <end snip>
>
>
>
> my ability to see your POV is somewhat limited.
>
>
>
> Perhaps you could own that a more careful reading is possible?
>
>
>
>    Les
>
>
>
>
>
> *From:* Lsr <lsr-bounces@ietf.org> *On Behalf Of * tony.li@tony.li
> *Sent:* Tuesday, August 18, 2020 10:03 AM
> *To:* Robert Raszuk <robert@raszuk.net>
> *Cc:* Christian Hopps <chopps@chopps.org>;
> draft-ietf-lsr-flex-algo.all@ietf.org; Les Ginsberg (ginsberg) <ginsberg=
> 40cisco.com@dmarc.ietf.org>; lsr@ietf.org; lsr-ads@ietf.org; Acee Lindem
> (acee) <acee@cisco.com>; Peter Psenak (ppsenak) <ppsenak@cisco.com>
> *Subject:* Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
>
>
>
>
>
> Robert,
>
>
>
> Thank you, exactly.
>
>
>
> We just need a clarification of the document.  I don’t understand why this
> is such a big deal.
>
>
>
> Tony
>
>
>
>
>
> On Aug 18, 2020, at 9:22 AM, Robert Raszuk <robert@raszuk.net> wrote:
>
>
>
> Les,
>
>
>
> I think this is not very obvious as Tony is pointing out.
>
>
>
> See RFC 8570 says:
>
>
>
>       Type    Description
>
>       ----------------------------------------------------
>
>        33     Unidirectional Link Delay
>
>
>
>        34     Min/Max Unidirectional Link Delay
>
>
>
> That means that is someone implementing it reads text in this draft
> literally (meaning Minimum value of Unidirectional Link Delay) it may pick
> minimum value from ULD type 33 :)
>
>
>
> If you want to be precise this draft may say minimum value of Min/Max
> Unidirectional Link Delay (34) and be done.
>
>
>
> That's all.
>
>
>
> Cheers,
> R.
>
>
>
>
>
>
>
> On Tue, Aug 18, 2020 at 6:04 PM Les Ginsberg (ginsberg) <ginsberg=
> 40cisco.com@dmarc.ietf.org> wrote:
>
> Tony –
>
>
>
> As an author of both RFC 8570 and I-D.ietf-isis-te-app, I am not sure why
> you are confused – nor why you got misdirected to code point 33.
>
>
>
> RFC 8570 (and its predecessor RFC 7810) define:
>
>
>
> 34           Min/Max Unidirectional Link Delay
>
>
>
> This sub-TLV contains two values:
>
>
>
> “Min Delay:  This 24-bit field carries the minimum measured link delay
>
>       value (in microseconds) over a configurable interval, encoded as
>
>       an integer value.
>
>
>
>    Max Delay:  This 24-bit field carries the maximum measured link delay
>
>       value (in microseconds) over a configurable interval, encoded as
>
>       an integer value.”
>
>
>
> It seems clear to me that the flex-draft is referring to Min
> Unidirectional Link Delay in codepoint 34.
>
>
>
> I agree it is important to be unambiguous in specifications, but I think
> Peter has been very clear.
>
> Please explain how you managed to end up at code point 33??
>
>
>
>    Les
>
>
>
>
>
>
>
> *From:* Lsr <lsr-bounces@ietf.org> *On Behalf Of *tony.li@tony.li
> *Sent:* Tuesday, August 18, 2020 7:44 AM
> *To:* Peter Psenak (ppsenak) <ppsenak@cisco.com>
> *Cc:* lsr@ietf.org; lsr-ads@ietf.org; Christian Hopps <chopps@chopps.org>;
> Acee Lindem (acee) <acee@cisco.com>; draft-ietf-lsr-flex-algo.all@ietf.org
> *Subject:* Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
>
>
>
>
>
> Hi Peter,
>
>
>
>
>
> section 5.1 of the draft-ietf-lsr-flex-algo says:
>
>
> Min Unidirectional Link Delay as defined in [I-D.ietf-isis-te-app].
>
> We explicitly say "Min Unidirectional Link Delay", so this cannot be mixed
> with other delay values (max, average).
>
>
>
>
>
> The problem is that that does not exactly match “Unidirectional Link
> Delay” or “Min/Max Unidirectional Link Delay”, leading to the ambiguity.
> Without a clear match, you leave things open to people guessing. Now, it’s
> a metriic, so of course, you always want to take the min.  So type 33 seems
> like a better match.
>
>
>
>
>
> section 7.3. of ietf-isis-te-app says:
>
> Type   Description                          Encoding
>                                            Reference
> ---------------------------------------------------------
> 34      Min/Max Unidirectional Link Delay    RFC8570
>
>
>
>
>
> And it also says:
>
>
>
> 33      Unidirectional Link Delay            RFC8570 <https://tools.ietf.org/html/rfc8570>
>
>
>
>
>
> This does not help.
>
>
>
>
>
> So, IMHO what we have now is correct and sufficient, but I have no issue
> adding the text you proposed below.
>
>
>
>
>
> What you have now is ambiguous. We have a responsibility, as writers of
> specifications, to be precise and clear.  We are not there yet.
>
>
>
>
>
> BTW, before I posted 09 version of flex-algo draft, I asked if you were
> fine with just referencing ietf-isis-te-app in 5.1. I thought you were, as
> you did not indicate otherwise.
>
>
>
>
>
> My bad, I should have pressed the issue.
>
>
>
>
>
> Anyway, I consider this as a pure editorial issue and hopefully not
> something that would cause you to object the WG LC of the flex-algo draft.
>
>
>
>
>
> I’m sorry, I think that this is trivially resolved, but important
> clarification.
>
>
>
> You also have an author’s email that is bouncing, so at least one more
> spin is required.
>
>
>
> Sorry,
>
> Tony
>
>
>
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org
> https://www.ietf.org/mailman/listinfo/lsr
>
>
>