Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo

Peter Psenak <ppsenak@cisco.com> Thu, 20 August 2020 15:18 UTC

Return-Path: <ppsenak@cisco.com>
X-Original-To: lsr@ietfa.amsl.com
Delivered-To: lsr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DEC723A0BFA; Thu, 20 Aug 2020 08:18:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.55
X-Spam-Level:
X-Spam-Status: No, score=-10.55 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.949, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cSmXw1ONBq9C; Thu, 20 Aug 2020 08:18:03 -0700 (PDT)
Received: from aer-iport-3.cisco.com (aer-iport-3.cisco.com [173.38.203.53]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F2EA53A0BF2; Thu, 20 Aug 2020 08:17:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=15964; q=dns/txt; s=iport; t=1597936680; x=1599146280; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jqP+ZBEWvo59Q7sEKYejO5h84FD4fb3U6sWRUUAX7aU=; b=S84ezj8vXPMPPfhSu+AcbNvnyKBvedYhf3d/LPeONnuYxVsTaecNSyLi yPND5UkH1IMshmT7kigOui9Vi5q4v6ZB+aKrlUsb/Z1sdcuk0OgT550og Gsfaut6EGu4VCkgHFBAINa1ePX7LNXGy/wcSpMnus2hhEm9HGLkWqgt1+ Y=;
X-IronPort-AV: E=Sophos;i="5.76,333,1592870400"; d="scan'208";a="26477890"
Received: from aer-iport-nat.cisco.com (HELO aer-core-3.cisco.com) ([173.38.203.22]) by aer-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 20 Aug 2020 15:17:58 +0000
Received: from [10.60.140.51] (ams-ppsenak-nitro2.cisco.com [10.60.140.51]) by aer-core-3.cisco.com (8.15.2/8.15.2) with ESMTP id 07KFHuVc027314; Thu, 20 Aug 2020 15:17:56 GMT
To: olivier.dugeon@orange.com, tony.li@tony.li, Robert Raszuk <robert@raszuk.net>
Cc: Christian Hopps <chopps@chopps.org>, "draft-ietf-lsr-flex-algo.all@ietf.org" <draft-ietf-lsr-flex-algo.all@ietf.org>, "Les Ginsberg (ginsberg)" <ginsberg=40cisco.com@dmarc.ietf.org>, "lsr@ietf.org" <lsr@ietf.org>, "lsr-ads@ietf.org" <lsr-ads@ietf.org>, "Acee Lindem (acee)" <acee@cisco.com>
References: <9094873B-3A03-4F48-B438-55AB0CA75396@chopps.org> <E9DF9CDA-D031-4995-BB69-7A9CEE312707@tony.li> <dff9ca08-8950-ef1c-5926-39944e94c98b@cisco.com> <E6A4AB1E-6A37-4424-8E27-2F0BFE7E3313@tony.li> <BY5PR11MB4337D97F838FFD8B250BACB1C15C0@BY5PR11MB4337.namprd11.prod.outlook.com> <CAOj+MMG9_yBK7-qWLA6Xfsq-4u4hpXz4x5FSdLA0arBw9cdc+g@mail.gmail.com> <7D686875-46CA-4E3C-8F1A-3A02DB162499@tony.li> <30234_1597837344_5F3D1020_30234_107_1_595a0b47-eb26-8935-fe4f-429ccc725592@orange.com> <4d0b84a7-08b3-e2c6-f918-8009be2d6523@cisco.com> <2595_1597924729_5F3E6579_2595_13_1_7c66f628-46fc-c749-aa45-cb22f6e9e996@orange.com> <1fb53fad-b5ae-4d2f-3fde-180b62bc9645@cisco.com> <9988_1597933548_5F3E87EC_9988_13_3_15236ac6-520b-919b-ecec-c6c58b48b73d@orange.com>
From: Peter Psenak <ppsenak@cisco.com>
Message-ID: <6f5a9900-860a-7328-725f-124e19e92b4e@cisco.com>
Date: Thu, 20 Aug 2020 17:17:56 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <9988_1597933548_5F3E87EC_9988_13_3_15236ac6-520b-919b-ecec-c6c58b48b73d@orange.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Outbound-SMTP-Client: 10.60.140.51, ams-ppsenak-nitro2.cisco.com
X-Outbound-Node: aer-core-3.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/lsr/bY8HdoUyZk5OhVWcxNKZLKgwxIg>
Subject: Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
X-BeenThere: lsr@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Link State Routing Working Group <lsr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/lsr>, <mailto:lsr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/lsr/>
List-Post: <mailto:lsr@ietf.org>
List-Help: <mailto:lsr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/lsr>, <mailto:lsr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 15:18:07 -0000

Olivier,

On 20/08/2020 16:25, olivier.dugeon@orange.com wrote:
> Peter,
> 
> Le 20/08/2020 à 14:12, Peter Psenak a écrit :
>> Hi Olivier,
>>
>> On 20/08/2020 13:58, olivier.dugeon@orange.com wrote:
>>> Hi Peter,
>>>
>>> Thank for the new version.
>>>
>>> Le 19/08/2020 à 14:00, Peter Psenak a écrit :
>>>> Olivier, 
>>> [ ... ]
>>>>> So, to speed up the deployment, I would prefer a reference to a 
>>>>> delay value that could be advertise by means of RFC7471, RFC8570 
>>>>> and/or TE-App draft. It is then up to the operator to ensure the 
>>>>> coherency of what it is announced in its network by the different 
>>>>> routers.
>>>>
>>>> I know you don't like the app specific link advertisement, but I'm 
>>>> afraid what you ask for is absolutely wrong.
>>>>
>>>> We defined the ASLA encoding to address a real problems for 
>>>> advertising the link attributes. We allow the link attributes to be 
>>>> advertised in both legacy and ASLA advertisement for legacy 
>>>> application (RSVP-TE, SRTE) to address the backward compatibility. 
>>>> Flex-algo is a new application, there is absolutely no need to use 
>>>> the legacy advertisement. Doing so would just extend the problem to 
>>>> the flex-algo application.
>>>
>>> Regarding the new version you provided, new section 5.1 (for IS-IS) 
>>> and section 5.2 (for OSPF) mention respectively RFC 8570 and RFC 7471 
>>> for the definition of Min delay and TE metric which is fine for me. 
>>> But, they also made reference to draft isis-te-app, respectively 
>>> ospf-te-link-attr-reuse to encode these value. 
>>
>> that's what people were asking for. And it is right because we are 
>> mandating the usage of ALSA encoding for any flex-algo related link 
>> attributes.
>>
>>> Here, it is confusing. 
>>
>> I don't see how much more clear we can make it.
>>
>>> Indeed, RFC 8570 and RFC 7471 also define the way to encode TE metric 
>>> and Min delay.
>>
>> you have to distinguish between two things:
>>
>> a)  where Min delay and TE metric were defined - RFC 8570 and RFC 7471
>> b)  how we encode it for flex-algo - isis-te-app,
>> ospf-te-link-attr-reuse
>>
>>>
>>> What I'm suggesting, is a clear reference to the RFC for TE metric 
>>> and Min delay definition as well as the encoding (especially for the 
>>> delay) while leaving open the door to how the router acquire these 
>>> values: legacy a.k.a. RFC 8570 & 7471 or new draft a.k.a 
>>> draft-isis-te-app & draft-ospf-link-attr-reuse.
>>
>> no. This will not be done. We only allow ASLA advertisement for these 
>> metrics and other link attributes that are used for flex-algo. It is 
>> done for a reason and I have already explained that.
>>
> OK. Reading section 11 which clarify how metrics are convey, let me 
> suggest to make a reference to section 11 in section 5.1 and 5.2 instead 
> of reference to drafts.

what is the problem with using the reference to isis-te-app,
ospf-te-link-attr-reuse in 5.1 and 5.2?


>>>
>>> In fact, in section 17.1.2, you mention only reference to RFC 8570 & 
>>> RFC7471 for the IANA definition which is fine for me. 
>>
>> because in registry, we are defining a metric type, not how we are 
>> going to advertise it for the link.
>>
>>
> OK.
>>
>>> I would suggest the same wording for section 5.1. and 5.2 leaving 
>>> operator free about how it collect the values from the neighbour 
>>> routers: legacy or new method.
>>
>> please stop trying to make use of legacy RSVP-TE link advertisements 
>> for flex-algo - it will not be allowed.
> 
> This raise to me a simple question: Is it possible to use 2 different 
> Flex Algo with delay metric, one for App A and another one for App B ? 

sure

> if yes, how can we link metrics advertise in ALSA A from metrics 
> advertise in ALSA B ? The draft mention only one bit for Flex-Algo.

there is only single ASLA flex-algo delay metric advertisement per link, 
similar to only single RSVP-TE delay metric per link.


Advertisement is done per application type, flex-algo being one of them, 
not per each instance of the application (e.g. flex-algo number).


> 
> Regards,
> 
> Olivier
> 
> PS. I note a duplicate paragraph in section 12: "When computing the path 
> for a given Flex-Algorithm, the metric-type that is part of the 
> Flex-Algorithm definition (Section 5) MUST be used."

I don't see it. I see one talking about metric, the other one about the 
calculation type.

thanks,
Peter

> 
>>
>> thanks,
>> Peter
>>
>>>
>>> Regards
>>>
>>> Olivier
>>>
>>> PS. We have a pre-alpha implementation of flex algo using the legacy 
>>> metrics and I know that recent IOS-XR provided similar implementation 
>>> of flex algo based on legacy metrics.
>>>
>>>>
>>>> regards,
>>>> Peter
>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Olivier
>>>>>
>>>>> Le 18/08/2020 à 19:02, tony.li@tony.li a écrit :
>>>>>>
>>>>>> Robert,
>>>>>>
>>>>>> Thank you, exactly.
>>>>>>
>>>>>> We just need a clarification of the document.  I don’t understand 
>>>>>> why this is such a big deal.
>>>>>>
>>>>>> Tony
>>>>>>
>>>>>>
>>>>>>> On Aug 18, 2020, at 9:22 AM, Robert Raszuk <robert@raszuk.net 
>>>>>>> <mailto:robert@raszuk.net>> wrote:
>>>>>>>
>>>>>>> Les,
>>>>>>>
>>>>>>> I think this is not very obvious as Tony is pointing out.
>>>>>>>
>>>>>>> See RFC 8570 says:
>>>>>>>
>>>>>>>        Type    Description
>>>>>>>        ----------------------------------------------------
>>>>>>>         33     Unidirectional Link Delay
>>>>>>>
>>>>>>>         34     Min/Max Unidirectional Link Delay
>>>>>>>
>>>>>>> That means that is someone implementing it reads text in this 
>>>>>>> draft literally (meaning Minimum value of Unidirectional Link 
>>>>>>> Delay) it may pick minimum value from ULD type 33 :)
>>>>>>>
>>>>>>> If you want to be precise this draft may say minimum value of 
>>>>>>> Min/Max Unidirectional Link Delay (34) and be done.
>>>>>>>
>>>>>>> That's all.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> R.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Aug 18, 2020 at 6:04 PM Les Ginsberg (ginsberg) 
>>>>>>> <ginsberg=40cisco.com@dmarc.ietf.org 
>>>>>>> <mailto:40cisco.com@dmarc.ietf.org>> wrote:
>>>>>>>
>>>>>>>     Tony –
>>>>>>>
>>>>>>>     As an author of both RFC 8570 and I-D.ietf-isis-te-app, I am not
>>>>>>>     sure why you are confused – nor why you got misdirected to code
>>>>>>>     point 33.
>>>>>>>
>>>>>>>     RFC 8570 (and its predecessor RFC 7810) define:
>>>>>>>
>>>>>>>     34           Min/Max Unidirectional Link Delay
>>>>>>>
>>>>>>>     This sub-TLV contains two values:
>>>>>>>
>>>>>>>     “Min Delay:  This 24-bit field carries the minimum measured link
>>>>>>>     delay
>>>>>>>
>>>>>>>           value (in microseconds) over a configurable interval,
>>>>>>>     encoded as
>>>>>>>
>>>>>>>           an integer value.
>>>>>>>
>>>>>>>        Max Delay:  This 24-bit field carries the maximum measured
>>>>>>>     link delay
>>>>>>>
>>>>>>>           value (in microseconds) over a configurable interval,
>>>>>>>     encoded as
>>>>>>>
>>>>>>>           an integer value.”
>>>>>>>
>>>>>>>     It seems clear to me that the flex-draft is referring to Min
>>>>>>>     Unidirectional Link Delay in codepoint 34.
>>>>>>>
>>>>>>>     I agree it is important to be unambiguous in specifications, but
>>>>>>>     I think Peter has been very clear.
>>>>>>>
>>>>>>>     Please explain how you managed to end up at code point 33??
>>>>>>>
>>>>>>>        Les
>>>>>>>
>>>>>>>     *From:* Lsr <lsr-bounces@ietf.org <mailto:lsr-bounces@ietf.org>>
>>>>>>>     *On Behalf Of *tony.li@tony.li <mailto:tony.li@tony.li>
>>>>>>>     *Sent:* Tuesday, August 18, 2020 7:44 AM
>>>>>>>     *To:* Peter Psenak (ppsenak) <ppsenak@cisco.com
>>>>>>> <mailto:ppsenak@cisco.com>>
>>>>>>>     *Cc:* lsr@ietf.org <mailto:lsr@ietf.org>; lsr-ads@ietf.org
>>>>>>> <mailto:lsr-ads@ietf.org>; Christian Hopps <chopps@chopps.org
>>>>>>> <mailto:chopps@chopps.org>>; Acee Lindem (acee) <acee@cisco.com
>>>>>>> <mailto:acee@cisco.com>>; draft-ietf-lsr-flex-algo.all@ietf.org
>>>>>>> <mailto:draft-ietf-lsr-flex-algo.all@ietf.org>
>>>>>>>     *Subject:* Re: [Lsr] WG Last Call for draft-ietf-lsr-flex-algo
>>>>>>>
>>>>>>>     Hi Peter,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         section 5.1 of the draft-ietf-lsr-flex-algo says:
>>>>>>>
>>>>>>>
>>>>>>>         Min Unidirectional Link Delay as defined in
>>>>>>>         [I-D.ietf-isis-te-app].
>>>>>>>
>>>>>>>         We explicitly say "Min Unidirectional Link Delay", so this
>>>>>>>         cannot be mixed with other delay values (max, average).
>>>>>>>
>>>>>>>     The problem is that that does not exactly match “Unidirectional
>>>>>>>     Link Delay” or “Min/Max Unidirectional Link Delay”, leading to
>>>>>>>     the ambiguity. Without a clear match, you leave things open to
>>>>>>>     people guessing. Now, it’s a metriic, so of course, you always
>>>>>>>     want to take the min.  So type 33 seems like a better match.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         section 7.3. of ietf-isis-te-app says:
>>>>>>>
>>>>>>>         Type   Description                          Encoding
>>>>>>>                                                    Reference
>>>>>>>         ---------------------------------------------------------
>>>>>>>         34      Min/Max Unidirectional Link Delay    RFC8570
>>>>>>>
>>>>>>>     And it also says:
>>>>>>>
>>>>>>>     33      Unidirectional Link Delay RFC8570
>>>>>>> <https://tools.ietf.org/html/rfc8570>
>>>>>>>
>>>>>>>     This does not help.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         So, IMHO what we have now is correct and sufficient, but I
>>>>>>>         have no issue adding the text you proposed below.
>>>>>>>
>>>>>>>     What you have now is ambiguous. We have a responsibility, as
>>>>>>>     writers of specifications, to be precise and clear.  We are not
>>>>>>>     there yet.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         BTW, before I posted 09 version of flex-algo draft, I asked
>>>>>>>         if you were fine with just referencing ietf-isis-te-app in
>>>>>>>         5.1. I thought you were, as you did not indicate otherwise.
>>>>>>>
>>>>>>>     My bad, I should have pressed the issue.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         Anyway, I consider this as a pure editorial issue and
>>>>>>>         hopefully not something that would cause you to object 
>>>>>>> the WG
>>>>>>>         LC of the flex-algo draft.
>>>>>>>
>>>>>>>     I’m sorry, I think that this is trivially resolved, but 
>>>>>>> important
>>>>>>>     clarification.
>>>>>>>
>>>>>>>     You also have an author’s email that is bouncing, so at least 
>>>>>>> one
>>>>>>>     more spin is required.
>>>>>>>
>>>>>>>     Sorry,
>>>>>>>
>>>>>>>     Tony
>>>>>>>
>>>>>>>     _______________________________________________
>>>>>>>     Lsr mailing list
>>>>>>> Lsr@ietf.org <mailto:Lsr@ietf.org>
>>>>>>> https://www.ietf.org/mailman/listinfo/lsr
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Lsr mailing list
>>>>>> Lsr@ietf.org
>>>>>> https://www.ietf.org/mailman/listinfo/lsr
>>>>> -- 
>>>>> Orange logo <http://www.orange.com>
>>>>>
>>>>> Olivier Dugeon
>>>>> Orange Expert, Future Networks
>>>>> Open Source Referent
>>>>> Orange/IMT/OLN/WTC/IEE/iTeQ
>>>>>
>>>>> fixe : +33 2 96 07 28 80
>>>>> mobile : +33 6 82 90 37 85
>>>>> olivier.dugeon@orange.com <mailto:olivier.dugeon@orange.com>
>>>>>
>>>>> _________________________________________________________________________________________________________________________ 
>>>>>
>>>>>
>>>>> Ce message et ses pieces jointes peuvent contenir des informations 
>>>>> confidentielles ou privilegiees et ne doivent donc
>>>>> pas etre diffuses, exploites ou copies sans autorisation. Si vous 
>>>>> avez recu ce message par erreur, veuillez le signaler
>>>>> a l'expediteur et le detruire ainsi que les pieces jointes. Les 
>>>>> messages electroniques etant susceptibles d'alteration,
>>>>> Orange decline toute responsabilite si ce message a ete altere, 
>>>>> deforme ou falsifie. Merci.
>>>>>
>>>>> This message and its attachments may contain confidential or 
>>>>> privileged information that may be protected by law;
>>>>> they should not be distributed, used or copied without authorisation.
>>>>> If you have received this email in error, please notify the sender 
>>>>> and delete this message and its attachments.
>>>>> As emails may be altered, Orange is not liable for messages that 
>>>>> have been modified, changed or falsified.
>>>>> Thank you.
>>>>>
>>>>
>>>>
>>> -- 
>>> Orange logo <http://www.orange.com>
>>>
>>> Olivier Dugeon
>>> Orange Expert, Future Networks
>>> Open Source Referent
>>> Orange/IMT/OLN/WTC/IEE/iTeQ
>>>
>>> fixe : +33 2 96 07 28 80
>>> mobile : +33 6 82 90 37 85
>>> olivier.dugeon@orange.com <mailto:olivier.dugeon@orange.com>
>>>
>>> _________________________________________________________________________________________________________________________ 
>>>
>>>
>>> Ce message et ses pieces jointes peuvent contenir des informations 
>>> confidentielles ou privilegiees et ne doivent donc
>>> pas etre diffuses, exploites ou copies sans autorisation. Si vous 
>>> avez recu ce message par erreur, veuillez le signaler
>>> a l'expediteur et le detruire ainsi que les pieces jointes. Les 
>>> messages electroniques etant susceptibles d'alteration,
>>> Orange decline toute responsabilite si ce message a ete altere, 
>>> deforme ou falsifie. Merci.
>>>
>>> This message and its attachments may contain confidential or 
>>> privileged information that may be protected by law;
>>> they should not be distributed, used or copied without authorisation.
>>> If you have received this email in error, please notify the sender 
>>> and delete this message and its attachments.
>>> As emails may be altered, Orange is not liable for messages that have 
>>> been modified, changed or falsified.
>>> Thank you.
>>>
>>
>>
> -- 
> Orange logo <http://www.orange.com>
> 
> Olivier Dugeon
> Orange Expert, Future Networks
> Open Source Referent
> Orange/IMT/OLN/WTC/IEE/iTeQ
> 
> fixe : +33 2 96 07 28 80
> mobile : +33 6 82 90 37 85
> olivier.dugeon@orange.com <mailto:olivier.dugeon@orange.com>
> 
> _________________________________________________________________________________________________________________________
> 
> Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
> pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
> a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
> Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
> 
> This message and its attachments may contain confidential or privileged information that may be protected by law;
> they should not be distributed, used or copied without authorisation.
> If you have received this email in error, please notify the sender and delete this message and its attachments.
> As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
> Thank you.
>