Re: [mpls] MPLS-RT review of draft-pdutta-mpls-tldp-hello-reduce-03

Dear authors,

I've couple of comments:

1) I also have a concern along the same lines as stated by Lizhong:

>> Target Hello tracks the liveness of hello adjacency, while LDP keepalive tracks the liveness of session. Do you mean it is not necessary to track the liveness of hello adjacency, >> or substitute it with liveness tracking of session?

The reduction of T-LDP hellos may cause issues for targeted-adjacencies related to forwarding interfaces [ e.g. LDP over TE tunnel ]. LDP requires an adjacency to be **live** on an interface before MPLS [labeled] forwarding can be setup on the given forwarding interface. If we are using LDP-enabled TE tunnel as forwarding interface, then typically we install unlabeled (LDP) forwarding over TE tunnel interface if LDP's t-adj over TE tunnel goes down. With T-LDP reduction, we lose the ability to track the liveness of the t-adj and will be incorrectly using [labeled] LDP LSP over TE tunnel in the forwarding even when there are issues with this t-adj.

2) Re: "DoS attacks" as motivation for the tldp-reduc:
Your document states that:

"Unlike TCP sessions it is not always possible to

   provide per peer protection for UDP based hellos."

Given new procedures/draft on LDP hello auth (i.e. draft-zheng-mpls-ldp-hello-crypto-auth),
the above does not seem valid anymore, and hence is not a strong argument to support tldp-reduc, IMO.

Rgds,

-- Kamran

From: Lizhong Jin <lizhong.jin@zte.com.cn<mailto:lizhong.jin@zte.com.cn>>
Date: Mon, 23 Jul 2012 17:12:36 +0800
To: "Dutta, Pranjal K (Pranjal)" <pranjal.dutta@alcatel-lucent.com<mailto:pranjal.dutta@alcatel-lucent.com>>, <mpls@ietf.org<mailto:mpls@ietf.org>>, Thomas Nadeau <tnadeau@juniper.net<mailto:tnadeau@juniper.net>>, Giles Heron <giheron@cisco.com<mailto:giheron@cisco.com>>
Cc: Ross Callon <rcallon@juniper.net<mailto:rcallon@juniper.net>>
Subject: Re: [mpls] MPLS-RT review of draft-pdutta-mpls-tldp-hello-reduce-03

Hi all,
I've reviewed this draft, and have two comments that need to be clarifed:
1. Target Hello tracks the liveness of hello adjacency, while LDP keepalive tracks the liveness of session. Do you mean it is not necessary to track the liveness of hello adjacency, or substitute it with liveness tracking of session? Hello address maybe different with trasport address.
2. Target hellos are not only used for liveness track, but also parameter negotiation and updating. When negotiated to infinite, what time interval would be used to send the updated hello (e.g, hello with new Optional Parameters in potential draft-pdutta-mpls-ldp-adj-capability) message? UDP hello is not reliable, would be renegotiated to configured hello hold time first?

Summary of review:
a. whether the document is coherent?
Good description on the motivation, need more detail in technical description (e.g, refer to my second comment).

b. is it useful?
Yes.

d. is technically sound ?
Need some clarification.

e. is ready to be considered for WG adoption ?
After clarification, it should be ready for WG adoption.

Regards
Lizhong

Ross Callon <rcallon@juniper.net<mailto:rcallon@juniper.net>> wrote 2012/07/18 05:49:55:

> Markus, Lizhong, Thomas;
>
> You have been selected as an MPLS Review team reviewers for
> draft-pdutta-mpls-tldp-hello-reduce-03
>
> Note to authors: You have been CC’d on this email so that you can know that
> this review is going on. However, please do not review your own document.
>
> Reviews should comment on whether the document is coherent, is it useful
> (ie, is it likely to be actually useful in operational networks), and is
> the document technically sound?  We are interested in knowing whether the
> document is ready to be considered for WG adoption (ie, it doesn’t have to
> be perfect at this point, but should be a good start).
>
> Reviews should be sent to the document authors, WG co-chairs and secretary,
> and CC’d to the MPLS WG email list. If necessary, comments may be sent
> privately to only the WG chairs.
>
> Are you able to review this draft by August 3, 2012 (ie, the end of the IETF
> meeting in Vancouver)? We understand that this is somewhat short notice and
> that you might have something else to do the week of the IETF, so let us
> know if you need slightly more time.
>
> Thanks, Ross
> (as MPLS WG chair)
>
> PS: I noticed that Tom Nadeau’s email address listed in the draft is
> out of date. This email is being CC’d to his updated address.
>   _______________________________________________ mpls mailing list mpls@ietf.org<mailto:mpls@ietf.org> https://www.ietf.org/mailman/listinfo/mpls