[mpls] QA Review draft-akiya-mpls-lsp-ping-reply-mode-simple-03

Lou Berger <lberger@labn.net> Fri, 05 September 2014 20:21 UTC

Return-Path: <lberger@labn.net>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11A551A010D for <mpls@ietfa.amsl.com>; Fri, 5 Sep 2014 13:21:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.667
X-Spam-Level:
X-Spam-Status: No, score=-1.667 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, IP_NOT_FRIENDLY=0.334, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kGIUUbu9uxtZ for <mpls@ietfa.amsl.com>; Fri, 5 Sep 2014 13:21:30 -0700 (PDT)
Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by ietfa.amsl.com (Postfix) with SMTP id 053FC1A010A for <mpls@ietf.org>; Fri, 5 Sep 2014 13:21:29 -0700 (PDT)
Received: (qmail 5205 invoked by uid 0); 5 Sep 2014 20:21:24 -0000
Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy4.mail.unifiedlayer.com with SMTP; 5 Sep 2014 20:21:24 -0000
Received: from box313.bluehost.com ([69.89.31.113]) by cmgw4 with id neMF1o00d2SSUrH01eMJLT; Fri, 05 Sep 2014 20:21:23 -0600
X-Authority-Analysis: v=2.1 cv=KvHehwmN c=1 sm=1 tr=0 a=h1BC+oY+fLhyFmnTBx92Jg==:117 a=u9EReRu7m0cA:10 a=4kc_xtrGfg0A:10 a=HFCU6gKsb0MA:10 a=jZ44FGKI4aMA:10 a=8nJEP1OIZ-IA:10 a=wU2YTnxGAAAA:8 a=cNaOj0WVAAAA:8 a=-NfooI8aBGcA:10 a=uEJ9t1CZtbIA:10 a=GRd5rHI3PBnbKcUc_ncA:9 a=wPNLvfGTeEIA:10
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=L8IAqmEDyZCU2YtML/tEO9n1fvoi+hmEhFGesO20DJU=; b=Zo/x+VOIGjRqQdId2LjAP3xOs01rlb1QKp3dztKQBOJOJ8Xk8Nv+ScjVX5Jox754lAc785a+MaxcQulXA2jB7zjzJzYttfSKAHVHH8SQnXnc7p3yq+PdAlRslESWa8+K;
Received: from box313.bluehost.com ([69.89.31.113]:54830 helo=[127.0.0.1]) by box313.bluehost.com with esmtpa (Exim 4.82) (envelope-from <lberger@labn.net>) id 1XQ00S-0005o6-QN; Fri, 05 Sep 2014 14:21:16 -0600
Message-ID: <540A1B48.7020504@labn.net>
Date: Fri, 05 Sep 2014 16:21:28 -0400
From: Lou Berger <lberger@labn.net>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: draft-akiya-mpls-lsp-ping-reply-mode-simple@tools.ietf.org
References: <e4da58f21f34427686e7385f90354ec1@CO2PR05MB636.namprd05.prod.outlook.com>
In-Reply-To: <e4da58f21f34427686e7385f90354ec1@CO2PR05MB636.namprd05.prod.outlook.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Identified-User: {1038:box313.bluehost.com:labnmobi:labn.net} {sentby:smtp auth 69.89.31.113 authed with lberger@labn.net}
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/rNf___aOdFVHLKSvcsTh2x_nyBc
Cc: mpls@ietf.org
Subject: [mpls] QA Review draft-akiya-mpls-lsp-ping-reply-mode-simple-03
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Sep 2014 20:21:31 -0000

Hello,
    I've been asked to do a QA review of this draft. Overall it looks
like a solid,  well written document,  and more than reasonable -00 WG
document.

I have some technical nits/comments/questions that I think can be
addressed as part of normal WG process:

Section 3.1
- "Reverse LSP is in relation to the last FEC  specified in the Target
FEC Stack TLV."
I think I understand this statement for the egress, but what about at
transit nodes?  Perhaps just drop the sentence?

- Missing "in the range of" in the last sentence of the section.

Section 3.2
- The phrasing of 4 is a bit stricter than I think you mean with respect
to use of Reply Mode field.  One could read it as saying that a value
carried in the field can't be used even when it is in the Order TLV, as
well as precluding its use described in the subsequent requirement (5). 
Perhaps just rephrase to say that it is only used after any mode
included in the ordered TLV is excluded/invalid/unavailable.

-I think the document should be explicit about ordering relationship of
the reply modes listed in the Order TLV and to the order of paths
included in other TLVs, e.g., sub-TLVs/FECs in the Reply Path TLV.  (Yes
it should obvious, but it is a potential interop issue)

- Section 4.1.1
 o The Reply Path TLV carrying {FEC X, FEC Y}
Wouldn't it be cleaner, particularly when considering non-draft
supporting implementations, to use multiple Reply Path TLVs (one per
possible reply path)?

That's it,
Lou