Re: [netconf] WGLC for draft-ietf-netconf-notification-capabilities

["Joe Clarke (jclarke)" <[e-mail]>]

On Sep 30, 2019, at 05:20, Balázs Lengyel <balazs.lengyel=[e-mail]<mailto:balazs.lengyel=[e-mail]>> wrote:

Hello,
Here is a preliminary next version (not submitted yet). See also below.

I have reviewed this version and looked at others’ comments.  I think this document is ready (based on the addressing of others’ comments), and I support its goals.  This will make the consumption of telemetry much easier for operators.

Joe

Regards Balazs

From: Eric Voit (evoit) <[e-mail]<mailto:[e-mail]>>
Sent: 2019. szeptember 27., péntek 21:42
To: Balázs Lengyel <[e-mail]<mailto:[e-mail]>>; Mahesh Jethanandani <[e-mail]<mailto:[e-mail]>>; Alexander Clemm <[e-mail]<mailto:[e-mail]>>; Benoit Claise (bclaise) <[e-mail]<mailto:[e-mail]>>
Cc: Netconf <[e-mail]<mailto:[e-mail]>>
Subject: RE: [netconf] WGLC for draft-ietf-netconf-notification-capabilities

Hi Balazs,

Some more thoughts in-line.   I cut out those I think closed.

From: Balázs Lengyel <[e-mail]<mailto:[e-mail]>>
Sent: Friday, September 27, 2019 8:48 AM
To: Eric Voit (evoit) <[e-mail]<mailto:[e-mail]>>; Mahesh Jethanandani <[e-mail]<mailto:[e-mail]>>; Alexander Clemm <[e-mail]<mailto:[e-mail]>>; Benoit Claise (bclaise) <[e-mail]<mailto:[e-mail]>>
Cc: Netconf <[e-mail]<mailto:[e-mail]>>
Subject: RE: [netconf] WGLC for draft-ietf-netconf-notification-capabilities

Thanks for the comments. See answers below.
I hope the group will be ok with using the term publisher instead of server. IMHO it is clearer as the client server relationship can be reversed e.g. for https notification transport.
Balazs

From: Eric Voit (evoit) <[e-mail]<mailto:[e-mail]>>
Sent: 2019. szeptember 24., kedd 23:15
To: Mahesh Jethanandani <[e-mail]<mailto:[e-mail]>>; Balázs Lengyel <[e-mail]<mailto:[e-mail]>>; Alexander Clemm <[e-mail]<mailto:[e-mail]>>; Benoit Claise (bclaise) <[e-mail]<mailto:[e-mail]>>
Cc: Netconf <[e-mail]<mailto:[e-mail]>>
Subject: RE: [netconf] WGLC for draft-ietf-netconf-notification-capabilities

Here are some comments...

On-change Notification Capability: Is this different from support for RFC-8641 feature "on-change"?  If they are the same, it might be possible to remove the term.  Especially as this term is used inconsistently.
BALAZS: In RFC 8641 on-change is not defined as a capability. It is used for many more things (e.g. On-change subscription,  trigger condition, type of push updates, a feature.) In this draft the on change capability is just the servers capability to send on-change notification globally, for a specific datastore or a specific data node. Description will be reworded.
<Eric> It will be good to see the reword.   I still am not clear how this different from the RFC-8641 feature "on-change", along with this feature being associated with specific nodes.
BALAZS2:
On-change Notification Capability: The capability of the server to
   send on-change notifications for a specific datastore or a specific
   data node.


Section 3

Paragraph 2, bullet 2: Instead of  "amount of notifications the server can send out", do you mean "the minimum periodicity of updates which a server can send out for an object"
BALAZS: That too, but also the max-objects-per-update. I was told not to repeat information in the main text and in the YANG module, so I tried to find a wording that covers both. Also  its not always the minimum times. Some servers support  a specific set of times, not a anything over a minimum.
<Eric> Ok, so this bullet is a bucket of various types of information.  Which is fine with me.


Paragraph 2, bullets 3 & 4: I don't think these should be indented as bullets are they are more about proper behavior of a correctly populated model.
BALAZS: I don’t really understand this comment.  Please explain.
<Eric> Looking at the text, bullets 3 is written to say how capabilities value can be set (i.e., how) rather than that they can be set for different levels (i.e., what).  Getting consistency so that the bullets are all 'how' or all 'what' items would help readability.
BALAZS2: OK, I get it. You are right, to be corrected.


Paragraph 3, bullets 2: why isn't SHALL instead MUST?   Also, shouldn't this point out that both NETCONF and RESTCONF MUST be supported if on-change is advertised, and this draft is supported?
BALAZS: As I understand RFC 2119 MUST and SHALL both mean the same, but I will change to MUST. No I do not want to mandate implementing both Netconf AND Restconf. IMO a server with just Netconf would work just fine; or maybe I misunderstand your comment?
<Eric> The second part of my comment was about ensuring that IF this model was available, and the publisher supports both RFC-8640 & draft-ietf-netconf-restconf-notif, then this specification MUST be able to push changes over both NETCONF and RESTCONF.    Thinking more, this is actually a generic question which is likely already answered: how do you know which models are supported for which transports.   As advertisement is by transport, I withdraw this question.
BALAZS2: Some implementations have a yang extension statement to specify whether  a model is visible on specific interfaces

Section 4

I suspect that you will need to do a security analysis per YANG object.   This has been done the other YANG push family.
BALAZS: The full module is readOnly and not sensitive or private in any manner.  The security text for the readOnly parts of YangPush is the exact same text: not very informative, but gives you the illusion of security awareness.
<Eric> You can ignore my comment.  In doing RFC-8639, I needed to put in read/write analysis for each object.  And this did sometime include the risks of internally setting values which were read-only from the model.  Perhaps this will not be required during later draft reviews in the publication process.

I suspect that manipulating the reporting intervals could have some security implications.   E.g., a hacker could push up the damping period or periodic interval to a level where the information they are changing then becomes invisible to a monitoring system.
BALAZS: The full YAM is read-only so manipulating the data is not a concern.
<Eric> Per my previous point, if the IETF process says you don't need to highlight such possibilities, then I am good.
BALAZS2:
In rfc8639 the text says for readOnly data nodes something like:
If access control is not properly configured, can expose
      system internals to those who should not have access to this
      information.
That is true for any bit of data, so I do not understand what information does it add. It does not hurt, so I will add the same sentence to my draft.

If you have something else in mind please describe the attack method that I should mention.
</Eric>

Thanks,
Eric


From: netconf <[e-mail]<mailto:[e-mail]>> On Behalf Of Mahesh Jethanandani
Sent: Tuesday, September 24, 2019 1:50 PM
To: Netconf <[e-mail]<mailto:[e-mail]>>
Subject: Re: [netconf] WGLC for draft-ietf-netconf-notification-capabilities

We were supposed to have closed on the WGLC today. However, between the document becoming a WG item and it going into LC, we have not received too many comments on the draft. As such, we are extending the LC by another week. Please review the draft and provide any comments you might have.

Mahesh & Kent (as co-chairs)


On Sep 10, 2019, at 3:39 PM, Mahesh Jethanandani <[e-mail]<mailto:[e-mail]>> wrote:

Authors have published -04<https://tools.ietf.org/html/draft-ietf-netconf-notification-capabilities-04> version of the draft, which addresses comments they received in IETF 105. If you provided comments please check to make sure your comments have been addressed. At this point, the authors believe that the document is ready for WGLC.

This therefore starts a two week LC, ending on September 24th. Please provide any technical comments you might have on the document. If you believe the document is not ready for LC, please state your reasons.

We will issue a IPR poll separately.

Mahesh & Kent (as co-chairs)




<draft-ietf-netconf-notification-capabilities-05b.txt>_______________________________________________
netconf mailing list
[e-mail]<mailto:[e-mail]>
https://www.ietf.org/mailman/listinfo/netconf