Re: [Netconf] Last Call on yang-push-17

"Banghart, Stephen A. (Fed)" <stephen.banghart@nist.gov> Thu, 16 August 2018 17:06 UTC

Return-Path: <stephen.banghart@nist.gov>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4711D130F1E for <netconf@ietfa.amsl.com>; Thu, 16 Aug 2018 10:06:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nist.gov
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q1uzLGxzaM8s for <netconf@ietfa.amsl.com>; Thu, 16 Aug 2018 10:06:14 -0700 (PDT)
Received: from GCC01-CY1-obe.outbound.protection.outlook.com (mail-cy1gcc01on0130.outbound.protection.outlook.com [23.103.200.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4FA0E130E6A for <netconf@ietf.org>; Thu, 16 Aug 2018 10:06:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nist.gov; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=od8QaVwhLWJAbbgmXHkHniWCnRk/dOusRZvg6c4iw+0=; b=fHoq/zgzptF9KsETy6VNBJTR+BJIYO4VeB/F9iKP/b3XzdXNEudCJqF7gW7UTa43PyK6n7Zg+A9eb0OYe318+y2k82iSqsnHTvMqyGEolcxshxtU0+5C7ef43P7JMR+PwXMgBkuy/IikslaRIiAop4L49QN2BN/p/z1y8TbyIVE=
Received: from DM5PR0901MB2199.namprd09.prod.outlook.com (10.167.109.39) by DM5PR0901MB2200.namprd09.prod.outlook.com (10.167.110.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.19; Thu, 16 Aug 2018 17:06:11 +0000
Received: from DM5PR0901MB2199.namprd09.prod.outlook.com ([fe80::191d:980b:6a50:c98f]) by DM5PR0901MB2199.namprd09.prod.outlook.com ([fe80::191d:980b:6a50:c98f%3]) with mapi id 15.20.1038.025; Thu, 16 Aug 2018 17:06:11 +0000
From: "Banghart, Stephen A. (Fed)" <stephen.banghart@nist.gov>
To: "netconf@ietf.org" <netconf@ietf.org>
Thread-Topic: Re: [Netconf] Last Call on yang-push-17
Thread-Index: AdQ1fyo2elPaINKJQRCLOgDLTjIRnQ==
Date: Thu, 16 Aug 2018 17:06:11 +0000
Message-ID: <DM5PR0901MB2199850230262D26EF7BB774F03E0@DM5PR0901MB2199.namprd09.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [129.6.110.122]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DM5PR0901MB2200; 6:cutXNccxQy5DUaAJoXItY/KYqLoX3N/e5xDeQBsi+I6bQr8/LxY0moe+I58MaYEYdQkc1HBlxIZqoIEVjPN5fFDVpyqD4VMWbhad36rsjtvQjFy17xBWM2Szb9mPy7qc1EOo8e7ch7DCIWHt9nzexHmROVgcgpIXqIHhIrVArGQM+Z1j9UTFkStyFLROxnlN5tfd05HT0Yz186/aR70F4WVVi6ElfWJagl1UN5ykiHzNGupQ3S/ZafbJ3md/aIjPOsU4JL2T4Drs/hABJqvGSMGFoEjDkCpTLscCwAIj4yXPW2YBP6X0CA3bvInXGpoyX9wyjXdaTq+CRdY8IsZIbbw8vJA5oWeE+wMdg/xU2KWruHDeCy6CiRYkYfJNC7nHJTBDe1OE9N8ltnHSoZKNBcftDuATbKrMWqXuUkrvswLWv4tetmEf/OHGQQ7ZZwkIMlcaABL8Co/mCutdDQQEdA==; 5:80sUxjV+IT7qHZqV7d/bBaNliIKVMj4tdhuTPkABebkaOcaaaNo51oqTGROt5Q0aGQqo8ArMRG32y1LU7Mb5miBNCi8Ht9Cd1PqvTWnNuMMpYQykoe8JQzQ+8rdP70PC3ouLScNimwCdMy1OP6VLGZK06WUJ9E3J/WDinVSO5oQ=; 7:lkpJM2TpxUm6gl7K5gvSSpWRyzAJCLLHC+JHdOC3d91J+RXRxjJhbGbezkXEH1b6ARiHOTZ/k4sdzLnjlDPEp8bztwRy40jO8rqMcIzkWbM9LAr3FhmORHKW+TK0gYhrks8ZLy2yPchzZrGXp1svAsAt3KSfiqBpZCPrSTfYkN3OT0mdYAbtTuHVQ1k1MuSRgJDzf8w9Ld94wJO0SFcGGnJbcHDiBm0bXbiWWm8D05x0MV474VFFddoRZm0OX3an
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 1155453d-17a0-4379-194e-08d6039a9161
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM5PR0901MB2200;
x-ms-traffictypediagnostic: DM5PR0901MB2200:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=stephen.banghart@nist.gov;
x-microsoft-antispam-prvs: <DM5PR0901MB2200ABA879143C8926D0F211F03E0@DM5PR0901MB2200.namprd09.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(158342451672863)(192374486261705)(21748063052155);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016); SRVR:DM5PR0901MB2200; BCL:0; PCL:0; RULEID:; SRVR:DM5PR0901MB2200;
x-forefront-prvs: 07665BE9D1
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(346002)(396003)(366004)(136003)(51444003)(189003)(199004)(99286004)(790700001)(55016002)(256004)(66066001)(8676002)(105586002)(14444005)(186003)(5640700003)(5630700001)(26005)(6436002)(68736007)(229853002)(6116002)(3846002)(86362001)(97736004)(74316002)(316002)(81156014)(7696005)(2900100001)(6246003)(1730700003)(81166006)(2351001)(54896002)(6506007)(6916009)(106356001)(7736002)(14454004)(33656002)(486006)(2906002)(476003)(5660300001)(9686003)(53936002)(6306002)(2501003)(5250100002)(8936002)(25786009)(478600001)(102836004); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR0901MB2200; H:DM5PR0901MB2199.namprd09.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: nist.gov does not designate permitted sender hosts)
x-microsoft-antispam-message-info: vx+cpB6smKF26XwBHlJZ82s6QVkPd7dX/88Fo3cvLQPkoy9zPW3ltg7wd6oWbw1WLXXZ5j9aIh5SoZkDsoP4tnHMzuvZ7Ur+BO7+rSHUMG5/BU+ekGu3EgcbKbc/uPAkwu0tWjiYTuazWW9zX5YPZOB0IlKrWCdiCkUsWTPe8cEqaC/iHN0kUQAEKZZdYvzqUjyulXfJXTLMXHD6cCu243YvGjw8k9hFpI/78X2qRDaDDNsCYhtisFQaj2aHttt+AnQj7TN4vlnQnliUOeCH35drPEWErds/4rnJChCAaK361iU2R0Dhd66PtNNVVnnCnz44NiMWBMv11BQ/YUjFCRrSQIWm5yMDA60KZ6cGjUI=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DM5PR0901MB2199850230262D26EF7BB774F03E0DM5PR0901MB2199_"
MIME-Version: 1.0
X-OriginatorOrg: nist.gov
X-MS-Exchange-CrossTenant-Network-Message-Id: 1155453d-17a0-4379-194e-08d6039a9161
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2018 17:06:11.6848 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2ab5d82f-d8fa-4797-a93e-054655c61dec
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0901MB2200
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/cbTCZpukIfq1QSXwj_eM-02eKa8>
Subject: Re: [Netconf] Last Call on yang-push-17
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 17:06:23 -0000

All,

I've completed a review of the top level YANG Push draft. I only had a few minor comments (below) as I reviewed, and I think that the document is ready to progress.

Regards,
Stephen Banghart

Sections 1-3: Periodic Subscriptions
I'd like to see some discussion on how periodic subscription differs from polling, or at least how periodic subscription solves (or doesn't solve) the issues of polling solutions. As a reader, I found myself noting that polling is client requested, and periodic subscriptions are server triggered, but beyond that I don't understand the important differences. This line in the Introduction:

A more effective alternative to polling is for an application to
   receive automatic and continuous updates from a targeted subset of a
   datastore.

seems to exclude the time interval periodic case. A sentence in the introduction, or perhaps in the glossary, could address this.


Section 2: BCP 14 boilerplate

A personal nit for me, I noticed the draft contains both upper and lower case MUSTs, SHOULDs, etc. A reference out to BCP 14 would clarify the intent behind these words.


Section 5: YANG Module

Would it be possible to move this module declaration to an Appendix? It's placement in the body of the document pushes IANA and Security Considerations to an obscure place in the document.