Re: [netconf] I-D Action: draft-ietf-netconf-ssh-client-server-32.txt

[tom petch <[e-mail]>]

From: Kent Watsen <[e-mail]>
Sent: 29 January 2023 02:24

<inline under <tp> >

Hi Tom,

Thank you for your review of the ssh-client-server draft.
Please see below for my responses to your comments.

Kent



> On Jan 26, 2023, at 8:06 AM, tom petch <[e-mail]> wrote:
>
> Some editorial glitches in the three SSH modules
>
> FIPS 186 2 needs adding to the I-D References

Informative ref added for FIPS 186-6 (-2 expired some time ago)

> RFC7317 is the reference for an import so needs to be Normative

Fixed.

> s.1.1 Hyperlinks are provided
> Well no, it depends on the format - URL yes, hyperlinks no

Changed:  s/Hyperlinks to/URLs for/   (affects all drafts)

>            "Acceptable encryption algorithms in order of descending
>              preference.
> suggest decreasing not descending

Changed (four instances)

> s.4.3       "This module defines reusable groupings for SSH servers
> I only see one grouping

Fixed (in ietf-ssh-client also)

>         Note that this grouping uses fairly typical descendant
>          node names such that a stack of 'uses' statements will
> suggest nest rather than stack.

I used "nesting" - okay?

<tp>
Yes fine
</tp>

>             list host-key {
> RFC4251 might be a better reference for host keys

I don't understand this comment.
<tp>
This is  a list of host key and that is part of the SSH architecture defined in 4251.  The KEXINIT message is defined in 4253 but that for me is not as relevant as the explanation of what a host key and how it is crucial to SSH
</tp>


>                "The 'user name' for the SSH client, as defined in
>                  the SSH_MSG_USERAUTH_REQUEST message in RFC 4253.";
> RFC4252 not RFC4253

What?   I got it right...

<tp>
Again this is about authentication and that is explained in RFC4252.  The message is listed in 4253 but I see that as less relevant than the issue of authentication which is covered in RFC4252

Tom Petch

</tp>


>           container hostbased {
>  ....
>                "RFC 4253: The Secure Shell (SSH) Transport Layer
> RFC4252 or RFC4251 not 4253

Now RFC4252


Kent




>
> Tom Petch
>
>
>
> ________________________________________
> From: netconf <[e-mail]> on behalf of [e-mail] <[e-mail]>
> Sent: 12 December 2022 18:50
> To: [e-mail]
> Cc: [e-mail]
> Subject: [netconf] I-D Action: draft-ietf-netconf-ssh-client-server-32.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Network Configuration WG of the IETF.
>
>        Title           : YANG Groupings for SSH Clients and SSH Servers
>        Author          : Kent Watsen
>  Filename        : draft-ietf-netconf-ssh-client-server-32.txt
>  Pages           : 143
>  Date            : 2022-12-12
>
> Abstract:
>   This document defines three YANG 1.1 modules: the first defines
>   features and groupings common to both SSH clients and SSH servers,
>   the second defines a grouping for a generic SSH client, and the third
>   defines a grouping for a generic SSH server.