Re: [netconf] I-D Action: draft-ietf-netconf-ssh-client-server-32.txt

Kent Watsen <kent+ietf@watsen.net> Sun, 29 January 2023 02:24 UTC

Return-Path: <01000185fb57248c-5512a462-16ef-4853-8cc3-9756120a0b86-000000@amazonses.watsen.net>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 186E1C14CE2F for <netconf@ietfa.amsl.com>; Sat, 28 Jan 2023 18:24:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EfrgGQhVSSRO for <netconf@ietfa.amsl.com>; Sat, 28 Jan 2023 18:24:31 -0800 (PST)
Received: from a48-95.smtp-out.amazonses.com (a48-95.smtp-out.amazonses.com [54.240.48.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BAC5C14CE28 for <netconf@ietf.org>; Sat, 28 Jan 2023 18:24:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1674959070; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:Feedback-ID; bh=57Vfwht+f3gLNXtlGfF724XnmKZClxMeeYkqSpNuNns=; b=ZxaI94bS6tkoMK0WZgkoBZ6/2Q6EmU3HWrpJUbIuWq0225Prm9wAuUK2oM1xZg0p 71Z00wbMULwsypk1JjwgqsadJsUL3aLJQs/9qfPAXUa+N6JZJQuMBMdMtaDG+nigcKB 81OYnSgGXGb0Db/PEiQ5DXE1Lzvr7kRqj231NjZg=
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\))
From: Kent Watsen <kent+ietf@watsen.net>
In-Reply-To: <AM7PR07MB6248269B4B3256F077EBB55AA0CF9@AM7PR07MB6248.eurprd07.prod.outlook.com>
Date: Sun, 29 Jan 2023 02:24:30 +0000
Cc: "netconf@ietf.org" <netconf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <01000185fb57248c-5512a462-16ef-4853-8cc3-9756120a0b86-000000@email.amazonses.com>
References: <167087103979.46389.9694896058931958199@ietfa.amsl.com> <AM7PR07MB6248269B4B3256F077EBB55AA0CF9@AM7PR07MB6248.eurprd07.prod.outlook.com>
To: tom petch <ietfc@btconnect.com>
X-Mailer: Apple Mail (2.3731.400.51.1.1)
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
X-SES-Outgoing: 2023.01.29-54.240.48.95
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/gCRW82aAe9ZTOFGN9s8LDfPcVQA>
Subject: Re: [netconf] I-D Action: draft-ietf-netconf-ssh-client-server-32.txt
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jan 2023 02:24:32 -0000

Hi Tom,

Thank you for your review of the ssh-client-server draft.
Please see below for my responses to your comments.

Kent



> On Jan 26, 2023, at 8:06 AM, tom petch <ietfc@btconnect.com> wrote:
> 
> Some editorial glitches in the three SSH modules
> 
> FIPS 186 2 needs adding to the I-D References

Informative ref added for FIPS 186-6 (-2 expired some time ago)


> RFC7317 is the reference for an import so needs to be Normative

Fixed.


> s.1.1 Hyperlinks are provided
> Well no, it depends on the format - URL yes, hyperlinks no

Changed:  s/Hyperlinks to/URLs for/   (affects all drafts)


>            "Acceptable encryption algorithms in order of descending
>              preference.
> suggest decreasing not descending

Changed (four instances)



> s.4.3       "This module defines reusable groupings for SSH servers
> I only see one grouping

Fixed (in ietf-ssh-client also)


>         Note that this grouping uses fairly typical descendant
>          node names such that a stack of 'uses' statements will
> suggest nest rather than stack.

I used "nesting" - okay?


>             list host-key {
> RFC4251 might be a better reference for host keys

I don't understand this comment.


>                "The 'user name' for the SSH client, as defined in
>                  the SSH_MSG_USERAUTH_REQUEST message in RFC 4253.";
> RFC4252 not RFC4253

What?   I got it right...


>           container hostbased {
>  ....
>                "RFC 4253: The Secure Shell (SSH) Transport Layer
> RFC4252 or RFC4251 not 4253

Now RFC4252


Kent




> 
> Tom Petch
> 
> 
> 
> ________________________________________
> From: netconf <netconf-bounces@ietf.org> on behalf of internet-drafts@ietf.org <internet-drafts@ietf.org>
> Sent: 12 December 2022 18:50
> To: i-d-announce@ietf.org
> Cc: netconf@ietf.org
> Subject: [netconf] I-D Action: draft-ietf-netconf-ssh-client-server-32.txt
> 
> 
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Network Configuration WG of the IETF.
> 
>        Title           : YANG Groupings for SSH Clients and SSH Servers
>        Author          : Kent Watsen
>  Filename        : draft-ietf-netconf-ssh-client-server-32.txt
>  Pages           : 143
>  Date            : 2022-12-12
> 
> Abstract:
>   This document defines three YANG 1.1 modules: the first defines
>   features and groupings common to both SSH clients and SSH servers,
>   the second defines a grouping for a generic SSH client, and the third
>   defines a grouping for a generic SSH server.