Re: [netconf] WG Last Call: draft-ietf-netmod-factory-default-05

Martin Bjorklund <mbj@tail-f.com> Mon, 04 November 2019 11:39 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED7891200D7; Mon, 4 Nov 2019 03:39:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9vJtPAGBJaf5; Mon, 4 Nov 2019 03:39:54 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 67FD21200B3; Mon, 4 Nov 2019 03:39:54 -0800 (PST)
Received: from localhost (unknown [173.38.220.41]) by mail.tail-f.com (Postfix) with ESMTPSA id 9F86D1AE018B; Mon, 4 Nov 2019 12:39:52 +0100 (CET)
Date: Mon, 04 Nov 2019 12:39:23 +0100 (CET)
Message-Id: <20191104.123923.1142091174247472340.mbj@tail-f.com>
To: netconf@ietf.org, draft-ietf-netmod-factory-default@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <0100016e27785ce1-6ade1cd2-78fc-40ee-bb4d-f7c4b685e3d3-000000@email.amazonses.com>
References: <0100016e27785ce1-6ade1cd2-78fc-40ee-bb4d-f7c4b685e3d3-000000@email.amazonses.com>
X-Mailer: Mew version 6.8 on Emacs 25.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/aG61Dcmbx7giOaTMMFRYSGcYXXs>
Subject: Re: [netconf] WG Last Call: draft-ietf-netmod-factory-default-05
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2019 11:39:56 -0000

Hi,

I have reviewd version 06 of this draft, and have some comments:


o  Abstract and Introduction

  These both contain:

   Optionally a new "factory-default" read-only datastore is defined,

  Perhaps change to:

   A new optional read-only datastore "factory-default" is defined,


o  Abstract and Introduction

  These both contain:

    The reset operation may be used e.g. during initial
    zero-touch configuration 

  and in the Introduction there's a reference to RFC 8572.

  But what does this actually mean?


o  Introduction

  OLD:

   NETCONF defines the <delete> operation that allows resetting the

  NEW:

   NETCONF defines the <delete-config> operation that allows resetting the


o  Section 2

  This section says:

    Factory-default content MAY be specified by one of the following
    means in descending order of precedence

    1.  <factory-default> datastore, if it exists;

    2.  by vendors using a file in YANG Instance Data
        [I-D.ietf-netmod-yang-instance-file-format] format or some other
        format in vendor's website or other places where similar off-line
        documents are kept;

    3.  In some implementation specific manner;


  I don't think this defines any useful behaviour, and suggest this
  text is removed.


o  Section 2

  This section says:

    For the server supporting zero touch bootstrapping mechanisms, the
    factory default configuration causes the bootstrapping process to
    execute,e.g.,the server resets configuration to device's factory
    default configuration,for the version of operating system software it
    is running.

  It is not clear to me what this is supposed to mean.  I think it
  means "if the factory default configuration specifies that ztp is to
  be run, then ztp will be run after a factory reset".  But this is
  kind of obvious...  So I suggest that this sentence is removed.


o  Section 4

  The YANG module contains the boilerplate text from RFC 8174, but the
  module doesn't use 8174-language, so I suggest the boilerplate text
  is removed.


o  Section 4

  Suggest:

  OLD:

     feature factory-default-as-datastore {
       description "Indicates that the factory default configuration is
         also available as a separate datastore";
     }

  NEW:

     feature factory-default-as-datastore {
       description
         "Indicates that the factory default configuration is
          available as a datastore.";
     }


o  Section 4

  The module augments a new leaf 'factory-default' into <get-config>.
  I suggest that we remove this.  Other datastores like intended are
  not available through get-config, and I see no reason why
  factory-default should be treated differently.


o  Section 4

  I recommend that you run the YANG module through

    pyang -f yang --keep-comments --yang-line-length 69 <FILE>

  in order to fix some formatting and indentation issues.



/martin