Re: [Netconf] mbj's WGLC review of yang-push-17

Andy Bierman <andy@yumaworks.com> Tue, 25 September 2018 22:11 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45386130DDA for <netconf@ietfa.amsl.com>; Tue, 25 Sep 2018 15:11:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6v4nVmc9-vjk for <netconf@ietfa.amsl.com>; Tue, 25 Sep 2018 15:11:38 -0700 (PDT)
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3DB4F1277BB for <netconf@ietf.org>; Tue, 25 Sep 2018 15:11:38 -0700 (PDT)
Received: by mail-lj1-x22b.google.com with SMTP id j25-v6so3253651ljg.2 for <netconf@ietf.org>; Tue, 25 Sep 2018 15:11:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=OS+bdluSlEHabb0fvO9XAjyNxyEFq9W2Wb8jUlqoRsM=; b=yQuT6d2O3CVGCJdSWQPuS4Q08PnX34KNe52gCTxW+ldgw/m5iDR6HbBagQL1J6L6rh NJMHcWJKt4kcLVj1LBrOuEeTE4YKLCWIQNzMi6lQk1N7HATaeFh6FVi8sSgR88ZjXGCl ArneAoF3c4EMZsD9Yp+/0zztUGVxCerEM0x/mdqxlVV6mdad15huN2tLbGAw0KxPstBb 2GApzFF+OEMRbvCsVyYbdtH985BhQoFip9QTajYQFDszH056ZVQYnpj9jKdxWANhXQVn XtkpNfeVmUuAKJPlY9zelcn8JEGuUHbOWKo43RNgsoh5K47KNZZHBgtD5OuCRx406l9p PCgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=OS+bdluSlEHabb0fvO9XAjyNxyEFq9W2Wb8jUlqoRsM=; b=VU2wYJx4Lur2MLEoNiuegrymsiV4TBiar2n3R2zWnpO1WUMRUxwfCNU4qvv+1TBUbk Labs2IWslebvJr3iwB1bOd9fVUMR1vTI8Bkqo4Y8bayyOpzd/SyEpDhH+uX2+RQfZZ5y k9G+WtQOiIh9GMITr0ihwWISAc1BMvnFQ17wKx/h0eqdc5pZIQQL3/Jarp6nHPAjbqzK Mqartj2ZBn+BhXCR1t+1azt7kmoOZXOMy7UZcERzWlYE7875izYuyYCk5rkPU7G7q0Id VJeegNQtvxw2ixtsgV36me91OG9rTZcU9RLLjVuNk24/1m6n1wqwKDdqxX1boO6BODV7 hB7Q==
X-Gm-Message-State: ABuFfog/eBgrVMWeeLjmeOZmB/bYJlyqaEkEyD85Rps/f6dCOlUZlYEd Ol4HwlTZ9qzYAPeMvrAUZbFm5FBoR+VICighxhop0A==
X-Google-Smtp-Source: ACcGV61Tpb8f2B3J2WuXPa9YNhcsqezZ1LG3sQ0uSOfkP/O/Gpspf0vUadi07obbMtftBZXV+MGZsboTYB7347k4J7E=
X-Received: by 2002:a2e:9c89:: with SMTP id x9-v6mr2445783lji.110.1537913496036; Tue, 25 Sep 2018 15:11:36 -0700 (PDT)
MIME-Version: 1.0
References: <3B841FC9-63F4-41DD-BCE2-AA543FDADA5C@juniper.net> <20180920.094520.798604819426315275.mbj@tail-f.com> <644DA50AFA8C314EA9BDDAC83BD38A2E0EB691A5@sjceml521-mbx.china.huawei.com> <20180924.093612.1791958587714330227.mbj@tail-f.com> <A1DF23A4-3D00-43D7-B121-D9F567B2A43F@juniper.net> <020f01d454ae$2e41e4a0$4001a8c0@gateway.2wire.net> <CABCOCHSATfi4Nq3XLGL65Kj4R_gWTFSf6H0v8qD8DE4aYOpDiQ@mail.gmail.com> <674F5961-D956-4BD1-8AD0-44FE68150070@juniper.net> <20180925213145.r72ybqbuv5qy4dct@anna.jacobs.jacobs-university.de>
In-Reply-To: <20180925213145.r72ybqbuv5qy4dct@anna.jacobs.jacobs-university.de>
From: Andy Bierman <andy@yumaworks.com>
Date: Tue, 25 Sep 2018 15:11:24 -0700
Message-ID: <CABCOCHRs8Zg=wvmO_sa4N8utBq3fvL39NcB=A1DN3kpbTEzfXA@mail.gmail.com>
To: Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de>, Kent Watsen <kwatsen@juniper.net>, Netconf <netconf@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000a082e80576b963cb"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/lVaZRxDkxhKT5Ef7UlEVCx5-63o>
Subject: Re: [Netconf] mbj's WGLC review of yang-push-17
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 22:11:41 -0000

On Tue, Sep 25, 2018 at 2:32 PM Juergen Schoenwaelder <
j.schoenwaelder@jacobs-university.de> wrote:

> On Tue, Sep 25, 2018 at 05:52:25PM +0000, Kent Watsen wrote:
> >
> > I still think replacing "type yang:timeticks" with "type unit32" and
> "units
> > hundredths of a sec" is more intuitive, as:
> >   - no need to look up what a timetick is.
> >   - no need to understand why the two "epoch" times aren't documented
> >     in YP, as required(?) by RFC 6991.
> >   - more closely aligns with the [netcont/restconf]-client-server drafts
>
> It seems the type you want for the 'period' leafs in your ID is not
> timeticks but an equivalent of RFC 2579's TimeInterval:
>
> TimeInterval ::= TEXTUAL-CONVENTION
>     STATUS       current
>     DESCRIPTION
>             "A period of time, measured in units of 0.01 seconds."
>     SYNTAX       INTEGER (0..2147483647)
>
> I am somewhat surprised we do not have something matching the
> TimeInterval TC in RFC 6991, I do not recall why.
>
> The TimeTicks TC (and hence the timeticks YANG type) represents time
> that ticks. The classic example is sysUpTime - sysUpTime has a new
> value whenever you read it since it constantly ticks. Hence, the
> timeticks type is pretty useless for configuration objects.
>
> If you roll your own type, perhaps you want a type like this:
>
>   type centiseconds {
>     type uint32;
>     description
>       "A period of time, measured in units of 0.01 seconds.";
>   }
>
>

I like this approach, but maybe it would be better to follow the timeticks
example

   typedef time-interval {
      type uint32;
      units "hundredths of a second";  // ?
      description
          "A period of time, measured in units of 0.01 seconds.";
       reference
            "RFC 2579: Textual Conventions for SMIv2";
   }

Andy



> With this, you would get something more descriptive:
>
>           leaf period {
>             type centiseconds;
>             mandatory true;
>             description
>               "Duration of time which should occur between periodic
>                push updates.";
>           }
>
> /js
>
> --
> Juergen Schoenwaelder           Jacobs University Bremen gGmbH
> Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany
> Fax:   +49 421 200 3103         <https://www.jacobs-university.de/>
>
> _______________________________________________
> Netconf mailing list
> Netconf@ietf.org
> https://www.ietf.org/mailman/listinfo/netconf
>