Re: [Netconf] mbj's WGLC review of yang-push-17

"Eric Voit (evoit)" <evoit@cisco.com> Tue, 25 September 2018 17:51 UTC

Return-Path: <evoit@cisco.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2726212785F for <netconf@ietfa.amsl.com>; Tue, 25 Sep 2018 10:51:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GcHXn-jleBub for <netconf@ietfa.amsl.com>; Tue, 25 Sep 2018 10:51:35 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D2031277CC for <netconf@ietf.org>; Tue, 25 Sep 2018 10:51:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=18532; q=dns/txt; s=iport; t=1537897895; x=1539107495; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=n8dfg3SZp2MjucfouakwHf3BW0FcFYMwuF8yBCaS6Zk=; b=X5Kz4RnIdFK5BI36xGBM3PvRLLAZMZlirRrTUNY+54SYj3ftFbBAuckG 0suK7A5ZW/K3Du03lpbg1htChLJxZb3YCrEFrg1Q3zwBT7ZIX4mLEgtAS NO1pBMLl/Yra4x2NWE3R7DsBvJEyL/B5bu7NloLyyXbHm8btfRiu92DbY s=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ALAAC6dKpb/51dJa1bGQEBAQEBAQEBAQEBAQcBAQEBAQGBUoEWd2V/KAqDapRCgg2REoU8gXoLGAEKhANGAheDTyE1FwEDAQECAQECbRwMhTgBAQEBAgEBASEKQQsFBwQCAQgVAQInAwICAiULFBECBAENBQiDGoEdXAgPpBaBLooUBYp6F4FBP4ESgxKDGwEBA4E4PR+CS4JXAoh0hHaFdYhRTwkChkGJXh+PLIt6iGgCERSBJR8DM4FVcBU7gmyCJReIWoU+b4tIgS2BHgEB
X-IronPort-AV: E=Sophos;i="5.54,303,1534809600"; d="scan'208,217";a="460386346"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 17:51:33 +0000
Received: from XCH-RTP-015.cisco.com (xch-rtp-015.cisco.com [64.101.220.155]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id w8PHpXQe016306 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 25 Sep 2018 17:51:33 GMT
Received: from xch-rtp-013.cisco.com (64.101.220.153) by XCH-RTP-015.cisco.com (64.101.220.155) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 25 Sep 2018 13:51:32 -0400
Received: from xch-rtp-013.cisco.com ([64.101.220.153]) by XCH-RTP-013.cisco.com ([64.101.220.153]) with mapi id 15.00.1395.000; Tue, 25 Sep 2018 13:51:32 -0400
From: "Eric Voit (evoit)" <evoit@cisco.com>
To: Andy Bierman <andy@yumaworks.com>, "t.petch" <ietfc@btconnect.com>
CC: Netconf <netconf@ietf.org>
Thread-Topic: [Netconf] mbj's WGLC review of yang-push-17
Thread-Index: AQHUVPDUPLguyzPPBUeA9Mav+IS/2aUBQatQ
Date: Tue, 25 Sep 2018 17:51:32 +0000
Message-ID: <31256be990c44570a18bc1dd6c5a7595@XCH-RTP-013.cisco.com>
References: <3B841FC9-63F4-41DD-BCE2-AA543FDADA5C@juniper.net> <20180920.094520.798604819426315275.mbj@tail-f.com> <644DA50AFA8C314EA9BDDAC83BD38A2E0EB691A5@sjceml521-mbx.china.huawei.com> <20180924.093612.1791958587714330227.mbj@tail-f.com> <A1DF23A4-3D00-43D7-B121-D9F567B2A43F@juniper.net> <020f01d454ae$2e41e4a0$4001a8c0@gateway.2wire.net> <CABCOCHSATfi4Nq3XLGL65Kj4R_gWTFSf6H0v8qD8DE4aYOpDiQ@mail.gmail.com>
In-Reply-To: <CABCOCHSATfi4Nq3XLGL65Kj4R_gWTFSf6H0v8qD8DE4aYOpDiQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.118.56.235]
Content-Type: multipart/alternative; boundary="_000_31256be990c44570a18bc1dd6c5a7595XCHRTP013ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.155, xch-rtp-015.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/zmIfAL_nX3MpZ_ZjqZL8xoCt2c4>
Subject: Re: [Netconf] mbj's WGLC review of yang-push-17
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 17:51:39 -0000

From: Andy Bierman, September 25, 2018 12:57 PM

On Tue, Sep 25, 2018 at 2:01 AM tom petch <ietfc@btconnect.com<mailto:ietfc@btconnect.com>> wrote:
----- Original Message -----
From: "Kent Watsen" <kwatsen@juniper.net<mailto:kwatsen@juniper.net>>
Sent: Monday, September 24, 2018 7:15 PM

> >Alexander Clemm <alexander.clemm@huawei.com<mailto:alexander.clemm@huawei.com>> wrote:
> >> I am about to post -19 but I do not like the suggested change to go
> >> from timeticks to seconds.
> >>
> >> Seconds is a fairly coarse unit.  I would not be surprised to see
> >> requirements for finer granularity in the future, even more so in
> >> virtualization and controller scenarios in which we start to see
YANG
> >> being used.  There are applications that use single second periods
> >> today so I think it is entirely conceivable to see need for
subsecond
> >> support down the line.  To allow periods only in units of seconds
> >> would seem to unnecessarily hobble ourselves.  Keeping things to
> >> timeticks is more futureproof IMHO.
> >
> > Ok.
>
> I agree that seconds is too course. Hundredths of a second is maybe
too
> fine, but I won't complain.  That said, I think that it might be an
> uncommon scenario and that having hundredths of a second will likely
> result in very large numbers.
>
> FWIW, yang:timeticks doesn't seem as intuitive as "units" - for
example:

Kent

It may depend where you come from.  As RFC6991 points out, timeticks is
designed to be compatible with SMI TimeTicks and so will likely to be
familiar,  expected even, for those who have been at this for, say, 10
years or more.


Or even 30 years!
https://tools.ietf.org/html/rfc1065

I do not understand the motivation for using uint16.
This would limit the maximum period to 655.35 seconds.

<eric> Current definition supports up to 248 days.  Which looks sufficient at this point to me.

Eric

Tom Petch

Andy


>           leaf period {
> -           type yang:timeticks;
> +           type uint16;
> +           units "Hundredths of a second";
>             mandatory true;
>             description
>               "Duration of time which should occur between periodic
>                push updates.";
>           }
>
> At least I know what this means right away.  I was hoping to find an
example
> in -19 illustrating its use, but it's none is present.
>
> BTW, I note that RFC 6991 says:
>
>          When a schema
>          node is defined that uses this type, the description of
>          the schema node identifies both of the reference epochs.
>
> Which I don't see in -19.
>
> Would it make sense to use a 2-tuple?  Something like:
>
>           leaf period {
>             type uint16;
>             mandatory true;
>             description
>               "Duration of time which should occur between periodic
>                push updates.";
>           }
>           leaf period-units {
>             type enumeration {
>               enum hundredths;
>               enum tenths;
>               enum seconds;
>               enum minutes;
>               enum hours;
>             }
>             mandatory true;
>           }
>
>
>
> Kent // contributor
>
>
> _______________________________________________
> Netconf mailing list
> Netconf@ietf.org<mailto:Netconf@ietf.org>
> https://www.ietf.org/mailman/listinfo/netconf

_______________________________________________
Netconf mailing list
Netconf@ietf.org<mailto:Netconf@ietf.org>
https://www.ietf.org/mailman/listinfo/netconf