Re: [nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06

Chuck Lever <chuck.lever@oracle.com> Wed, 29 January 2020 15:23 UTC

Return-Path: <chuck.lever@oracle.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CE0E12009C; Wed, 29 Jan 2020 07:23:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.301
X-Spam-Level:
X-Spam-Status: No, score=-4.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UPUOqiYL2LgD; Wed, 29 Jan 2020 07:23:49 -0800 (PST)
Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 74FDF120020; Wed, 29 Jan 2020 07:23:49 -0800 (PST)
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00TFDeP2162483; Wed, 29 Jan 2020 15:23:47 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2019-08-05; bh=YYEv90xaazgONyWvbS1yvRseNn66RC4C2S7FXAKCJoU=; b=VxKkXRGe6G8LBjDC2xTJVUx5tuh8IvFyjD0RCaVVdP/HnErSVcTpJWwDLlvyEilKJO4/ 1LktQzPS7wgk5ehKyfUoDb2eOF1Uuzt3z34ZDMUCjXpW4W44u0QKN6yOdri0ooevQFnW E4DpbH07Y4fKWLos0zwerSTW6LWmd7kLOmsNapENzly/h3B4LLDTqMMYW3qLAwcMDh+9 kWK3shxgWLL+PajZ4+BLW8kPCfhAspycK24pjegYROVIccjghTXmr6xd0/QyxmP4CnXf /szWzau8BlNKlY//i0hJcndEkuSBQ7GaPdPh7h25sHSGCyUDH/T3Vp0s3oyEN+KuR4Uo pg==
Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2xreare0mp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2020 15:23:46 +0000
Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00TFDolv062038; Wed, 29 Jan 2020 15:23:46 GMT
Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2xth5keg0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jan 2020 15:23:46 +0000
Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00TFNjTT003043; Wed, 29 Jan 2020 15:23:45 GMT
Received: from anon-dhcp-152.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Jan 2020 07:23:45 -0800
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Chuck Lever <chuck.lever@oracle.com>
In-Reply-To: <CAMRcRGR2XkudwuWczgHbF23=E6tAgrzMrUNDNTjJbVR=bmhung@mail.gmail.com>
Date: Wed, 29 Jan 2020 10:23:43 -0500
Cc: gen-art@ietf.org, draft-ietf-nfsv4-rpcrdma-cm-pvt-data.all@ietf.org, nfsv4@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <96353CFE-9CA9-4146-83D7-310E48AD4907@oracle.com>
References: <158015386640.23917.3626035422388212873@ietfa.amsl.com> <301328AC-ECCC-41FA-A8E5-F81A9A7FDAF9@oracle.com> <CAMRcRGR2XkudwuWczgHbF23=E6tAgrzMrUNDNTjJbVR=bmhung@mail.gmail.com>
To: Suhas Nandakumar <suhasietf@gmail.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9514 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001290128
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9514 signatures=668685
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001290128
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/LVoCzsfnR7eFja5RV_IE2xJxg7Y>
Subject: Re: [nfsv4] Genart last call review of draft-ietf-nfsv4-rpcrdma-cm-pvt-data-06
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jan 2020 15:23:51 -0000

> On Jan 29, 2020, at 12:03 AM, Suhas Nandakumar <suhasietf@gmail.com> wrote:
> 
> Thanks Chuck for the response. Please see inline
> 
>> On Tue, Jan 28, 2020 at 7:52 AM Chuck Lever <chuck.lever@oracle.com> wrote:
>> 
>> Zero is a permitted value for the size fields. Section 5.2 explains how
>> to compute the actual buffer size. If those fields contain zero, the
>> actual send and receive buffer sizes would be 1024 octets.
> 
> 
> [Suhas] I am not sure if i am reading it right here. Section 5.2 would result in the
> value of -1 if the min of the values is Zero (0/1024 - 1). Isn't it so ?

Section 5.2 says:

   Inline threshold sizes from 1KB to 256KB can be represented in the
   Send Size and Receive Size fields.  A sender computes the encoded
   value by dividing the actual value by 1024 and subtracting one from
   the result.  A receiver decodes this value by performing a
   complementary set of operations.

Here, "actual value" means the real size of the buffer. A 1024-octet
buffer would result in (1024 / 1024) - 1 = 0.

The computation done by the receiver is the inverse:

   (0 + 1) * 1024 = 1024

I could replace "actual value" by "buffer size, in octets". Would it
help if the text also spelled out the inverse computation?


--
Chuck Lever