Re: [Ntp] Antw: Re: Antw: [EXT] comments on draft‑mlichvar‑ntp‑ntpv5‑03

Miroslav Lichvar <mlichvar@redhat.com> Wed, 24 November 2021 13:51 UTC

Return-Path: <mlichvar@redhat.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70E2E3A0597 for <ntp@ietfa.amsl.com>; Wed, 24 Nov 2021 05:51:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.802
X-Spam-Level:
X-Spam-Status: No, score=-2.802 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2AvkEwbRaOyL for <ntp@ietfa.amsl.com>; Wed, 24 Nov 2021 05:51:18 -0800 (PST)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7B0FA3A05A1 for <ntp@ietf.org>; Wed, 24 Nov 2021 05:51:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637761877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CTFdo9Y3uxSplEYK5ND9KlIz8kg4pP5QRd5MofLCt+Q=; b=LRFSICK3QdzlPQ9yz6RfDQnUveGTv1wJx5FZduFCmO26zZ7p66tG06zZzGE1pFuRpEKhHy H4LJIRomfPZ2Z8igVi5tqNZoJa8qlEJi98YpDegRFtJKlqcApUVCVz+ZTLYyn09MwbHA4X yVssEpAmek80ogfIDfpgxweTAJuE/fk=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-WpEwRoqiPpyDNJfp8XEAJw-1; Wed, 24 Nov 2021 08:51:15 -0500
X-MC-Unique: WpEwRoqiPpyDNJfp8XEAJw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C279081CCB4; Wed, 24 Nov 2021 13:51:14 +0000 (UTC)
Received: from localhost (holly.tpb.lab.eng.brq.redhat.com [10.43.134.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA39260C17; Wed, 24 Nov 2021 13:51:13 +0000 (UTC)
Date: Wed, 24 Nov 2021 14:51:12 +0100
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>
Cc: dan-ntp@drown.org, "ntp@ietf.org" <ntp@ietf.org>
Message-ID: <YZ5DUGug+0XW/5qF@localhost>
References: <20211123131501.Horde.ErUH7VWw3Nr2PFkAGzGIEuI@mail.drown.org> <619DEA79020000A10004599E@gwsmtp.uni-regensburg.de> <YZ39jGBrF+zeiYm3@localhost> <619E23DC020000A1000459C9@gwsmtp.uni-regensburg.de> <YZ4rYlSynuH2RWpu@localhost> <619E313E020000A1000459CF@gwsmtp.uni-regensburg.de>
MIME-Version: 1.0
In-Reply-To: <619E313E020000A1000459CF@gwsmtp.uni-regensburg.de>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/3Ai-jeRxV5sHEGX1umVXFxwDdgs>
Subject: Re: [Ntp] Antw: Re: Antw: [EXT] comments on draft‑mlichvar‑ntp‑ntpv5‑03
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Nov 2021 13:51:22 -0000

On Wed, Nov 24, 2021 at 01:34:06PM +0100, Ulrich Windl wrote:
> >>> Miroslav Lichvar <mlichvar@redhat.com> schrieb am 24.11.2021 um 13:09 in
> > MAXDISP is the threshold when the server is considered unsynchronized
> > after it stops updating its clock. It should be larger than any
> > normally expected dispersion to not block synchronization.
> > 
> > With the default PHI of 15 ppm, it takes 16/15e‑6 seconds (about
> > 12.3 days) for the dispersion to accumulate 16 seconds. In the worst
> > case it should cover up to 15 strata updating clocks at a maximum
> > polling interval.
> > 
> > I think 1 second would be too small.
> 
> But doesn't that value also say "the reference clock can be off by as much as
> MAXDISP"?

In the sense that if a stratum 1 server had a dispersion of 1 second,
it wouldn't be accepted by its clients as synchronized?

> Considering that values above MAXDIST (1s) are ignored anyway, I wonder.
> Probably the real reason is that 16 needs five left shifts until it is less
> than MAXDIST (samples until server is accepted).
> 
> It's all a lot of heuristics, possibly still rooting from the time when it was
> important to avoid integer overflows in the math.
> 
> With MAXDISP being just one second, the first sample from a server will
> probably make it a valid one.

That is a good point. The clock filter does have an assumption about
the MAXDISP/MAXDIST ratio as it uses MAXDISP for dummy sumples when
empty. I think it would be better if it simply counted the samples
instead of processing dummy values.

-- 
Miroslav Lichvar