[Ntp] comments on draft-mlichvar-ntp-ntpv5-03

Dan Drown <dan-ntp@drown.org> Tue, 23 November 2021 19:15 UTC

Return-Path: <dan-ntp@drown.org>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D6CF53A0882 for <ntp@ietfa.amsl.com>; Tue, 23 Nov 2021 11:15:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9VTjHflet_BH for <ntp@ietfa.amsl.com>; Tue, 23 Nov 2021 11:15:03 -0800 (PST)
Received: from vps3.drown.org (vps3.drown.org [96.126.122.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8C7763A0881 for <ntp@ietf.org>; Tue, 23 Nov 2021 11:15:03 -0800 (PST)
Received: by vps3.drown.org (Postfix, from userid 48) id 23FBF2FC3CD; Tue, 23 Nov 2021 13:15:01 -0600 (CST)
Received: from 2603-8080-2709-c400-a567-9999-cad0-5dea.res6.spectrum.com (2603-8080-2709-c400-a567-9999-cad0-5dea.res6.spectrum.com [2603:8080:2709:c400:a567:9999:cad0:5dea]) by mail.drown.org (Horde Framework) with HTTPS; Tue, 23 Nov 2021 13:15:01 -0600
Date: Tue, 23 Nov 2021 13:15:01 -0600
Message-ID: <20211123131501.Horde.ErUH7VWw3Nr2PFkAGzGIEuI@mail.drown.org>
From: Dan Drown <dan-ntp@drown.org>
To: ntp@ietf.org
User-Agent: Horde Application Framework 5
Content-Type: text/plain; charset="utf-8"; format="flowed"; DelSp="Yes"
MIME-Version: 1.0
Content-Disposition: inline
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/JR8GDnecxL0qe2MAoIK80fsCtNE>
Subject: [Ntp] comments on draft-mlichvar-ntp-ntpv5-03
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Nov 2021 19:15:06 -0000

After reading this draft, I'm glad to see these things are included:

1. the unknown leap seconds flag seems useful for embedded systems  
that don't have easy access to that information
2. the explicit interleaved mode with server cookies
3. client timestamps are switched to a client cookie
4. the removal of all modes except client/server

I have a few comments, and I think I'll break them up into multiple  
emails to make discussion easier.

This email will be on the "3. Data Types" section.

For the time16 definition "the maximum value is 32767/32768" This  
confused me on first read because I parsed it as either/or at first  
which made no sense. I had to think about it until I realized this was  
talking about a fraction. I'm proposing a change to: "the maximum  
value is the fraction 32767/32768 (almost 1 second)"

Should the log2 format be explained in more detail in this section?  
I've seen a lot of people confused about this data type, so I'm hoping  
a definition would help. Maybe something like "log2 - an 8 bit signed  
integer representing the rounded log2 value of seconds. For example, a  
log2 value of -2 would be 2 to the power of -2 or 0.25 seconds"

Should the change from NTPv4's time32 format be mentioned here?   
Something like:
"A 32-bit fixed-point type containing values in seconds. It has 4  
unsigned integer bits and 28 fractional bits. The maximum value is 16  
seconds and the resolution is about 3.7 nanoseconds. Note: this is  
different than the 32 bit time format in NTPv4 (RFC5905)"