Re: [Ntp] Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)

Francesca Palombini <francesca.palombini@ericsson.com> Thu, 09 December 2021 17:11 UTC

Return-Path: <francesca.palombini@ericsson.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4B4923A1013; Thu, 9 Dec 2021 09:11:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 21enx82teS4g; Thu, 9 Dec 2021 09:11:35 -0800 (PST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 958613A1000; Thu, 9 Dec 2021 09:11:33 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRAXIeX3oPeKL8AQ4OFePzdtt7DvV0n2nDUVF7LqXLD7NXD+2vkxFir08v5g3DuTiZyJnR/Op/8ePYzm6JnRqV8XDGo+SeMPcZuCsn87uLteS51pBS8zLGAr2pV/jukCImiXFRiG5zMmPAz+3U7vP76hfqnvw2R0DXROAZu5oeO3w4U5GHLJqdxtK2iYSGOTDaSujwVnwoiw5vREE2VzbXM/cPEIVpo3Jc9eAcUmpyjwu+uEM1WMrNoerhW5aWEkSmcUygnj6XFQJ0Sj47uVWRWVXAD248jWj7Ntp37qqCFp6hVf3rRDE4FmjDiGoQyGwMX539GbfPRdlHMI5nyYlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WjmNWpEjs/GVp/4hb3oaDwONqUMFcGgnwsQp+eZSTzM=; b=l2TwkCDhCV7GKCHVBcb5sdT9UN7eZo26VZm3Y90/rbxKksqNxQS4oNe6a9RGpCSKLtYPgrvAL7oozfdYNjy2elzZ3auLCTut93G6Wz5TRwi4PEx03bScLqMPSCoTg8o73uK38nu8XNIxKzb37JvtPBv6iCiMFcrxnHkfqNcjNe8Ayy0q9Aa7Xfizq8BakWET3OWKI3VsEuDkeQ6MZpp8k498jfGjpQf0qirMople4xV5cJKGsn4idMGelwTFgoTWogwMiNmheXBPMQcyTvmzHn14yF5KXnkAHxqotkgRbCUGexDlaNYWtNtd1u1tFD0J/jEcGMv2xkTylx/yR8vc8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WjmNWpEjs/GVp/4hb3oaDwONqUMFcGgnwsQp+eZSTzM=; b=MvuHj0Xb9B26Q+AwlUPVuApRKU5UwTxN2MQMPTbdB9RHRPkU7B+1zXuVapuOTjRAVLG+v+rL0FRGm7mfCfgrNJKb25Tl6yPLMzKVXdhAYBzDWtgTCbY2SB6ZYekiWmiQnWdTOKdDKlKrA0Vu3m4bHCMqZGseYgRgrycOrDgPaDg=
Received: from HE1PR07MB4217.eurprd07.prod.outlook.com (2603:10a6:7:96::33) by HE1PR07MB4298.eurprd07.prod.outlook.com (2603:10a6:7:a3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.10; Thu, 9 Dec 2021 17:11:30 +0000
Received: from HE1PR07MB4217.eurprd07.prod.outlook.com ([fe80::cdd0:1e2:cd0b:790f]) by HE1PR07MB4217.eurprd07.prod.outlook.com ([fe80::cdd0:1e2:cd0b:790f%7]) with mapi id 15.20.4778.013; Thu, 9 Dec 2021 17:11:30 +0000
From: Francesca Palombini <francesca.palombini@ericsson.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>
CC: The IESG <iesg@ietf.org>, "draft-ietf-ntp-yang-data-model@ietf.org" <draft-ietf-ntp-yang-data-model@ietf.org>, "ntp-chairs@ietf.org" <ntp-chairs@ietf.org>, NTP WG <ntp@ietf.org>, Dieter Sibold <dsibold.ietf@gmail.com>
Thread-Topic: Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)
Thread-Index: AQHXbcs6PsWcGQlIvk6rTYC18QJJnKwrYIeAgAACr14=
Date: Thu, 9 Dec 2021 17:11:29 +0000
Message-ID: <HE1PR07MB4217E821C8FCE81BAAEF7C0A98709@HE1PR07MB4217.eurprd07.prod.outlook.com>
References: <162506975525.16899.10820299795831774115@ietfa.amsl.com> <CAB75xn5BRac9phcx7J1Lezfb=ff_HAQGxJ3Ykaid1tqGVSTe2w@mail.gmail.com>
In-Reply-To: <CAB75xn5BRac9phcx7J1Lezfb=ff_HAQGxJ3Ykaid1tqGVSTe2w@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56810b15-2306-4156-9610-08d9bb36f15e
x-ms-traffictypediagnostic: HE1PR07MB4298:EE_
x-microsoft-antispam-prvs: <HE1PR07MB4298BC5BE67555D856E2BB0A98709@HE1PR07MB4298.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: VQbP6wsVc+i6KAAjGTnGLCEFjMK9B+xxxTqdhQZcnZxmbINHf7obuyA1p9g0d4aMCgB1C/nYhPINB7Z6wqfT+9PapBjrYTCaCbyPJkM9gS0G9pqNYh+NF1hVUNqrraWKQgxxIDWugniWaVjZmfTnlagmivthVtRsw8FXnfsFsKcbNsriWT2l04k8yDzHMkvhJUMdOhp0M52fIB8UyMBPB3uX9cyAcX7nOmPgKX12mBmPuQPpy97El3hPfLqFWMZPeNhh9SSGGj/zY+HyUG9i3OTyCDfFIZEYZNeK4Bm2ZXHJJ5CU0DKZyIX60XdJftXJ7RmNjkKpyPftS1aeJnsDxZBDSAf/AWMzLL35AKj9YPkr0bahJBxQirCSN85N4sjwWXKFv+7yzEwMcWu6xIOgLxXYL9+ylvNGYJoAuVu5/zO0UBn/6dqFrLfradXs1MigNjSvyWUItrOSaXPxt4R2iKhndGyS8k1Vw1YvVncLK52qgBtBkV280X5w1WT+lnj1C8bBd8y5URxjgT0YKj0obFt60UFIYAXB0g6l98oeaj01Pd4eZYKjpacQ2tOcpe0p8B3RhX9JgLc55dfUdONRHnWFQoATifBRIysxdgLqc3jDYlGKl101UYzDgn3VuxE0dKT6Q/PRQiKAlyYMPEGUhluAOKdNRBgaamuOfyuTcKooERV4n2NY8+e+fD6lM/UKi1mcEdVWIl/LleEYj7qQ9ZaTk0rfZiPAi2bXcVLHLL2cyskV8PBFkLqfrwzTa4NdLqKtEXknhal1YcR8mVY+QnFmVY9leeokiocII0seHtZ6jmTUbByruCBaIMEn5BZEVv1xWgvYTEILfO4Em52RdAn+BUwZ7z4n4F6tyzK/jDQHY8QS+lbH9GowQg+Tc7UL
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4217.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(6506007)(55016003)(38070700005)(7696005)(54906003)(91956017)(66476007)(166002)(316002)(66946007)(186003)(83380400001)(66556008)(66446008)(64756008)(508600001)(82960400001)(966005)(21615005)(71200400001)(38100700002)(44832011)(6916009)(86362001)(122000001)(76116006)(2906002)(5660300002)(8676002)(4326008)(52536014)(8936002)(9326002)(9686003)(33656002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y0Ehugq0z9Ifu64c6BnE/o6k8trUKbJid5pGcs0kDzeSAvs4u+K73KqN8oFs?= =?us-ascii?Q?f5u6XFQmlOQ1npo8A89veh7wFt9kPkH6+CrNC28HD4fH3U0ovTIKBTmViN2Y?= =?us-ascii?Q?0CTaNb50nxAhHDtpmC+JNvMKOsAG0pq/tih4tHf+sq1SO0q0vl/+dZGmWuF9?= =?us-ascii?Q?6eDiXQ5BF3wvyGqEavyLBkBYxLtb2HVzhqYPvrRVYn10IqE/IPuHC/f/8luE?= =?us-ascii?Q?1A5YKElGOdCRiSq1WzEfjXjhScc0jXImaChYeZ5zrsD9Q3fWiciruE3l4ua5?= =?us-ascii?Q?NqHcEi4QVVlvac65LcJtSUFW5rFzWRANOx9o4ogc94soBHj9l0Q1nJY4DOLW?= =?us-ascii?Q?cVW0TsK+8zRN/qEq8ibFsP+h2BeuBJ0e7NCtJXNmRc5A6apWU2O6RreJ2vil?= =?us-ascii?Q?dOfOUnAYQoik5IQXZMLp1E7EwivEKl6gmj5jgYvlxy7upkm5/g3X4NuSbjUt?= =?us-ascii?Q?SygrfRy3j8ChzQpebZKGgaPzrlvzMXHXbDMtRHpjIPOelzSCMQC4lxTyPrVV?= =?us-ascii?Q?rLFjMV5T2NxmjbssXV08KRn9oHDTq4FsfTyIiXSh0Knr8XUx9wj3kOhXIBR4?= =?us-ascii?Q?C5+D8Z7kJxbQep/2+EmI78EvFQ5aejJxW4hTh2N0Boj9tk5wcUq04rQOweI9?= =?us-ascii?Q?091IPjogg4uzqik2tfaYMByU2hpau64+3TqnsVGITc//2LyCEKz997s38KlM?= =?us-ascii?Q?Yvzu/Wk9etxxD/Bycf711rf4euEI35iIuQD2fpdxEezNAPaarLN1k6BByaZ6?= =?us-ascii?Q?3nQWT61LW/t43ZflXOB1vpq+yfOyYgeNhSQmlq7tQf5snnEsaNn3t5+B+/Sg?= =?us-ascii?Q?qFuSobay5cwp9uwxUJOFZCEM22JZl7EyWGvxqirtDE6trYEsFpQPGNpFM42Z?= =?us-ascii?Q?O6Rahtr0bdAxCr2+OD1LglbhQzI2jwl8tiYXebYFTTNp+tL7++tngPH+YUPf?= =?us-ascii?Q?7M3by+YxRP+PdMOUsCYe25DqlhRdQjiXLDyhuansBGZEodyEHY8hseInqFHC?= =?us-ascii?Q?TXxJ535Q4SfD2egn5SaX7s5zMXnmG752yVo5UjYxHbKUjYUtlVPdapjC/6lL?= =?us-ascii?Q?tp0mcry2vQPpBlofU+SBDgojlUo4QkRFzwgJozUkBY0zl867wbvlbsvp+qwI?= =?us-ascii?Q?xXIJa9f7KAyl8wVcMhT3jZajqGSi0mG7nvfHxNVUWYIvB6gxfs7r7+RfCSJy?= =?us-ascii?Q?AXFEGoTPl1K7D2pH6TO3/tzgsIjDKdeH9+je7p824y/b4b3VXqqaF/TFURKE?= =?us-ascii?Q?T1lGHbujUkDykc63N5tRQqkg3LqNgwbcyHSp9Sph7tXRaXsdNvgVilyqQNxk?= =?us-ascii?Q?MtQQSiF74GAjftD0f/d12TPxNRWIh79SDmoJnxZe9jS1OpBa53Qt9Gy/WdMP?= =?us-ascii?Q?QDQ2hPyRR0kLTff0yWtATrfCQ2+OpNPshwlDM+lrThmBMl5JWCvRnUlBp8rE?= =?us-ascii?Q?lT3fOep67Ra1ya0z4av8ZFmWa3VFPf9v3jZOTK+fTvczk1SSpZKuGjqkHdUu?= =?us-ascii?Q?fKMnMZIo/mmJ9qq04RGdmDkmiQUbRj22WuWpAndzp1SONWuQzTtekCpf5vNL?= =?us-ascii?Q?ZfCMfTxpnUAVRbQt2Cru9S1NplEqjNT5ZJVpMim7cz0LCu+LgapzYcuuL7v7?= =?us-ascii?Q?PD1p1u0bkgPaLlisNtuPv/dOA4RR6pij1UO8/9/1qsBgkh1SF9U58U/WajsO?= =?us-ascii?Q?fnfEOXB3ApviqCMTQ0LkZ2tqNkNW3vgJyrj+tSzXWlBIph8G/3kg8bq0rPvQ?= =?us-ascii?Q?t+oyhXiPQY4YjTVsGrfFJKLmC5sVyIEavMSkhL8cVJwzXhBM/Z90qTNA4+M4?=
x-ms-exchange-antispam-messagedata-1: S79j19o4MP4NLahwUBCw55UfDPsNdowX1z8=
Content-Type: multipart/alternative; boundary="_000_HE1PR07MB4217E821C8FCE81BAAEF7C0A98709HE1PR07MB4217eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4217.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56810b15-2306-4156-9610-08d9bb36f15e
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 17:11:30.0122 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j1sV7MEbJiP4oGT1bb5ouIppPPiU4jzLUpuNyH3czHzyyXLiK07fJoSh+Cw6gAg5eS9roR7ri5WaMrT6MdXuuUfNu2msGqx6OF/mfrq1OujDoWxa5A7sjvve+lsRrOgy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB4298
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/r-PWf0GtvNsTHI5g7lh_v9pWSrU>
Subject: Re: [Ntp] Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2021 17:11:40 -0000

Hi Dhruv,

Thanks for the update! It all looks good to me, I will remove my DISCUSS as soon as the new version is uploaded.

Thanks,
Francesca

From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thursday, 9 December 2021 at 17:59
To: Francesca Palombini <francesca.palombini@ericsson.com>
Cc: The IESG <iesg@ietf.org>rg>, draft-ietf-ntp-yang-data-model@ietf.org <draft-ietf-ntp-yang-data-model@ietf.org>rg>, ntp-chairs@ietf.org <ntp-chairs@ietf.org>rg>, NTP WG <ntp@ietf.org>rg>, Dieter Sibold <dsibold.ietf@gmail.com>
Subject: Re: Francesca Palombini's Discuss on draft-ietf-ntp-yang-data-model-15: (with DISCUSS and COMMENT)
Hi Francesca,

Firstly let me apologize for this very late reply. Secondly thanks for your review. I was finally able to make all the changes.

On Wed, Jun 30, 2021 at 9:45 PM Francesca Palombini via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>> wrote:
Francesca Palombini has entered the following ballot position for
draft-ietf-ntp-yang-data-model-15: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html<https://protect2.fireeye.com/v1/url?k=31323334-501d5122-fe22d327-454445555731-bb14cec5df0b3a0e&q=1&e=0-dbf36cfba4fb1321942c93a8f7c87d31&u=https%3A%2F%2Fwww.ietf.org%2Fiesg%2Fstatement%2Fdiscuss-criteria.html>
for more information about DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-ntp-yang-data-model/<https://protect2.fireeye.com/v1/url?k=31323334-501d5122-fe22d327-454445555731-08e23231aefba629&q=1&e=0-dbf36cfba4fb1321942c93a8f7c87d31&u=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-ietf-ntp-yang-data-model%2F>



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

Thank you for the work on this document.

I have a simple-to-solve DISCUSS point, and some non blocking comments.

Francesca


1. -----

        leaf clock-precision {
          type int8;
          units "Hz";

FP: I believe the units should be seconds here.

Dhruv: The Hz was incorrect. BTW I am using a new typedef log2seconds now (as per Ben's DISCUSS).



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

2. -----

  typedef ntp-date-and-time {
    type union {
      type yang:date-and-time;
      type uint8;
    }
    description
      "Follows the normal date-and-time format when valid value
       exist, otherwise allows for setting special value such as
       zero.";

FP: I'd rather the document avoided the term "normal", which could be just
removed. Also, could a 'reference' be added, pointing to RFC 6991?

Dhruv: Agreed and updated.


3. -----

        "The association was configured or dynamic
         which result in clock synchronization.";

FP: This sentence doesn't parse correctly for me. Is there any text missing? Or
maybe a wrong copy paste?

Dhruv: Updated to - "Indicates if the association (that resulted in the clock synchronization) is explicitly configured."


4. -----

      description
        "Configuration to control access to NTP service
         by using NTP access-group feature.
         The access-mode identifies how the acl is
         applied with NTP.";

FP: (here and other places) please make sure the capitalization of ACL is
consistent in the descriptions and in the text of the doc.

Dhruv: Ack.

Thanks!
Dhruv

Diff: https://www.ietf.org/rfcdiff?url1=draft-ietf-ntp-yang-data-model-15&url2=https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt<https://protect2.fireeye.com/v1/url?k=31323334-501d5122-fe22d327-454445555731-a13f81f1d2c92697&q=1&e=0-dbf36cfba4fb1321942c93a8f7c87d31&u=https%3A%2F%2Fwww.ietf.org%2Frfcdiff%3Furl1%3Ddraft-ietf-ntp-yang-data-model-15%26url2%3Dhttps%3A%2F%2Fraw.githubusercontent.com%2Fdhruvdhody%2Fietf%2Fmaster%2Fdraft-ietf-ntp-yang-data-model-16.txt>
Working Copy: https://raw.githubusercontent.com/dhruvdhody/ietf/master/draft-ietf-ntp-yang-data-model-16.txt<https://protect2.fireeye.com/v1/url?k=31323334-501d5122-fe22d327-454445555731-b1568e82014e9cd1&q=1&e=0-dbf36cfba4fb1321942c93a8f7c87d31&u=https%3A%2F%2Fraw.githubusercontent.com%2Fdhruvdhody%2Fietf%2Fmaster%2Fdraft-ietf-ntp-yang-data-model-16.txt>
Consolidated Review Status: https://notes.ietf.org/draft-ietf-ntp-yang-data-model<https://protect2.fireeye.com/v1/url?k=31323334-501d5122-fe22d327-454445555731-1a425099e82ddf55&q=1&e=0-dbf36cfba4fb1321942c93a8f7c87d31&u=https%3A%2F%2Fnotes.ietf.org%2Fdraft-ietf-ntp-yang-data-model>