Re: [OAUTH-WG] OAuth Security Topics -- Recommend authorization code instead of implicit

Nat Sakimura <n-sakimura@nri.co.jp> Wed, 28 November 2018 23:33 UTC

Return-Path: <sakimura@gmail.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB962131095 for <oauth@ietfa.amsl.com>; Wed, 28 Nov 2018 15:33:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.648
X-Spam-Level:
X-Spam-Status: No, score=-1.648 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5RsqvnaH97Qd for <oauth@ietfa.amsl.com>; Wed, 28 Nov 2018 15:33:49 -0800 (PST)
Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC15213109A for <oauth@ietf.org>; Wed, 28 Nov 2018 15:33:48 -0800 (PST)
Received: by mail-wm1-f50.google.com with SMTP id s14so404674wmh.1 for <oauth@ietf.org>; Wed, 28 Nov 2018 15:33:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncedDVhsjxNzrR0SFwPptlVe4TeNXY6DUqViaKuAdJo=; b=bKPAnMxyQpSv8cJCAoFgYpHcOrZ2yBPWst2b34LHIDm5pDOzc90IpeOyHiISHBq+k9 0vdLL47DciGJLbxkRAOrwBDatModkbRe6t62Oo/9sfs4L2an5MrjmLVllPul5SFXCdg+ zUCjkVzGBkG4JRD0czRgBo9Kc74emvZrc86MzgZURcmZ3UpYx8ukCZv34MVKemWfGr8o R1f9kTnffEpYrMOvehd347/RaQTgpghhlzURGOr62Z8r7D+y1PvcXTkuYLXZnzRkk2Ht Ak3Nwe3tUqy5nOLZPNg6YRYYscc7HGDi6U784+Oigmu+tA9COknQmwGMEKhqD5BovN99 gNEw==
X-Gm-Message-State: AA+aEWY0tFADV/1Y2B8vJ7mKt+3RTwiboRMLBxh9jDaGjLzDxU/Ty7T+ 4kBTg7ybDZ5PQgcjSIb0/5poaiTnuGMy9UAGpZv5hdlm
X-Google-Smtp-Source: AFSGD/VavCkEG4pqSDgzNMnfbYUGUBbsEWwi0jWjdWq5xXa9c4dqjMT6kkD2k3vRWaAmVqdinwDWeKjQevFESqYkQcg=
X-Received: by 2002:a1c:164a:: with SMTP id 71mr4370531wmw.126.1543448026815; Wed, 28 Nov 2018 15:33:46 -0800 (PST)
MIME-Version: 1.0
References: <VI1PR0801MB211266BA6F6E06FFB3081425FAD80@VI1PR0801MB2112.eurprd08.prod.outlook.com> <CAD9ie-v3onmKc498cg_-a0AD58ZV=aZANtz=UV+Q0f=9N3nSzQ@mail.gmail.com> <OSBPR01MB2869E83F37046C7FCD4463DDF9D10@OSBPR01MB2869.jpnprd01.prod.outlook.com> <9FF3F589-0423-4CBC-B323-481F771D097C@lodderstedt.net> <OSBPR01MB28690F77DFFB2A85BDB83FBAF9D10@OSBPR01MB2869.jpnprd01.prod.outlook.com> <D6C66E6A-687B-4997-B830-980BE25994C2@lodderstedt.net>
In-Reply-To: <D6C66E6A-687B-4997-B830-980BE25994C2@lodderstedt.net>
From: Nat Sakimura <n-sakimura@nri.co.jp>
Date: Thu, 29 Nov 2018 00:33:34 +0100
Message-ID: <CABzCy2AhbXCQcx_JtGFMW1M3fLBmm48_gErn3966X+MwRWaceA@mail.gmail.com>
To: Torsten Lodderstedt <torsten@lodderstedt.net>
Cc: "oauth@ietf.org" <oauth@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005e2239057bc1fff9"
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/BRKOlM-_tVVotlwpAyPyromka18>
Subject: Re: [OAUTH-WG] OAuth Security Topics -- Recommend authorization code instead of implicit
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 23:33:52 -0000

Inline:

2018年11月29日(木) 0:03 Torsten Lodderstedt <torsten@lodderstedt.net>:

>
> > Am 28.11.2018 um 23:50 schrieb n-sakimura <n-sakimura@nri.co.jp>:
> >
> > That works.
>
> Good!
>
> I just realized this text has an issue with „token“ (only). It would allow
> „token“ to be used if the token would sender constrained. This completely
> ignores the fact implicit also shall be abandoned because of its
> vulnerability for access token injection.
>
> I therefore propose a modified text:
>
>    In order to avoid these issues, Clients SHOULD NOT use the implicit
>    grant. Furthermore, clients SHOULD only use other response types
> causing the authorization server to
>    issue an access token in the authorization response, if the particular
> response type detects access token
>    injection and the issued access tokens are sender-constrained.


A friendly amendment.

In order to avoid these issues, clients SHOULD NOT return access token in
the authorization response unless the particular response type detects
access token injection and the issued access tokens are sender-constrained.



>
> Or we just state:
>
>   In order to avoid these issues, Clients SHOULD NOT use the response type
> „token". The response types
> „token id_token“ and „code token id_token“ SOULD NOT be used, if the
> issued access tokens are not
> sender-constrained.


This one looks on the surface but as John points out, it misses out the
cases where response types are expanded.


>
> >
> > In fact, I would further go and say MUST NOT but that probably is too
> much for a security consideration.
> >
>
> Mike suggested to go with a SHOULD NOT to get the message out but give
> implementors time to move/change.


As William says, I actually advocate MUST NOT but OK with SHOULD NOT as
well.

>
>
> > Best,
> >
> > Nat
> >
> > Nat Sakimura / n-sakimura@nri.co.jp / +81-90-6013-6276
> >
> >
> このメールには、本来の宛先の方のみに限定された機密情報が含まれている場合がございます。お心あたりのない場合は、誠に申し訳ございませんが、送信者までお知らせ頂き、また受信されたメールは削除してくださいますようお願い申し上げます。
> >
> > PLEASE READ :This e-mail is confidential and intended for the named
> recipient only.
> > If you are not an intended recipient, please notify the sender and
> delete this e-mail.
> >
> > 差出人: Torsten Lodderstedt <torsten@lodderstedt.net>
> > 送信日時: 水曜日, 11月 28, 2018 11:38 午後
> > 宛先: n-sakimura
> > Cc: Dick Hardt; Hannes Tschofenig; oauth@ietf.org
> > 件名: Re: [OAUTH-WG] OAuth Security Topics -- Recommend authorization code
> instead of implicit
> >
> > Hi Nat,
> >
> >> Am 28.11.2018 um 21:10 schrieb n-sakimura <n-sakimura@nri.co.jp>:
> >>
> >> I would support
> >>
> >> 1) clearly defining Implicit as the flow that returns access token from
> the authorization endpoint ( some people confuses implicit as the flow that
> returns ID Token in the front channel)
> >
> > That’s the current text:
> >
> > In order to avoid these issues, Clients SHOULD NOT use the implicit
> >    grant or any other response type causing the authorization server to
> >    issue an access token in the authorization response.
> >
> > What would you like to modify?
> >
> >>
> >> 2) Banning the returning of the access token that are not sender
> constrained from the authorization endpoint
> >
> > In order to avoid these issues, Clients SHOULD NOT use the implicit
> >    grant or any other response type causing the authorization server to
> >    issue an access token in the authorization response, if this access
> tokens is not sender-constraint.
> >
> > What about this?
> >
> > kind regards,
> > Torsten.
> >
> >>
> >> Best,
> >>
> >> Nat
> >>
> >>
> >> Outlook for iOS を入手
> >>
> >> 差出人: OAuth <oauth-bounces@ietf.org> (Dick Hardt <dick.hardt@gmail.com>
> の代理)
> >> 送信日時: 水曜日, 11月 28, 2018 8:58 午後
> >> 宛先: Hannes Tschofenig
> >> Cc: oauth@ietf.org
> >> 件名: Re: [OAUTH-WG] OAuth Security Topics -- Recommend authorization
> code instead of implicit
> >>
> >> +1
> >>
> >> While there are various mechanisms to alleviate some of the issues of
> implicit, I don't think we can recommend specifics, and there may be future
> ones in the future. I think we all agree that implicit without any
> mitigation is problematic.
> >>
> >> How about we recommend against using implicit alone?
> >>
> >>
> >> On Mon, Nov 19, 2018 at 2:34 AM Hannes Tschofenig <
> Hannes.Tschofenig@arm.com> wrote:
> >> Hi all,
> >>
> >> The authors of the OAuth Security Topics draft came to the conclusion
> that it is not possible to adequately secure the implicit flow against
> token injection since potential solutions like token binding or JARM are in
> an early stage of adoption. For this reason, and since CORS allows
> browser-based apps to send requests to the token endpoint, Torsten
> suggested to use the authorization code instead of the implicit grant in
> call cases in his presentation (see
> https://datatracker.ietf.org/meeting/103/materials/slides-103-oauth-sessb-draft-ietf-oauth-security-topics-01
> ).
> >>
> >> A hum in the room at IETF#103 concluded strong support for his
> recommendations. We would like to confirm the discussion on the list.
> >>
> >> Please provide a response by December 3rd.
> >>
> >> Ciao
> >>
> >> Hannes & Rifaat
> >>
> >>
> >>
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
> >> _______________________________________________
> >> OAuth mailing list
> >> OAuth@ietf.org
> >> https://www.ietf.org/mailman/listinfo/oauth
> >> _______________________________________________
> >> OAuth mailing list
> >> OAuth@ietf.org
> >> https://www.ietf.org/mailman/listinfo/oauth
> >
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>
-- 
Nat Sakimura (=nat)
http://www.sakimura.org/en/
http://twitter.com/_nat_en