Re: [OAUTH-WG] [Openid-specs-ab] OAuth Security Topics -- Recommend authorization code instead of implicit

Torsten Lodderstedt <torsten@lodderstedt.net> Tue, 27 November 2018 21:03 UTC

Return-Path: <torsten@lodderstedt.net>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53C85130DF4 for <oauth@ietfa.amsl.com>; Tue, 27 Nov 2018 13:03:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Level:
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ViQuMi-8QG-D for <oauth@ietfa.amsl.com>; Tue, 27 Nov 2018 13:03:33 -0800 (PST)
Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de [80.67.31.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B3521130DCF for <oauth@ietf.org>; Tue, 27 Nov 2018 13:03:33 -0800 (PST)
Received: from [91.13.153.47] (helo=[192.168.71.126]) by smtprelay02.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from <torsten@lodderstedt.net>) id 1gRkW1-0000S1-LM; Tue, 27 Nov 2018 22:03:29 +0100
Content-Type: multipart/signed; boundary="Apple-Mail-A89EA627-DF30-485F-B8B9-F18FDD98C549"; protocol="application/pkcs7-signature"; micalg="sha-256"
Mime-Version: 1.0 (1.0)
From: Torsten Lodderstedt <torsten@lodderstedt.net>
X-Mailer: iPad Mail (16B92)
In-Reply-To: <99e3a87e-1904-b756-d3c2-936ea5bb5b6e@ve7jtb.com>
Date: Tue, 27 Nov 2018 22:03:28 +0100
Cc: "openid-specs-ab@lists.openid.net Ab" <openid-specs-ab@lists.openid.net>, Nat Sakimura <sakimura@gmail.com>, oauth <oauth@ietf.org>, Jim Manico <jim@manicode.com>
Content-Transfer-Encoding: 7bit
Message-Id: <02FFD6C6-1EDB-460D-BB6E-7975362DD377@lodderstedt.net>
References: <VI1PR0801MB211266BA6F6E06FFB3081425FAD80@VI1PR0801MB2112.eurprd08.prod.outlook.com> <5494f764-2d14-089a-8fe8-132a65e32d5e@manicode.com> <8935ff0f-aeab-c773-5e2d-6fedcc29119d@connect2id.com> <CABzCy2D0JAr-C1-jTcodpBdoUNx1We3JDg-PMcsOBL1Ga_m-Hw@mail.gmail.com> <2297d085-28f2-15dd-6dba-937dce9f2122@manicode.com> <CABzCy2AW0dvmEqfHgd=-ULdYSxnUXwrz6jiCBpKw7MQSu-YFbA@mail.gmail.com> <327B68FD-9449-4809-A3B8-BC79C5B1D42C@lodderstedt.net> <CAANoGhK9cYS8NFrpwczVsifz7pdraqOZpBoDHFZkg_qKdj4Vqg@mail.gmail.com> <E7BA53F0-B925-4C47-9C41-CFBC0EB36D18@lodderstedt.net> <99e3a87e-1904-b756-d3c2-936ea5bb5b6e@ve7jtb.com>
To: John Bradley <ve7jtb@ve7jtb.com>
X-Df-Sender: dG9yc3RlbkBsb2RkZXJzdGVkdC5uZXQ=
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/zc4Rczk5xK98USkNcqFuPXGbAUE>
Subject: Re: [OAUTH-WG] [Openid-specs-ab] OAuth Security Topics -- Recommend authorization code instead of implicit
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2018 21:03:38 -0000

I still don’t understand why the use case must be solved using a flow issuing something in the front channel. 

I would also like to take a closer look. Can you or Nat provide pointers to existing implementations? 

> Am 27.11.2018 um 21:36 schrieb John Bradley <ve7jtb@ve7jtb.com>:
> 
> I understand that, but hat is Nat's concern as I understand it.
> 
> When we say no implicit people, have a problem because implicit is imprecise.
> 
> We are saying no AT returned in the response from the authorization endpoint.
> 
> Nat points out that id_token may contain AT for the self issued client.
> 
> So unless we say that is OK if the AT are sender constrained we wind up implying that a OpenID profile of OAuth is in violation of the BCP.
> 
> I am just trying to make sure everyone is on the same page with why Nat was -1.
> 
> It really has nothing to do with the SPA use case.
> 
> John B.
> 
>> On 11/27/2018 5:28 PM, Torsten Lodderstedt wrote:
>> Hi John,
>> 
>> as you said, self issued IDPs (https://openid.net/specs/openid-connect-core-1_0.html#SelfIssued) are supposed to provide the response type „id_token“ only. I don’t think the proposal being discussed here is related to this OIDC mode.
>> 
>> best regards,
>> Torsten.
>> 
>>> Am 27.11.2018 um 20:54 schrieb John Bradley <ve7jtb@ve7jtb.com>:
>>> 
>>> I talked to Nat about this a bit today.
>>> 
>>> The thing he is concerned about is mostly around the self issued IDP that doesn't have a token endpoint(atleast not easaly).
>>> 
>>> The main use case for that is the id_token response type where claims are retuned in the id_token.
>>> 
>>> Because it is fragment encoded some people call that implicit.   That is not what we are trying to stop.
>>> 
>>> In some cases in that flow there may be distributed claims returned with access Token inside the id_token.    I think most people would agree that those should be pop or sender constrained tokens.
>>> 
>>> In the case of self issued the RP would be a server and could do sender constrained via some mechinisim that is yet to be defined.
>>> 
>>> So if someone wanted to return a access token in a id_token to do distributed claims I don't think we have a problem with that as long as the token is protected by being sender constrained in some reasonable way.
>>> 
>>> This is a touch hypothetical from the basic OAuth perspective, so I don't know how deep we want to go into it.
>>> 
>>> I think the point is not to accidently prohibit something that could be done in future.
>>> 
>>> I also think we should not conflate confidential clients that can authenticate to the token endpoint with sender constrained/PoP clients that can deal with bound tokens.   Yes both have keys but it is better to describe them separately.
>>> 
>>> John B.
>>> 
>>> On Tue, Nov 27, 2018, 4:30 PM Torsten Lodderstedt via Openid-specs-ab <openid-specs-ab@lists.openid.net wrote:
>>> Hi Nat,
>>> 
>>> I understand you are saying your draft could provide clients with an application level mechanism to sender constrain access tokens. That’s great!
>>> 
>>> But I don’t see a binding to response type „token id_token“. Why do you want to expose the tokens via the URL to attackers?
>>> 
>>> You could easily use your mechanism with code. That would also give you the chance to really authenticate the confidential client before you issue the token.
>>> 
>>> kind regards,
>>> Torsten.
>>> 
>>>> Am 27.11.2018 um 16:57 schrieb Nat Sakimura <sakimura@gmail.com>:
>>>> 
>>>> I am not talking about SPA.
>>>> The client is a regular confidential client that is running on a server.
>>>> 
>>>> Best,
>>>> 
>>>> Nat Sakimura
>>>> 
>>>> 
>>>> 2018年11月27日(火) 16:55 Jim Manico <jim@manicode.com>:
>>>> Nat,
>>>> 
>>>> How is proof of possession established in a modern web browser in the implicit flow?
>>>> 
>>>> My understanding is that token binding was removed from Chrome recently effectively killing browser-based PoP tokens.
>>>> 
>>>> https://identiverse.com/2018/10/31/chrome-puts-token-binding-in-a-bind/
>>>> 
>>>> Am I missing something?
>>>> 
>>>> Aloha, Jim
>>>> 
>>>> 
>>>> 
>>>>> On 11/27/18 9:00 PM, Nat Sakimura wrote:
>>>>> I am actually -1.
>>>>> 
>>>>> +1 for public client and the tokens that are not sender/key constrained.
>>>>> 
>>>>> Just not being used right now does not mean that it is not useful.. In fact, I see it coming.
>>>>> Implicit (well, Hybrid “token id_token” really) is very useful in certain cases.
>>>>> Specifically, when the client is confidential (based on public key pair), and uses sender constrained (key-constrained) token such as the one explained in https://tools.ietf.org/html/draft-sakimura-oauth-jpop-04#section-5, it is very useful.
>>>>> (Key-constrained token is the remaining portion of this draft that did not get incorporated in the MTLS draft. )
>>>>> In fact it is the only viable method for Self-Issued OpenID Provider.
>>>>> 
>>>>> So, the text is generally good but it needs to be constrained like “Unless the client is confidential and the access token issued is key constrained, ... “
>>>>> 
>>>>> Best,
>>>>> 
>>>>> Nat Sakimura
>>>>> 
>>>>> 
>>>>> 2018年11月27日(火) 16:01 Vladimir Dzhuvinov <vladimir@connect2id.com>:
>>>>> +1 to recommend the deprecation of implicit.
>>>>> 
>>>>> I don't see a compelling reason to keep implicit when there is an
>>>>> established alternative that is more secure.
>>>>> 
>>>>> Our duty as WG is to give developers the best and most sensible practice.
>>>>> 
>>>>> CORS adoption is currently at 94% according to
>>>>> https://caniuse.com/#feat=cors
>>>>> 
>>>>> Vladimir
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> OAuth mailing list
>>>>> OAuth@ietf.org
>>>>> https://www.ietf.org/mailman/listinfo/oauth
>>>>> -- 
>>>>> Nat Sakimura (=nat)
>>>>> Chairman, OpenID Foundation
>>>>> http://nat..sakimura.org/
>>>>> @_nat_en
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> OAuth mailing list
>>>>> 
>>>>> OAuth@ietf.org
>>>>> https://www.ietf.org/mailman/listinfo/oauth
>>>> -- 
>>>> Jim Manico
>>>> Manicode Security
>>>> 
>>>> https://www.manicode.com
>>>> -- 
>>>> Nat Sakimura (=nat)
>>>> Chairman, OpenID Foundation
>>>> http://nat.sakimura.org/
>>>> @_nat_en
>>>> _______________________________________________
>>>> OAuth mailing list
>>>> OAuth@ietf.org
>>>> https://www.ietf.org/mailman/listinfo/oauth
>>> _______________________________________________
>>> Openid-specs-ab mailing list
>>> Openid-specs-ab@lists.openid.net
>>> http://lists.openid.net/mailman/listinfo/openid-specs-ab