Re: [OAUTH-WG] Question lengths in draft-sakimura-oauth-tcse-03

Nat Sakimura <sakimura@gmail.com> Fri, 16 May 2014 13:10 UTC

Return-Path: <sakimura@gmail.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7D371A0230 for <oauth@ietfa.amsl.com>; Fri, 16 May 2014 06:10:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6Ir7BgzQFFIh for <oauth@ietfa.amsl.com>; Fri, 16 May 2014 06:10:20 -0700 (PDT)
Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 151B61A005D for <oauth@ietf.org>; Fri, 16 May 2014 06:10:19 -0700 (PDT)
Received: by mail-la0-f53.google.com with SMTP id ec20so1942202lab.12 for <oauth@ietf.org>; Fri, 16 May 2014 06:10:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ogFNVJ8p7+e2sSz6nvpZWVr+l5wV465+sHyo4hTZjdY=; b=sCIrbADhUmFHFX1lIq7jXd+ztIa8k+KNbPQCE0GtN+Mtaf+375nlFk2YByJhwitkUk j42liLAcsKc1tfTa0yB/I4NsYVS5WsLCbN4x2EMPOvDFW5GRM0rH57E2ridx2epQxDvB o/A9dXXpVi1gxumF5pQdPelkIVQ+gJtVudZlReIYwe73Hx4BIbm74Pz0QsT7k8DmLyuy PO5oz/pLHXI+1fYyk/q12VNSiMEnlRdzSGlo2EyvTUOjiCeRM5PsQ3ROSVU/9t6jVSAw BouJhiAac3lmso7CiYeRXmR9y6731t6oCspwqB3g4OQALxj6U5u8/fouJd9+vist30bs E+lQ==
MIME-Version: 1.0
X-Received: by 10.112.158.101 with SMTP id wt5mr1260056lbb.77.1400245811136; Fri, 16 May 2014 06:10:11 -0700 (PDT)
Received: by 10.112.105.134 with HTTP; Fri, 16 May 2014 06:10:11 -0700 (PDT)
In-Reply-To: <CA+k3eCQLdfmY_q3Avjc-FKUUK-wq6gEP-j+YE85dkNnhr5=Y4w@mail.gmail.com>
References: <CA+k3eCTZOheb0HCetS88EXcP-8LJQrYPRuwVcd4NWaWxUAVO1g@mail.gmail.com> <sjm4n0uk8be.fsf@mocana.ihtfp.org> <21A361B0-4E8F-4DAB-9EEB-D48FBCBDFFED@ve7jtb.com> <CA+k3eCQJRymEDERy=3yvioetg-7Tz025gaZJ1FS4DYmkTGRhcQ@mail.gmail.com> <CA+k3eCTguJMR-94-KyfpT2_3kQZQQgH3QV6VwawPLoSnBxqVbQ@mail.gmail.com> <CABzCy2DvNsL79JHcR8LoNd1riaC9_KjTXBO1+xUTfCv2NHCOyA@mail.gmail.com> <CA+k3eCQLdfmY_q3Avjc-FKUUK-wq6gEP-j+YE85dkNnhr5=Y4w@mail.gmail.com>
Date: Fri, 16 May 2014 22:10:11 +0900
Message-ID: <CABzCy2DHTxv6W+u171ZrgBeL0NJZ0jkY33YVWDnsPhuCZfJ26g@mail.gmail.com>
From: Nat Sakimura <sakimura@gmail.com>
To: Brian Campbell <bcampbell@pingidentity.com>
Content-Type: multipart/alternative; boundary="001a11c33f702bd24604f984221a"
Archived-At: http://mailarchive.ietf.org/arch/msg/oauth/RAvnnTgrpntgI_KHaLW530TnA50
Cc: oauth <oauth@ietf.org>, Naveen Agarwal <naa@google.com>
Subject: Re: [OAUTH-WG] Question lengths in draft-sakimura-oauth-tcse-03
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 May 2014 13:10:25 -0000

Now that I cannot remember what limit we were hitting, it might be a good
idea to remove the constraint and see if anyone protests.

What do you think?

Nat


2014-05-14 20:46 GMT+09:00 Brian Campbell <bcampbell@pingidentity.com>:

> That too would suggest that the length limit be on code_challenge because
> that's the parameter that will be on URIs getting passed around. The
> code_verifier is sent directly in the POST body from client to AS.
>
>
> On Tue, May 13, 2014 at 12:52 AM, Nat Sakimura <sakimura@gmail.com> wrote:
>
>> +1 for octet. We used to have "bytes" in JW* so I used "bytes" here,
>> while at the same time complaining in Jose that it should be "octet". JW*
>> changed to "octet" but I failed to sync with it in the last few edits.
>>
>> I do not quite remember which platform, but the reason for the limit was
>> that some platform had some limitations as to the length of the sting to be
>> passed to it through URI and we did not want the challenges to be truncated
>> by that limit.
>>
>> Best,
>>
>> Nat
>>
>>
>> 2014-05-13 6:56 GMT+09:00 Brian Campbell <bcampbell@pingidentity.com>:
>>
>> And it'd give the AS some direct guidance on protecting itself from crazy
>>> long code_challenge values rather than relying on the client not to do
>>> something creative.
>>>
>>>
>>> On Mon, May 12, 2014 at 3:54 PM, Brian Campbell <
>>> bcampbell@pingidentity.com> wrote:
>>>
>>>> Right but that's why I'm asking why not just put the limit on
>>>> code_challange rather than inferring it from code_verifyer + challenge
>>>> algorithm, which probably bounds it but doesn't necessarily do so? It's not
>>>> a big deal but would read more clearly, I think.
>>>>
>>>>
>>>> On Mon, May 12, 2014 at 3:48 PM, John Bradley <ve7jtb@ve7jtb.com>wrote:
>>>>
>>>>> I think octets is more consistent with other JW* and OAuth specs.
>>>>>
>>>>> The code_challange is the same length as the code_verifyer or is a
>>>>> hash of the code_verifyer so likely smaller than 128octets (43 ish for
>>>>> base64 256 bit)
>>>>>
>>>>> Limiting the code_verifyer size sets the upper bound for
>>>>> code_challange, unless someone comes up with a really creative code
>>>>> challenge algorithm.
>>>>>
>>>>> I will talk to nat about changing it to octets when I see him tomorrow.
>>>>>
>>>>> John B.
>>>>>
>>>>> On May 12, 2014, at 11:15 PM, Derek Atkins <warlord@MIT.EDU> wrote:
>>>>>
>>>>> > Brian Campbell <bcampbell@pingidentity.com> writes:
>>>>> >
>>>>> >> I notice that code_verifier is defined as "high entropy
>>>>> cryptographic random
>>>>> >> string of length less than 128 bytes"  [1], which brought a few
>>>>> questions and
>>>>> >> comments to mind. So here goes:
>>>>> >>
>>>>> >> Talking about the length of a string in terms of bytes is always
>>>>> potentially
>>>>> >> confusing. Maybe characters would be an easier unit for people like
>>>>> me to wrap
>>>>> >> their little brains around?
>>>>> >
>>>>> > It depends if it really is characters or bytes.  For example there
>>>>> are
>>>>> > many multi-byte UTF-8 characters, so if it really is bytes then
>>>>> saying
>>>>> > characters is wrong because it could overflow.  So let's make sure we
>>>>> > know what we're talking about.  Historically, if we're talking bytes
>>>>> the
>>>>> > IETF often uses the phrase "octets".  Would that be less confusing?
>>>>> >
>>>>> >> Why are we putting a length restriction on the code_verifier
>>>>> anyway? It seems
>>>>> >> like it'd be more appropriate to restrict the length of the
>>>>> code_challenge
>>>>> >> because that's the thing the AS will have to maintain somehow
>>>>> (store in a DB
>>>>> >> or memory or encrypt into the code). Am I missing something here?
>>>>> >>
>>>>> >> Let me also say that I hadn't looked at this document since its
>>>>> early days in
>>>>> >> draft -00 or -01 last summer but I like the changes and how it's
>>>>> been kept
>>>>> >> pretty simple for the common use-case while still allowing for
>>>>> crypto agility/
>>>>> >> extension. Nice work!
>>>>> >>
>>>>> >> [1]
>>>>> http://tools.ietf.org/html/draft-sakimura-oauth-tcse-03#section-3.3
>>>>> >
>>>>> > -derek
>>>>> >
>>>>> >> _______________________________________________
>>>>> >> OAuth mailing list
>>>>> >> OAuth@ietf.org
>>>>> >> https://www.ietf.org/mailman/listinfo/oauth
>>>>> >
>>>>> > --
>>>>> >       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>>>>> >       Member, MIT Student Information Processing Board  (SIPB)
>>>>> >       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>>>>> >       warlord@MIT.EDU                        PGP key available
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>    [image: Ping Identity logo] <https://www.pingidentity.com/>
>>>> Brian Campbell
>>>> Portfolio Architect
>>>>   @ bcampbell@pingidentity.com  [image: phone] +1 720.317.2061  Connect
>>>> with us…  [image: twitter logo] <https://twitter.com/pingidentity> [image:
>>>> youtube logo] <https://www.youtube.com/user/PingIdentityTV> [image:
>>>> LinkedIn logo] <https://www.linkedin.com/company/21870> [image:
>>>> Facebook logo] <https://www.facebook.com/pingidentitypage> [image:
>>>> Google+ logo] <https://plus.google.com/u/0/114266977739397708540> [image:
>>>> slideshare logo] <http://www.slideshare.net/PingIdentity> [image:
>>>> flipboard logo] <http://flip.it/vjBF7> [image: rss feed icon]<https://www.pingidentity.com/blogs/>
>>>>    [image: Register for Cloud Identity Summit 2014 | Modern Identity
>>>> Revolution | 19–23 July, 2014 | Monterey, CA]<https://www.cloudidentitysummit.com/>
>>>>
>>>>
>>>
>>>
>>> --
>>>    [image: Ping Identity logo] <https://www.pingidentity.com/>
>>> Brian Campbell
>>> Portfolio Architect
>>>   @ bcampbell@pingidentity.com  [image: phone] +1 720.317.2061  Connect
>>> with us…  [image: twitter logo] <https://twitter.com/pingidentity> [image:
>>> youtube logo] <https://www.youtube.com/user/PingIdentityTV> [image:
>>> LinkedIn logo] <https://www.linkedin.com/company/21870> [image:
>>> Facebook logo] <https://www.facebook.com/pingidentitypage> [image:
>>> Google+ logo] <https://plus.google.com/u/0/114266977739397708540> [image:
>>> slideshare logo] <http://www.slideshare.net/PingIdentity> [image:
>>> flipboard logo] <http://flip.it/vjBF7> [image: rss feed icon]<https://www.pingidentity.com/blogs/>
>>>    [image: Register for Cloud Identity Summit 2014 | Modern Identity
>>> Revolution | 19–23 July, 2014 | Monterey, CA]<https://www.cloudidentitysummit.com/>
>>>
>>>
>>> _______________________________________________
>>> OAuth mailing list
>>> OAuth@ietf.org
>>> https://www.ietf.org/mailman/listinfo/oauth
>>>
>>>
>>
>>
>> --
>> Nat Sakimura (=nat)
>> Chairman, OpenID Foundation
>> http://nat.sakimura.org/
>> @_nat_en
>>
>
>
>
> --
>    [image: Ping Identity logo] <https://www.pingidentity.com/>
> Brian Campbell
> Portfolio Architect
>   @ bcampbell@pingidentity.com  [image: phone] +1 720.317.2061  Connect
> with us…  [image: twitter logo] <https://twitter.com/pingidentity> [image:
> youtube logo] <https://www.youtube.com/user/PingIdentityTV> [image:
> LinkedIn logo] <https://www.linkedin.com/company/21870> [image: Facebook
> logo] <https://www.facebook.com/pingidentitypage> [image: Google+ logo]<https://plus.google.com/u/0/114266977739397708540> [image:
> slideshare logo] <http://www.slideshare.net/PingIdentity> [image:
> flipboard logo] <http://flip.it/vjBF7> [image: rss feed icon]<https://www.pingidentity.com/blogs/>
>    [image: Register for Cloud Identity Summit 2014 | Modern Identity
> Revolution | 19–23 July, 2014 | Monterey, CA]<https://www.cloudidentitysummit.com/>
>
>


-- 
Nat Sakimura (=nat)
Chairman, OpenID Foundation
http://nat.sakimura.org/
@_nat_en