Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02

"Acee Lindem (acee)" <acee@cisco.com> Wed, 23 September 2015 14:37 UTC

Return-Path: <acee@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7CFCE1A6EDE; Wed, 23 Sep 2015 07:37:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFGH7NJh0Cy8; Wed, 23 Sep 2015 07:37:34 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C06FD1A21C4; Wed, 23 Sep 2015 07:37:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=20819; q=dns/txt; s=iport; t=1443019054; x=1444228654; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=iZFEHEsvBg030hjpJOnunj/mTZ7MWoa7usy0sGi0hSI=; b=ECkvdpADJgJGlWUQQnO19bizx8QvIk18BvyY56TW3ydQUANkInCYBMPK 7MThQu04evgIKt2ptD3EoFl2B5wrQO3Xu1Kor25yY9VHHKTlgV5Z1qujJ XQN+lxYB0csCytd7qVYHuNffo7gTfD0bZiGoMEgTq9h0DZ7FaSfpqUnYB M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DwAQDktwJW/5BdJa1dgldNVGkGvU0BDYF8hXcCHIErOBQBAQEBAQEBgQqEJAEBAQQjSxsCAQgOAwMBAigDAgICHxEUCQgCBAESCYgQAxINtxePHQ2EdgEBAQEBAQEDAQEBAQEBARuLcIJQgiwYgmmBQwWSPoMpAYsbgW+BT4Q2jWOHQh8BAUKEAXEBiGeBBQEBAQ
X-IronPort-AV: E=Sophos; i="5.17,577,1437436800"; d="scan'208,217"; a="34501327"
Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by rcdn-iport-2.cisco.com with ESMTP; 23 Sep 2015 14:37:33 +0000
Received: from XCH-ALN-010.cisco.com (xch-aln-010.cisco.com [173.36.7.20]) by rcdn-core-8.cisco.com (8.14.5/8.14.5) with ESMTP id t8NEbWhX026437 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 23 Sep 2015 14:37:32 GMT
Received: from xch-aln-010.cisco.com (173.36.7.20) by XCH-ALN-010.cisco.com (173.36.7.20) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Wed, 23 Sep 2015 09:37:31 -0500
Received: from xhc-aln-x06.cisco.com (173.36.12.80) by xch-aln-010.cisco.com (173.36.7.20) with Microsoft SMTP Server (TLS) id 15.0.1104.5 via Frontend Transport; Wed, 23 Sep 2015 09:37:31 -0500
Received: from xmb-aln-x06.cisco.com ([169.254.1.127]) by xhc-aln-x06.cisco.com ([173.36.12.80]) with mapi id 14.03.0248.002; Wed, 23 Sep 2015 09:37:31 -0500
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Alia Atlas <akatlas@gmail.com>, OSPF List <ospf@ietf.org>, "draft-ietf-ospf-rfc4970bis@ietf.org" <draft-ietf-ospf-rfc4970bis@ietf.org>
Thread-Topic: AD review of draft-ietf-ospf-rfc4970bis-02
Thread-Index: AQHQ9YIst/tfqaD4vUilavXsqepMPZ5KQImA
Date: Wed, 23 Sep 2015 14:37:30 +0000
Message-ID: <D2282E26.3225B%acee@cisco.com>
References: <CAG4d1rf+MsJXVy+G8W8vWjD=P_126cpjAFjr9e-+eCw=KLZzjQ@mail.gmail.com>
In-Reply-To: <CAG4d1rf+MsJXVy+G8W8vWjD=P_126cpjAFjr9e-+eCw=KLZzjQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [173.36.7.24]
Content-Type: multipart/alternative; boundary="_000_D2282E263225Baceeciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/Cqp_TsjW2Ox8Sr2LwFde4TIa8c8>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Sep 2015 14:37:36 -0000

Hi Alia,

From: Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>
Date: Tuesday, September 22, 2015 at 6:00 PM
To: OSPF WG List <ospf@ietf.org<mailto:ospf@ietf.org>>, "draft-ietf-ospf-rfc4970bis@ietf.org<mailto:draft-ietf-ospf-rfc4970bis@ietf.org>" <draft-ietf-ospf-rfc4970bis@ietf.org<mailto:draft-ietf-ospf-rfc4970bis@ietf.org>>
Subject: AD review of draft-ietf-ospf-rfc4970bis-02

As is customary, I have done my AD review of draft-ietf-ospf-rfc4970bis-02.  First, let me thank Acee for his work on this draft.

I have two major concerns before asking for an IETF Last Call.  I would like to have them
resolved by this Thursday so that the draft can make the Oct 15 IESG telechat.

First, from a process concern, I do not see any active discussion on the OSPF mailing list - even to simply say "yes - go forward".  I don't see anything about this draft or discussion in minutes for IETF 92 or IETF 93.   I'd prefer some indication besides silence and lack of opposition.  I do realize that there are some process or protocol-tidying drafts where there isn't
much interest.  However, I am particularly concerned because this is changing RFC4970 is a way that should be backwards compatible but might trigger issues.   I would encourage WG participants to PLEASE RESPOND!

Second, I can see the intent that by creating an Opaque ID and creating a special meaning for 0, the draft is making efforts to preserve backwards compatibility.  Please add a paragraph or subsection that articulates how and why backwards compatibility isn't an issue.

I will add more on this.

  For extra credit, what happens if the same TLV information is advertised in multiple RI LSAs (as part of moving it from one RI LSA to another)?

This depends on the context of the TLV. In some cases the router information is additive and in others conflicts need to be resolved.



Are there any implementations of this draft?  Has backwards compatibility been verified at all?

Many implementations of RFC 4970. I don’t know of any implementations that originate multiple RI LSAs. However, with all the proposed OSPF RI LSA usages, I can see them coming.



My minor issue is around the IANA considerations; I have detailed comments below.

Here are additional comments.

1) In Sec 2: "The first Opaque ID, i.e., 0, should always contain the Router
   Informational Capabilities TLV and, if advertised, the Router
   Functional Capabilities TLV."  and Sec 2.2 "The first instance ID, i.e., 0,
   should always contain the Router Informational Capabilities TLV and,
   if advertised, the Router Functional Capabilities TLV."

   Since I assume this is important for backwards compatibility, should those
   be SHOULD instead of should?

Yes.




2) In Sec 2.3: "The first defined TLV in the body of an RI LSA is the Router
   Informational Capabilities TLV."

   Surely that is only for the first Opaque ID=0?  Does each subsequent RI LSA
   also need to contain a Router Informational Capabilities TLV??

No. Will clarify this.



3) In Sec 4 IANA Considerations:  This section is defining the different IANA policies;
when RFC4970 was written, RFC5226 didn't exist.  But since you're doing a bis,
perhaps you can align to the policies in RFC5226 and remove the unnecessary text??

Yes. I think of already done this.


4) In Sec 4 IANA Considerations:  The registry for OSPFv3 LSA Function Codes can
be found at http://www.iana.org/assignments/ospfv3-parameters/ospfv3-parameters.xhtml#ospfv3-parameters-3 and what is in the draft doesn't match up.  I'd settle for defining the ranges, and value 12 - but it's up to you and IANA on the preferences.  Would it make sense to change the policy from Standards Action to IETF Review here also?

Yes - I think this draft should change the policy for OSPFv3 LSA Functions codes since RFC 4970 initially created the registry. If were going to change the policy (and I think we want to do this), it makes sense to do it here from a continuity standpoint.



Same thing applies to the OSPF RI TLVS (http://www.iana.org/assignments/ospfv2-parameters/ospfv2-parameters.xhtml#ospfv2-parameters-9 )   Also here, I think there
was agreement among the 4 of us who commented on the WG mailing list to change this
from Standards Action to IETF Review.

Yes.


5) In Sec 4 IANA Considerations: "All Router Functional Capability TLV
       additions are to be assigned through standards action."   Given the discussion
about IETF Review vs. Standards Action for other registries, are you sure you want
Standards Action?

No  - I will change this.


I'm sure that we'll get this moving along quickly.

Great - will work on this today in preparation for the tomorrow’s telechat.

Thanks,
Acee



Thanks again!
Alia