Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02

Shraddha Hegde <shraddha@juniper.net> Wed, 23 September 2015 07:14 UTC

Return-Path: <shraddha@juniper.net>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2268B1A6F47; Wed, 23 Sep 2015 00:14:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5YN3aAFb8TaH; Wed, 23 Sep 2015 00:14:14 -0700 (PDT)
Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0735.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::735]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B510F1A3B9B; Wed, 23 Sep 2015 00:14:13 -0700 (PDT)
Received: from BY1PR0501MB1381.namprd05.prod.outlook.com (10.160.107.139) by BY1PR0501MB1381.namprd05.prod.outlook.com (10.160.107.139) with Microsoft SMTP Server (TLS) id 15.1.268.17; Wed, 23 Sep 2015 07:13:57 +0000
Received: from BY1PR0501MB1381.namprd05.prod.outlook.com ([10.160.107.139]) by BY1PR0501MB1381.namprd05.prod.outlook.com ([10.160.107.139]) with mapi id 15.01.0268.017; Wed, 23 Sep 2015 07:13:57 +0000
From: Shraddha Hegde <shraddha@juniper.net>
To: "Acee Lindem (acee)" <acee@cisco.com>, Alia Atlas <akatlas@gmail.com>, OSPF List <ospf@ietf.org>, "draft-ietf-ospf-rfc4970bis@ietf.org" <draft-ietf-ospf-rfc4970bis@ietf.org>
Thread-Topic: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02
Thread-Index: AQHQ9YIuF7AC2GUkwUquQUm/GNvTz55JHBkAgAAFkICAAIuowA==
Date: Wed, 23 Sep 2015 07:13:57 +0000
Message-ID: <BY1PR0501MB13819F6D712092D7CED7C42AD5440@BY1PR0501MB1381.namprd05.prod.outlook.com>
References: <CAG4d1rf+MsJXVy+G8W8vWjD=P_126cpjAFjr9e-+eCw=KLZzjQ@mail.gmail.com> <CAG4d1rdxgbao277AuGTjHpwdAZcnu5s9hZu212xuOF+5FxbUyA@mail.gmail.com> <D2274E5B.310EC%acee@cisco.com>
In-Reply-To: <D2274E5B.310EC%acee@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=shraddha@juniper.net;
x-originating-ip: [116.197.184.16]
x-microsoft-exchange-diagnostics: 1; BY1PR0501MB1381; 5:+2fZ309M6a8rBGI0z3lkEG8q5DNSi9vTI90N5bcLvuBN2GzknWdjjccyzioAm6IbM7F9jH5UYa+OrqVY6Td/Qlh/hbXGRJMj5e1AqSw8NeXauB/kyy1+cznuWpZk/HBsUtEDkSfH2s9uqvESUGwcCw==; 24:VQHUzTxVjv/0WJvt9DVcpoaZSkJcOmaBg2dT8LyFKX3pO5sdmgxPZl3VSTglXqqnDASQPPnZ5fcHW9k269zQskSfa+0zoEXCXyexnbQ/UqQ=; 20:W4Fi1oMTni40wWVx/6eLg+4+HF6nEkIUUFSdgIfHrJg3vYm+33Ovh2B2QOKM9pOOlMdG6mWg4MGF0qykif3Y4w==
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0501MB1381;
x-microsoft-antispam-prvs: <BY1PR0501MB13810C5D76DBBD254BB9D6DFD5440@BY1PR0501MB1381.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(95692535739014)(108003899814671);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001); SRVR:BY1PR0501MB1381; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0501MB1381;
x-forefront-prvs: 07083FF734
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(46034005)(164054003)(43784003)(189002)(199003)(377454003)(24454002)(46102003)(19625215002)(33656002)(87936001)(16236675004)(5001770100001)(74316001)(50986999)(5001830100001)(5003600100002)(106116001)(99286002)(76176999)(106356001)(105586002)(19580405001)(19300405004)(19580395003)(76576001)(5001860100001)(4001540100001)(97736004)(81156007)(230783001)(101416001)(5001960100002)(122556002)(40100003)(5002640100001)(107886002)(189998001)(19617315012)(19609705001)(5004730100002)(86362001)(92566002)(11100500001)(2900100001)(5007970100001)(2501003)(2950100001)(66066001)(64706001)(54356999)(10400500002)(102836002)(77096005)(68736005)(15975445007)(62966003)(77156002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR0501MB1381; H:BY1PR0501MB1381.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en;
received-spf: None (protection.outlook.com: juniper.net does not designate permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_BY1PR0501MB13819F6D712092D7CED7C42AD5440BY1PR0501MB1381_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2015 07:13:57.1870 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0501MB1381
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/l-9vcTCj6OFvvgDdi5d60SjtReg>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Sep 2015 07:14:17 -0000

Acee,

I agree that the MT –ID granularity is not required for the informational capability TLV as it  “more of” indicates whether router supports the
Feature or not.

Functional capabilities TLV is newly added in 4970bis. My read is that this TLV can be used to indicate whether the router
Currently has enabled the feature or not and take protocol actions based on this information.
It makes sense to add one functional capability TLV per MT-ID in MT deployments.
When the new features need to use the functional capability  TLV to advertise just their capabilities
and do not have additional information, just a functional capability bit should suffice and no new sub TLV definitions would be needed.
This looks more elegant and is compact from protocol message length perspective.

Having said that, it may be worthwhile to discuss in WG whether we need to consider MT based deployments while
defining the new protocol extensions. In general, there seems to be less interest in deploying multi-topology.

Rgds
Shraddha

From: Acee Lindem (acee) [mailto:acee@cisco.com]
Sent: Wednesday, September 23, 2015 4:01 AM
To: Alia Atlas <akatlas@gmail.com>om>; OSPF List <ospf@ietf.org>rg>; draft-ietf-ospf-rfc4970bis@ietf.org; Shraddha Hegde <shraddha@juniper.net>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02

Hi Alia, Shraddha,

From: OSPF <ospf-bounces@ietf.org<mailto:ospf-bounces@ietf.org>> on behalf of Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>>
Date: Tuesday, September 22, 2015 at 6:10 PM
To: OSPF WG List <ospf@ietf.org<mailto:ospf@ietf.org>>, "draft-ietf-ospf-rfc4970bis@ietf.org<mailto:draft-ietf-ospf-rfc4970bis@ietf.org>" <draft-ietf-ospf-rfc4970bis@ietf.org<mailto:draft-ietf-ospf-rfc4970bis@ietf.org>>
Subject: Re: [OSPF] AD review of draft-ietf-ospf-rfc4970bis-02

Minor correction:

On Tue, Sep 22, 2015 at 6:00 PM, Alia Atlas <akatlas@gmail.com<mailto:akatlas@gmail.com>> wrote:
As is customary, I have done my AD review of draft-ietf-ospf-rfc4970bis-02.  First, let me thank Acee for his work on this draft.

I have two major concerns before asking for an IETF Last Call.  I would like to have them
resolved by this Thursday so that the draft can make the Oct 15 IESG telechat.

First, from a process concern, I do not see any active discussion on the OSPF mailing list - even to simply say "yes - go forward".  I don't see anything about this draft or discussion in minutes for IETF 92 or IETF 93.   I'd prefer some indication besides silence and lack of opposition.  I do realize that there are some process or protocol-tidying drafts where there isn't
much interest.  However, I am particularly concerned because this is changing RFC4970 is a way that should be backwards compatible but might trigger issues.   I would encourage WG participants to PLEASE RESPOND!

In IETF 91 minutes, I see a presentation and question from Shraddha about making it MT capable.  There was no
answer except take it to the list and no follow-up discussion.

My answer would be that not all capabilities are scoped at an MT level of granularity it is incumbent on the definition of those that are to include the MT ID in the definition.

Thanks,
Acee





Am I missing anything?

Regards,
Alia


Second, I can see the intent that by creating an Opaque ID and creating a special meaning for 0, the draft is making efforts to preserve backwards compatibility.  Please add a paragraph or subsection that articulates how and why backwards compatibility isn't an issue.  For extra credit, what happens if the same TLV information is advertised in multiple RI LSAs (as part of moving it from one RI LSA to another)?

Are there any implementations of this draft?  Has backwards compatibility been verified at all?

My minor issue is around the IANA considerations; I have detailed comments below.

Here are additional comments.

1) In Sec 2: "The first Opaque ID, i.e., 0, should always contain the Router
   Informational Capabilities TLV and, if advertised, the Router
   Functional Capabilities TLV."  and Sec 2.2 "The first instance ID, i.e., 0,
   should always contain the Router Informational Capabilities TLV and,
   if advertised, the Router Functional Capabilities TLV."

   Since I assume this is important for backwards compatibility, should those
   be SHOULD instead of should?

2) In Sec 2.3: "The first defined TLV in the body of an RI LSA is the Router
   Informational Capabilities TLV."

   Surely that is only for the first Opaque ID=0?  Does each subsequent RI LSA
   also need to contain a Router Informational Capabilities TLV??

3) In Sec 4 IANA Considerations:  This section is defining the different IANA policies;
when RFC4970 was written, RFC5226 didn't exist.  But since you're doing a bis,
perhaps you can align to the policies in RFC5226 and remove the unnecessary text??

4) In Sec 4 IANA Considerations:  The registry for OSPFv3 LSA Function Codes can
be found at http://www.iana.org/assignments/ospfv3-parameters/ospfv3-parameters.xhtml#ospfv3-parameters-3 and what is in the draft doesn't match up.  I'd settle for defining the ranges, and value 12 - but it's up to you and IANA on the preferences.  Would it make sense to change the policy from Standards Action to IETF Review here also?

Same thing applies to the OSPF RI TLVS (http://www.iana.org/assignments/ospfv2-parameters/ospfv2-parameters.xhtml#ospfv2-parameters-9 )   Also here, I think there
was agreement among the 4 of us who commented on the WG mailing list to change this
from Standards Action to IETF Review.

5) In Sec 4 IANA Considerations: "All Router Functional Capability TLV
       additions are to be assigned through standards action."   Given the discussion
about IETF Review vs. Standards Action for other registries, are you sure you want
Standards Action?

I'm sure that we'll get this moving along quickly.

Thanks again!
Alia