IETF Logo Mail Archive

Re: [Pce] AD review of draft-ietf-pce-pceps-tls13-02

Sean Turner <sean@sn3rd.com> Tue, 05 December 2023 17:38 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C90F9C14F747 for <pce@ietfa.amsl.com>; Tue, 5 Dec 2023 09:38:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dFzzuoE5YNMY for <pce@ietfa.amsl.com>; Tue, 5 Dec 2023 09:38:08 -0800 (PST)
Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46294C14F686 for <pce@ietf.org>; Tue, 5 Dec 2023 09:38:08 -0800 (PST)
Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77f0756a097so97421885a.2 for <pce@ietf.org>; Tue, 05 Dec 2023 09:38:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; t=1701797887; x=1702402687; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z8EPU8Xlaq3HX+Q14ZiCy7E1jaLpWGJENd8DrUBVFF8=; b=NMKlt+Fv1lKv0jkivlyBKatn9Mn5zkba3dSb2blffzYc0NlvNw4XPdnNvB5l7Zvfm7 DMpufmw9h1v27L9bROWMvIcrDlKoZXwU1u3B06noXve2sxFso350l7TdsOM7rD/qn5Yl 95h134zmuv4ju4FQfVUXOIwss3RjA+opBjtVM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701797887; x=1702402687; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z8EPU8Xlaq3HX+Q14ZiCy7E1jaLpWGJENd8DrUBVFF8=; b=DYR1QlVQ3/HsF+se5uFDa6ljAzpKo8rVysV4WBPjADfIbP/E6WP48dSn936hjE37kA eVUvykHyn5XZSKRLP5iDIOSdly3fscSWgh2K8FiYvO3Tl+ltvuo9daCT/IZ55BFZINMl hg3HllR9yhwEctYhXs67JN0x5DRYbZe9ipkNnfKXovbVtyaFkf48kf7N0jJzi1GZlElM Uoflp3Q3ECS/pzZ6cjDVVpWoi+noDgfMIhUSIuJOfjtwIYglpVn7D9UttsdZMYcAyycs zrf2SkwiLGHJ3tRCdmWG7FidXeNcmTbRbgWsd1yHPA2SLQc7AVNryt/YzZMhCQKdn6VW 2XDQ==
X-Gm-Message-State: AOJu0Yz/tBGL+nNGdI8vjTFsxFNm6CQWm3B/q7kRQ0Y9kgIO9iLhELF9 WgQtt8+TBgu96LT561w+y8CzlQ==
X-Google-Smtp-Source: AGHT+IEs2kiOYbOB6CZZ5yFFmQt+yKtiAWF4IdWT1q52LQA4h04/cRr1RqKjLbiPJtPrpThLeBPkQw==
X-Received: by 2002:a05:620a:2b95:b0:77e:fba3:a7b5 with SMTP id dz21-20020a05620a2b9500b0077efba3a7b5mr1672137qkb.147.1701797886870; Tue, 05 Dec 2023 09:38:06 -0800 (PST)
Received: from smtpclient.apple (pool-68-238-162-47.washdc.fios.verizon.net. [68.238.162.47]) by smtp.gmail.com with ESMTPSA id qk19-20020a05620a889300b0077efb969151sm3465032qkn.59.2023.12.05.09.38.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Dec 2023 09:38:06 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
From: Sean Turner <sean@sn3rd.com>
In-Reply-To: <5FBB4B66-BFE8-4708-A180-7E674D709B36@juniper.net>
Date: Tue, 05 Dec 2023 12:38:05 -0500
Cc: "pce@ietf.org" <pce@ietf.org>, "draft-ietf-pce-pceps-tls13@ietf.org" <draft-ietf-pce-pceps-tls13@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <6B718FF1-9A59-4FFE-BA20-40515BBAA8C5@sn3rd.com>
References: <5FBB4B66-BFE8-4708-A180-7E674D709B36@juniper.net>
To: John Scudder <jgs@juniper.net>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/Ekqm03J8fOWIJwCXVWHuMMBYAEA>
Subject: Re: [Pce] AD review of draft-ietf-pce-pceps-tls13-02
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Dec 2023 17:38:12 -0000


> On Dec 5, 2023, at 12:03, John Scudder <jgs@juniper.net> wrote:
> 
> Hi Authors,
> 
> Thanks for this document. Looks good, I've requested IETF last call.
> 
> A couple of notes below, they didn't seem worth holding up the last call for, but please consider them for your next revision.
> 
> - "what PCEPS implementations do if a PCEPS supports more than one version". I don't think PCEPS (second occurrence) takes an article (i.e. referring to "a PCEPS" is weird). Some rewrite seems called for, perhaps s/a PCEPS/one/.

This was also noted during the RTGDIR review. I suggested the following change:
https://github.com/ietf-wg-pce/draft-ietf-pce-pceps-tls13/pull/13/files

> - "neither the PCC nor the PCE should establish a PCEPS with
>   TLS connection with an unknown, unexpected, or incorrectly identified
>   peer;"
> 
> Isn't "PCEPS with TLS" redundant, doesn't the ess in PCEPS imply TLS? In which case, just drop "with TLS". (See also, "ATM machine" :-)

It is! It would also be like saying HTTPS with TLS :) I did end deleting that para though while addressing the RTGDIR comments.

> Thanks,
> 
> —John

Cheers,
spt

v2.23.0 | Report a Bug | By Email