IETF Logo Mail Archive

Re: [Pce] AD review of draft-ietf-pce-pceps-tls13-02

Sean Turner <sean@sn3rd.com> Wed, 20 December 2023 01:41 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DAC20C05E040 for <pce@ietfa.amsl.com>; Tue, 19 Dec 2023 17:41:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PkNOYPB5aAJ2 for <pce@ietfa.amsl.com>; Tue, 19 Dec 2023 17:41:42 -0800 (PST)
Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE8C7C05E02D for <pce@ietf.org>; Tue, 19 Dec 2023 17:41:42 -0800 (PST)
Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-67f0d22e4faso37738546d6.3 for <pce@ietf.org>; Tue, 19 Dec 2023 17:41:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; t=1703036502; x=1703641302; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/pzMNXanFkLTG0z77O1PXwuw2l9mg3V4HEa9E3tf+08=; b=UImwmq//JmCRDNFtdS+yen04eH5acoa0976ChOV5ne+d/GkhnwLlby8vSmo7or5nLy LKgzl8h97UIVFkPY0MTNM7BP8IaiAHcvcVJAr8yFly91pcriXcv60iIKdrV8qlxrDs4P m++wm8rIgm0VbNlrn1PgjNhA0DMIIZ1k6v4xY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703036502; x=1703641302; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/pzMNXanFkLTG0z77O1PXwuw2l9mg3V4HEa9E3tf+08=; b=Z7V4OdZU/s1s9uLYfiij6nndtpvrwha9UKD8PBwUhb/RJraF3cWuCKxvSQeHyxAWSP 9fu8VNP5yagemKEb+L/21NLWtlRhNapRfaO4A/kHNfp5HhF8x90GcGoammbMlAutc4Op W5sZYRES+om3uMzgzHStDH1ISSzyf/7SEDuQVhWZDzaFBvJM84HkNeAF2zImRfIqM0FM rBg+9ghJYqt45mf168e/SOcXUekDNiHvqO7RKCPynOtSmeyc0H916YwBF5bdyIEJ2Eix a2dL7ZYALRFWPnYxjS5OI0B8iiEITDUZJDpzYHYeYNlQ/epRu/yOOuJy7njxRrRo941T LisQ==
X-Gm-Message-State: AOJu0YxKnXOnPEg+w1RdngJhqMNNRlLLCYXaETbrgWcG9lS0evKcHWJz NIJbo6ra/7Gc1qEqIu17wTyNpg==
X-Google-Smtp-Source: AGHT+IHcgWX0x1hErEzl7ajy95UBBlVHBiOCTeKmaveNVv8933z/qXU+dAk1Nj7A/iw4fYyqJKDlKQ==
X-Received: by 2002:ad4:5de2:0:b0:67f:276d:a113 with SMTP id jn2-20020ad45de2000000b0067f276da113mr9268145qvb.72.1703036501952; Tue, 19 Dec 2023 17:41:41 -0800 (PST)
Received: from smtpclient.apple (pool-68-238-162-47.washdc.fios.verizon.net. [68.238.162.47]) by smtp.gmail.com with ESMTPSA id es17-20020a056214193100b0067f696f412esm393601qvb.112.2023.12.19.17.41.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2023 17:41:41 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
From: Sean Turner <sean@sn3rd.com>
In-Reply-To: <5FBB4B66-BFE8-4708-A180-7E674D709B36@juniper.net>
Date: Tue, 19 Dec 2023 20:41:40 -0500
Cc: "pce@ietf.org" <pce@ietf.org>, "draft-ietf-pce-pceps-tls13@ietf.org" <draft-ietf-pce-pceps-tls13@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B3FD7A9A-BAE0-4F9D-B25D-8C39CB4A30E5@sn3rd.com>
References: <5FBB4B66-BFE8-4708-A180-7E674D709B36@juniper.net>
To: John Scudder <jgs@juniper.net>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/uQ_F5Q754Ua24PTZSm85qGimdeU>
Subject: Re: [Pce] AD review of draft-ietf-pce-pceps-tls13-02
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Dec 2023 01:41:47 -0000

John,

Now that the I-D has been placed on the 1/4 telechat should I spin a new version that incorporates the  outstanding PRs:
https://github.com/ietf-wg-pce/draft-ietf-pce-pceps-tls13/pulls

spt

> On Dec 5, 2023, at 12:03, John Scudder <jgs@juniper.net> wrote:
> 
> Hi Authors,
> 
> Thanks for this document. Looks good, I've requested IETF last call.
> 
> A couple of notes below, they didn't seem worth holding up the last call for, but please consider them for your next revision.
> 
> - "what PCEPS implementations do if a PCEPS supports more than one version". I don't think PCEPS (second occurrence) takes an article (i.e. referring to "a PCEPS" is weird). Some rewrite seems called for, perhaps s/a PCEPS/one/.
> 
> - "neither the PCC nor the PCE should establish a PCEPS with
>   TLS connection with an unknown, unexpected, or incorrectly identified
>   peer;"
> 
> Isn't "PCEPS with TLS" redundant, doesn't the ess in PCEPS imply TLS? In which case, just drop "with TLS". (See also, "ATM machine" :-)
> 
> Thanks,
> 
> —John

v2.23.0 | Report a Bug | By Email