Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt

tom petch <ietfc@btconnect.com> Tue, 16 October 2018 16:52 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6543F130DEE for <pce@ietfa.amsl.com>; Tue, 16 Oct 2018 09:52:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.196
X-Spam-Level: ***
X-Spam-Status: No, score=3.196 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RATWARE_OUTLOOK_NONAME=2.95, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KkYi7nyPpGaJ for <pce@ietfa.amsl.com>; Tue, 16 Oct 2018 09:52:56 -0700 (PDT)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0126.outbound.protection.outlook.com [104.47.1.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E2DA1293FB for <pce@ietf.org>; Tue, 16 Oct 2018 09:52:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4vDnwWmowbOvvxn1F4m1iwvjhU5EDvNI8zqNa4TOTSo=; b=eJL+UcF1YCD1IYhElV51keERCIZTM884AR3ZiNgQLZJfJE/BWfCt5q5hzVQ+yxXv2MQaJOsshndtVXaFXZtI8BJUByXvTZfjaULMOLOEbtoaOR2FOO2VHX+UrB+vQiAmQU0tP4KFr8Ia/7pezwa8HTg87apelgMWAsZB5ofeUOw=
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com (10.161.107.154) by VI1PR07MB1488.eurprd07.prod.outlook.com (10.165.238.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.12; Tue, 16 Oct 2018 16:52:53 +0000
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::8d94:d86b:1a6e:b5db]) by VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::8d94:d86b:1a6e:b5db%12]) with mapi id 15.20.1250.020; Tue, 16 Oct 2018 16:52:53 +0000
From: tom petch <ietfc@btconnect.com>
To: Dhruv Dhody <dhruv.ietf@gmail.com>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt
Thread-Index: AQHUZXCuBPkLB7tlTUSQU9wYUq1Qgg==
Date: Tue, 16 Oct 2018 16:52:53 +0000
Message-ID: <00b701d46570$8b2b4bc0$4001a8c0@gateway.2wire.net>
References: <153960851213.19528.13097587822287903427@ietfa.amsl.com> <CAB75xn5S0iKSgNnQNFGiVWgdkkd5pvOvXU62+-M0RWK8OdZKAA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: LO2P265CA0357.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::33) To VI1PR07MB0831.eurprd07.prod.outlook.com (2a01:111:e400:508e::26)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [81.131.229.47]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB1488; 6:keccTzgp612TDa0haiU3LKktv29+/P/bxYnXsgfGMUcZ/qyCHT7xhp/eMGlKS1eyjJ6Dy/O0Zm5IcGCf3+FVLL8oMB50pF/GOevrEHrdNbvsn7CdZUdVMKCV/D4/Agt0DgSqoPhtqZkWsTkg/oOBX2LMmF6BJkqVmD9QyKPK6pojxuXD3YILjc+yCTywMqoLESLXg2Fv5DdVJ1Aw0qiNb5gsrRPAbcYT0vZvgv9hl2c3v8TsC3OZ1NeZ6mq5UXCAbGMX22M2okLNfN5QUsZdJTCx5Fv98a3nRUa3miseSlyDETj0RRn/T0/WaMJfySRsB7I8TQ7k6AD3bZ10VUL+OVT6Ghres99TIq0szYSXLjMKLUkyE7LbmHcvq+OuD7Fhu+y0ke0M38+DV01SMobFXym1hpH/A2A8EKuCSRbbJr7Zj62yRVHBkqZG3TWI5LMMMKSNjkQdB7PSpj+tMOCydQ==; 5:WL3sE49MWqY7U0B+KCi46pc9Ler2DeqnbLYUzLD1J0x6XzLe8gDZ9ObKwiXS83O0QmsIwifMotHhwdhye2p7YPa9RohucFf25s32UAIq9jL7SNSkgC5K4/Th7ijX9VE9dX2KpgtIOb1ZzQ4/cROMces7/+wqZLyh+RR9QqNlCoU=; 7:xeFejTR02fwGSreUCnmJx4Q8bchBMv7SzisgMRXFMqUyY9vKv6CfALWsIBtdzbW4QvkifnR6v/jJlJNLS8zN1McBN5Hk094wWDkSXe9mHTBBNC7TsgzlKtOJ/LPwe2PNpLfoj869FfuyWjZDby95EL7BtiYRwARUfsk3mVw3GuL42I38pmoWzKSw303ZYopiEvpaOcchGlAZwxNu50l9bTOzszi92UjagLm8zhi1mrTaipI7x0LLHGa5i0CjYf+o
x-ms-office365-filtering-correlation-id: c97b0fe9-5122-45d4-0898-08d63387d09b
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR07MB1488;
x-ms-traffictypediagnostic: VI1PR07MB1488:
x-microsoft-antispam-prvs: <VI1PR07MB14884AE617F27AE1DF5C76D7A0FE0@VI1PR07MB1488.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(788757137089)(120809045254105)(85827821059158);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231355)(944501410)(52105095)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051); SRVR:VI1PR07MB1488; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB1488;
x-forefront-prvs: 0827D7ACB9
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(376002)(136003)(346002)(396003)(39860400002)(199004)(189003)(13464003)(71200400001)(5660300001)(99286004)(66066001)(6506007)(53546011)(76176011)(6306002)(6436002)(44736005)(86152003)(14454004)(6512007)(33896004)(52116002)(6486002)(9686003)(386003)(6246003)(39060400002)(105586002)(316002)(25786009)(84392002)(106356001)(71190400001)(14496001)(110136005)(81166006)(2906002)(53936002)(6116002)(229853002)(3846002)(966005)(2501003)(5250100002)(2900100001)(97736004)(102836004)(81156014)(26005)(68736007)(8936002)(305945005)(86362001)(486006)(4001150100001)(478600001)(186003)(7736002)(14444005)(256004)(8676002)(1556002)(476003)(446003); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB1488; H:VI1PR07MB0831.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: p6HTcZX817v9jkyhJpsjPtn8XPioQk4F4yGRoT7+KPkyA8Xn3NQ09+b9gUOhPTq3IjvLBl1jkr/tfw47k1QujTztL5LNKn1p/Oglv2EaG2P342LdN0QNkSoHfi0oo9s52S6F2mWqwvNjB53zrMXu1Y8iOqsN6T9OzpaUcW8fWlpxV+ZyC+XiRerUBdsFwzux2ZVAoaKIzj6HAH0u9PXj2ghcEqIJ5t8aBmgBNhUm6PwQMBunpq18MenbQ4WEyTv3ljbfbZ0ZxDfY1QDGnE0hC2hixogq4FBUfbokzZaMWhjeJKGQVDsJvSBgT3Ztfk6C9dk5GxDbOINSs5OkTz5C5LMVwQZ6K6PlBmI7QAP05QA=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <3D37E437DF0FD94580F646FC5906BBB4@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c97b0fe9-5122-45d4-0898-08d63387d09b
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 16:52:53.6529 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB1488
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/XBEmKseVTaMkUPDnOV7RkMaEQ9s>
Subject: Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2018 16:52:59 -0000

---- Original Message -----
From: "Dhruv Dhody" <dhruv.ietf@gmail.com>
Sent: Monday, October 15, 2018 2:14 PM

> The changes in this update are -
>
> - Use of identity instead of typedef for lsp-error
> - Reusing PST, Objective function, association-types from the te-types
> - Update to PCEP-SR as per the SR capability TLV
> - Simplification of key (as done by other yang models)
> - Alignment to explicit-route-hop in te-types
>
> The draft does not have any other pending actions.

Mmm why can I not resist the challenge?

You say
   RFC Ed.: In this section, replace all occurrences of 'XXXX' with the
   actual RFC number ...
and then
    import ietf-te {    prefix "te";    reference "RFC XXXX";    }
    import ietf-te-types {     prefix "te-types";    reference "RFC
XXXX";
    import ietf-tls-server {   prefix "tls-server";    reference "RFC
XXXX";   }
    import ietf-tls-client {    prefix "tls-client";     reference "RFC
XXXX";

Mmm I think not!

And, I like all the references in the YANG module but they need to be in
the references of the I-D.  I think you are missing

3209
5088
5089
5520
5541
5557
6536
8232
8306

while
8253
is there but Informative; my preference is for such references to be
Normative.

A common practice is to have a section just prior to the module proper
which gives references to all the RFC which the module references, which
obviates the appearance of warnings about  'Unused Reference'.

Tom Petch


> Dhruv
> PS. The yang errors in the datatracker are in the imported yang
modules.
>
> On Mon, Oct 15, 2018 at 6:32 PM <internet-drafts@ietf.org> wrote:
>
> >
> > A New Internet-Draft is available from the on-line Internet-Drafts
> > directories.
> > This draft is a work item of the Path Computation Element WG of the
IETF.
> >
> >         Title           : A YANG Data Model for Path Computation
Element
> > Communications Protocol (PCEP)
> >         Authors         : Dhruv Dhody
> >                           Jonathan Hardwick
> >                           Vishnu Pavan Beeram
> >                           Jeff Tantsura
> >         Filename        : draft-ietf-pce-pcep-yang-09.txt
> >         Pages           : 116
> >         Date            : 2018-10-15
> >
> > Abstract:
> >    This document defines a YANG data model for the management of
Path
> >    Computation Element communications Protocol (PCEP) for
communications
> >    between a Path Computation Client (PCC) and a Path Computation
> >    Element (PCE), or between two PCEs.  The data model includes
> >    configuration data and state data (status information and
counters
> >    for the collection of statistics).
> >
> >
> > The IETF datatracker status page for this draft is:
> > https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-yang/
> >
> > There are also htmlized versions available at:
> > https://tools.ietf.org/html/draft-ietf-pce-pcep-yang-09
> > https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-yang-09
> >
> > A diff from the previous version is available at:
> > https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-pcep-yang-09
> >
> >
> > Please note that it may take a couple of minutes from the time of
> > submission
> > until the htmlized version and diff are available at tools.ietf.org.
> >
> > Internet-Drafts are also available by anonymous FTP at:
> > ftp://ftp.ietf.org/internet-drafts/
> >