Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt

Dhruv Dhody <dhruv.dhody@huawei.com> Wed, 17 October 2018 06:06 UTC

Return-Path: <dhruv.dhody@huawei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E017130DC5 for <pce@ietfa.amsl.com>; Tue, 16 Oct 2018 23:06:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4ebDPmOZ2wuA for <pce@ietfa.amsl.com>; Tue, 16 Oct 2018 23:06:11 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 57335129619 for <pce@ietf.org>; Tue, 16 Oct 2018 23:06:11 -0700 (PDT)
Received: from lhreml707-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id D94BFCABE29AD for <pce@ietf.org>; Wed, 17 Oct 2018 07:06:07 +0100 (IST)
Received: from BLREML703-CAH.china.huawei.com (10.20.4.172) by lhreml707-cah.china.huawei.com (10.201.108.48) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 17 Oct 2018 07:06:08 +0100
Received: from BLREML503-MBX.china.huawei.com ([169.254.9.201]) by blreml703-cah.china.huawei.com ([::1]) with mapi id 14.03.0399.000; Wed, 17 Oct 2018 11:36:00 +0530
From: Dhruv Dhody <dhruv.dhody@huawei.com>
To: tom petch <ietfc@btconnect.com>, Dhruv Dhody <dhruv.ietf@gmail.com>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt
Thread-Index: AQHUZIdsEwflMYiDcEaBAi2DGlLT6aUi9N5w
Date: Wed, 17 Oct 2018 06:05:59 +0000
Message-ID: <23CE718903A838468A8B325B80962F9B8D81D2E2@BLREML503-MBX.china.huawei.com>
References: <153960851213.19528.13097587822287903427@ietfa.amsl.com> <CAB75xn5S0iKSgNnQNFGiVWgdkkd5pvOvXU62+-M0RWK8OdZKAA@mail.gmail.com> <00b701d46570$8b2b4bc0$4001a8c0@gateway.2wire.net>
In-Reply-To: <00b701d46570$8b2b4bc0$4001a8c0@gateway.2wire.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.18.149.39]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/ql35jUjrAEnohtQwcKCpoFbNP5Y>
Subject: Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Oct 2018 06:06:13 -0000

Hi Tom, 

> >
> > The draft does not have any other pending actions.
> 
> Mmm why can I not resist the challenge?
> 

[[Dhruv Dhody]] I am glad you took the challenge and pointed these out :), I will update them along with the forthcoming yangdoctor's review!

Thanks! 
Dhruv 

> You say
>    RFC Ed.: In this section, replace all occurrences of 'XXXX' with the
>    actual RFC number ...
> and then
>     import ietf-te {    prefix "te";    reference "RFC XXXX";    }
>     import ietf-te-types {     prefix "te-types";    reference "RFC
> XXXX";
>     import ietf-tls-server {   prefix "tls-server";    reference "RFC
> XXXX";   }
>     import ietf-tls-client {    prefix "tls-client";     reference "RFC
> XXXX";
> 
> Mmm I think not!
> 
> And, I like all the references in the YANG module but they need to be in
> the references of the I-D.  I think you are missing
> 
> 3209
> 5088
> 5089
> 5520
> 5541
> 5557
> 6536
> 8232
> 8306
> 
> while
> 8253
> is there but Informative; my preference is for such references to be
> Normative.
> 
> A common practice is to have a section just prior to the module proper
> which gives references to all the RFC which the module references, which
> obviates the appearance of warnings about  'Unused Reference'.
> 
> Tom Petch
> 
> 
> > Dhruv
> > PS. The yang errors in the datatracker are in the imported yang
> modules.
> >
> > On Mon, Oct 15, 2018 at 6:32 PM <internet-drafts@ietf.org> wrote:
> >
> > >
> > > A New Internet-Draft is available from the on-line Internet-Drafts
> > > directories.
> > > This draft is a work item of the Path Computation Element WG of the
> IETF.
> > >
> > >         Title           : A YANG Data Model for Path Computation
> Element
> > > Communications Protocol (PCEP)
> > >         Authors         : Dhruv Dhody
> > >                           Jonathan Hardwick
> > >                           Vishnu Pavan Beeram
> > >                           Jeff Tantsura
> > >         Filename        : draft-ietf-pce-pcep-yang-09.txt
> > >         Pages           : 116
> > >         Date            : 2018-10-15
> > >
> > > Abstract:
> > >    This document defines a YANG data model for the management of
> Path
> > >    Computation Element communications Protocol (PCEP) for
> communications
> > >    between a Path Computation Client (PCC) and a Path Computation
> > >    Element (PCE), or between two PCEs.  The data model includes
> > >    configuration data and state data (status information and
> counters
> > >    for the collection of statistics).
> > >
> > >
> > > The IETF datatracker status page for this draft is:
> > > https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-yang/
> > >
> > > There are also htmlized versions available at:
> > > https://tools.ietf.org/html/draft-ietf-pce-pcep-yang-09
> > > https://datatracker.ietf.org/doc/html/draft-ietf-pce-pcep-yang-09
> > >
> > > A diff from the previous version is available at:
> > > https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-pcep-yang-09
> > >
> > >
> > > Please note that it may take a couple of minutes from the time of
> > > submission until the htmlized version and diff are available at
> > > tools.ietf.org.
> > >
> > > Internet-Drafts are also available by anonymous FTP at:
> > > ftp://ftp.ietf.org/internet-drafts/
> > >
> 
> _______________________________________________
> Pce mailing list
> Pce@ietf.org
> https://www.ietf.org/mailman/listinfo/pce