Re: [Pce] I-D Action: draft-ietf-pce-pcep-yang-09.txt

[tom petch <[e-mail]>]

Dhruv

I will have some more in a day or so.  Meanwhile,

I note that some of the lines exceed the limit allowed for an RFC, e.g.
in the tree diagrams.

The convention (rule almost) is to use the same prefix for the same
module in all cases; here you have
       import ietf-pcep {
          prefix p;
and
module ietf-pcep {
...
    prefix pcep;

I find it useful for the YANG reference clauses to include the name of
the RFC as well as the RFC number e.g.
       reference
         "RFC4360: BGP Extended Communities Attribute.
          RFC5668: 4-Octet AS Specific BGP Extended Community.";

Tom Petch

----- Original Message -----
From: "Dhruv Dhody" <[e-mail]>
Sent: Wednesday, October 17, 2018 7:05 AM


Hi Tom,

> >
> > The draft does not have any other pending actions.
>
> Mmm why can I not resist the challenge?
>

[[Dhruv Dhody]] I am glad you took the challenge and pointed these out
:), I will update them along with the forthcoming yangdoctor's review!

Thanks!
Dhruv

> You say
>    RFC Ed.: In this section, replace all occurrences of 'XXXX' with
the
>    actual RFC number ...
> and then
>     import ietf-te {    prefix "te";    reference "RFC XXXX";    }
>     import ietf-te-types {     prefix "te-types";    reference "RFC
> XXXX";
>     import ietf-tls-server {   prefix "tls-server";    reference "RFC
> XXXX";   }
>     import ietf-tls-client {    prefix "tls-client";     reference
"RFC
> XXXX";
>
> Mmm I think not!
>
> And, I like all the references in the YANG module but they need to be
in
> the references of the I-D.  I think you are missing
>
> 3209
> 5088
> 5089
> 5520
> 5541
> 5557
> 6536
> 8232
> 8306
>
> while
> 8253
> is there but Informative; my preference is for such references to be
> Normative.
>
> A common practice is to have a section just prior to the module proper
> which gives references to all the RFC which the module references,
which
> obviates the appearance of warnings about  'Unused Reference'.
>
> Tom Petch
>
>
> > Dhruv
> > PS. The yang errors in the datatracker are in the imported yang
> modules.
> >
> > On Mon, Oct 15, 2018 at 6:32 PM <[e-mail]> wrote:
> >
> > >
> > > A New Internet-Draft is available from the on-line Internet-Drafts
> > > directories.
> > > This draft is a work item of the Path Computation Element WG of
the
> IETF.
> > >
> > >         Title           : A YANG Data Model for Path Computation
> Element
> > > Communications Protocol (PCEP)
> > >         Authors         : Dhruv Dhody
> > >                           Jonathan Hardwick
> > >                           Vishnu Pavan Beeram
> > >                           Jeff Tantsura
> > >         Filename        : draft-ietf-pce-pcep-yang-09.txt