Re: [pim] Fw: I-D Action: draft-ietf-pim-msdp-yang-16.txt

Xufeng Liu <xufeng.liu.ietf@gmail.com> Mon, 23 March 2020 14:14 UTC

Return-Path: <xufeng.liu.ietf@gmail.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A88A3A080E; Mon, 23 Mar 2020 07:14:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9n3h1RPzXwHS; Mon, 23 Mar 2020 07:14:13 -0700 (PDT)
Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 381C83A074E; Mon, 23 Mar 2020 07:14:13 -0700 (PDT)
Received: by mail-io1-xd29.google.com with SMTP id k9so3547004iov.7; Mon, 23 Mar 2020 07:14:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YJNibgQxOMnT6YFrf2/9SQgsobWq/CMbSCjMlSs3voA=; b=Oor35FP9XfdwS2DOh8PakubiOfhdkgPK72V3ELntjJEfIN2NDAOKjnqn29zXUO7jHx Hw9FUCdemA/g2UwYSrR2/7sYb12VPB47V0+RY7iXujMrOOsOEMgFug1J5YLs1yjAp1FF zW6f4D4sp6gH2tnZYmKbmNqmQ6QI1CzzqiabvQbAgmkz8o4tI8CvSgQW54O5B5NJubGS n9rvl28X1bimsYKLFA5gBmD9OwapfUa3RB6V5aqZ98WqrG/wELzgSaCBo57iED0N9QL+ XdM/8W6Bor8x/S8skzZI4Ek2EHsU6AWf0K902XHOv+5hOb0LiMxjlkbLRHyUzU/Jow0L vWtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YJNibgQxOMnT6YFrf2/9SQgsobWq/CMbSCjMlSs3voA=; b=K1qAheebNZZ4iRaifURDTzmTmHFThdqvVtf+ambE/+MM2j4eeM2cVFo3cX49w2CguL xF7+2XbkSqv/2mEWW1DmJv9NBwxDo9c4YS5AdZDuMUisMSioij/75+NsYrI1FPTOTYla qmIVIgfqWcN356ShWOT1IFY0i1Y1BRwgL7dA1sFiSz6anISuvCoNYyoS+mi3cNIV45VT hFULPGxZeAwgb/zQqCrlVCIj6ek3RpMvSBVBIwSPyvsWcRtV0d6k/WRqwOtsFmCF6SAu XDurN6AeeJciiAFJ286eGFR5WDVYjxcrVCxhuc28oqUJe7onYb13QWAGn312F8Du+BmK k/YQ==
X-Gm-Message-State: ANhLgQ2SBafAQjgDXAJpd5Hbzgk1ZZwMk32iRCK0q8jKaMH2OjrLwenp BC8cM2SYtqGBoHlQG3vuoIr5JoW3ZoPhqqqMHCg=
X-Google-Smtp-Source: ADFU+vtI7VkzXQrKt9tHX64WncQXT2lTC7ahGhkTuFBasngcMWr0QBUWHELQcF5s86NT5H10oc91vud9ckMc1ioEmWo=
X-Received: by 2002:a6b:3112:: with SMTP id j18mr19703344ioa.127.1584972852151; Mon, 23 Mar 2020 07:14:12 -0700 (PDT)
MIME-Version: 1.0
References: <202003091145456269025@zte.com.cn> <BY5PR11MB43556F4C380EC9A7D650B7E5B5FE0@BY5PR11MB4355.namprd11.prod.outlook.com>
In-Reply-To: <BY5PR11MB43556F4C380EC9A7D650B7E5B5FE0@BY5PR11MB4355.namprd11.prod.outlook.com>
From: Xufeng Liu <xufeng.liu.ietf@gmail.com>
Date: Mon, 23 Mar 2020 10:14:01 -0400
Message-ID: <CAEz6PPSpvMex-NPej34_vc-LwcKEUMXHA49-bW1C415+FebDQg@mail.gmail.com>
To: "Rob Wilton (rwilton)" <rwilton=40cisco.com@dmarc.ietf.org>
Cc: "zhang.zheng@zte.com.cn" <zhang.zheng@zte.com.cn>, "kaduk@mit.edu" <kaduk@mit.edu>, "rdd@cert.org" <rdd@cert.org>, "barryleiba@computer.org" <barryleiba@computer.org>, "aretana.ietf@gmail.com" <aretana.ietf@gmail.com>, "Reshad Rahman (rrahman)" <rrahman@cisco.com>, "pim-chairs@ietf.org" <pim-chairs@ietf.org>, "pim@ietf.org" <pim@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000d4c74005a1863f39"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/f-_-b7VlUVB52L3u7mwVaMFaHEY>
Subject: Re: [pim] Fw: I-D Action: draft-ietf-pim-msdp-yang-16.txt
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2020 14:14:24 -0000

Hi Bob,
I'd like to ask a question in-line below.

On Mon, Mar 9, 2020 at 7:54 AM Rob Wilton (rwilton) <rwilton=
40cisco.com@dmarc.ietf.org> wrote:

> Hi Sandy,
>
>
>
> Thanks for making these markups.
>
>
>
> I wasn’t sure that your Actions example in A.3 was complete, it doesn’t
> look to be structurally correct, e.g. it doesn’t seem to identify the
> action that is being invoked.
>

Is there any complete JSON encoded action example? Based on RFC8040, the
given JSON data seems to be complete. The object that the action is applied
is identified by the resource url (Sec 3.6. of RFC8040):

    POST {+restconf}/data/<data-resource-identifier>/<action>

Page 35 gives an example:

      { "example-actions:input" : {
          "delay" : 600
        }
      }


Based on this example, A.3 seems correct.

It would also be useful to have a sentence before the action to describe
> what it is doing.
>

This could be the solution.
Thanks,
- Xufeng

>
>
> As a minor nit on 3.2, I would change reword the last paragraph:
>
>
>
> OLD:
>
>
>
>    The actions can be used to clear the connection of one specific MSDP
>
>    peer, or clear the connections of all the MSDP peers, or clear some
>
>    or all the SA caches.
>
>
>
>
>
> PROPOSED:
>
>
>
>    YANG actions are defined to clear the connection of one specific MSDP
>
>    peer, clear the connections of all MSDP peers, or clear some
>
>    or all the SA caches.
>
>
>
> Regards,
> Rob
>
>
>
>
>
> *From:* zhang.zheng@zte.com.cn <zhang.zheng@zte.com.cn>
> *Sent:* 09 March 2020 03:46
> *To:* kaduk@mit.edu; rdd@cert.org; barryleiba@computer.org; Rob Wilton
> (rwilton) <rwilton@cisco.com>; aretana.ietf@gmail.com; Reshad Rahman
> (rrahman) <rrahman@cisco.com>
> *Cc:* pim-chairs@ietf.org; pim@ietf.org
> *Subject:* Fw:[pim] I-D Action: draft-ietf-pim-msdp-yang-16.txt
>
>
>
> Hi Ben, Roman, Barry, Rob, Alvaro, Reshad,
>
>
>
> Thank you very much for your comments and modification suggestions.
>
> And many thanks to everyone who give us suggestions.
>
> We updated the draft to 16 version.
>
> Please review it. Hope this verson can be well.
>
>
>
> Best regards,
>
> Sandy
>
>
>
> 原始邮件
>
> *发件人:*internet-drafts@ietf.org <internet-drafts@ietf.org>
>
> *收件人:*i-d-announce@ietf.org <i-d-announce@ietf.org>;
>
> *抄送人:*pim@ietf.org <pim@ietf.org>;
>
> *日* *期* *:*2020年03月09日 11:26
>
> *主* *题* *:**[pim] I-D Action: draft-ietf-pim-msdp-yang-16.txt*
>
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the Protocols for IP Multicast WG of the IETF.
>
>
>         Title           : A YANG Data Model for Multicast Source Discovery Protocol (MSDP)
>         Authors         : Xufeng Liu
>                           Zheng Zhang
>                           Anish Peter
>                           Mahesh Sivakumar
>                           Feng Guo
>                           Pete McAllister
>     Filename        : draft-ietf-pim-msdp-yang-16.txt
>     Pages           : 34
>     Date            : 2020-03-08
>
> Abstract:
>    This document defines a YANG data model for the configuration and
>    management of Multicast Source Discovery Protocol (MSDP) Protocol.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-pim-msdp-yang/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-pim-msdp-yang-16
> https://datatracker.ietf.org/doc/html/draft-ietf-pim-msdp-yang-16
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-pim-msdp-yang-16
>
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
>
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim
>
>
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim
>