IETF Logo Mail Archive

Re: [quicwg/base-drafts] Pad path validation in both directions (#4241)

Kazuho Oku <notifications@github.com> Tue, 20 October 2020 01:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E4D813A0983 for <quic-issues@ietfa.amsl.com>; Mon, 19 Oct 2020 18:32:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ow31i3PM4-Gl for <quic-issues@ietfa.amsl.com>; Mon, 19 Oct 2020 18:32:43 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C329B3A097F for <quic-issues@ietf.org>; Mon, 19 Oct 2020 18:32:43 -0700 (PDT)
Received: from github.com (hubbernetes-node-9645ac4.ash1-iad.github.net [10.56.102.66]) by smtp.github.com (Postfix) with ESMTPA id AC7C6840D44 for <quic-issues@ietf.org>; Mon, 19 Oct 2020 18:32:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1603157562; bh=wXOFdyxYXAxqcvRVHD7Q6MpA+V89i2xPe2o1+8PpJpE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jBaozhKvJJvc9TPk0EGr3MriZTLNDjmgcDGB54uRVfTV8KgzMfqhzlnf4b/Ov4gyh JKRg8rNopKCMSZRTwwRm43btFqdLeBJs+NqaJHwTalLbjVqPYS+EZAM7R5/izQWoEu hZuB7FUr9R8CZO7eu/PJX/1nGWt0/AbJC2T3jEM8=
Date: Mon, 19 Oct 2020 18:32:42 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3Q3VPQTQKWITQ3SI55TIPTVEVBNHHCWKQC3Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4241/review/512268768@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4241@github.com>
References: <quicwg/base-drafts/pull/4241@github.com>
Subject: Re: [quicwg/base-drafts] Pad path validation in both directions (#4241)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f8e3e3aa8243_43919b44119f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/0_H_O8od_pT56HdVOGT1iep1DEk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2020 01:32:45 -0000

@kazuho commented on this pull request.

LGTM, with a note regarding MUST vs. SHOULD for padding.

As I pointed out in #4253, datagram size is not authenticated, and therefore receivers can never enforce the use of padding (though they MAY discard packets that do not meet the padding requirement).

If we go with a MUST, we should be clear about that.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4241#pullrequestreview-512268768

v2.23.0 | Report a Bug | By Email