IETF Logo Mail Archive

[quicwg/base-drafts] Pad path validation in both directions (#4241)

Martin Thomson <notifications@github.com> Mon, 19 October 2020 00:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E0A23A10A3 for <quic-issues@ietfa.amsl.com>; Sun, 18 Oct 2020 17:08:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jm45FrAAy8aX for <quic-issues@ietfa.amsl.com>; Sun, 18 Oct 2020 17:08:23 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 368483A044E for <quic-issues@ietf.org>; Sun, 18 Oct 2020 17:08:23 -0700 (PDT)
Received: from github.com (hubbernetes-node-818a524.ash1-iad.github.net [10.56.113.62]) by smtp.github.com (Postfix) with ESMTPA id BFB4C840748 for <quic-issues@ietf.org>; Sun, 18 Oct 2020 17:08:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1603066101; bh=8kfTGZultertJUMRxj9TNt/Zk972co8gz5juaxp01Og=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=VCP9KJwX4rIc0t1upah4pu7RJxlM9QwjoEGfhDrgtjLPPzAwuLh6IPfkXxHcPbjNx oDruLGwZYUyC/GceihSKfL+fJct5pPmIyE9XZvys9HeaKEnWue14g9pTZ81LwvloJP GQ9JxVorB6+GDmOH4UjiObEgUz8c9SUXL6WruzN4=
Date: Sun, 18 Oct 2020 17:08:21 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK63OIOCC7IJXIRQVOF5TC47LEVBNHHCWKQC3Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4241@github.com>
Subject: [quicwg/base-drafts] Pad path validation in both directions (#4241)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f8cd8f5bc379_4d19b411541e1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KqTIawsYqcxf3SyXz8n9urUUJ7U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2020 00:08:24 -0000

This enacts the proposal in [@kazuho&#39;s comment](https://github.com/quicwg/base-drafts/issues/4216#issuecomment-709664513) on #4216.  Padding PATH_RESPONSE and sending on the same path as PATH_CHALLENGE helps ensure that the path MTU in both directions of the path is sufficient for the protocol to function.

This is a nasty change; I&#39;m personally quite unhappy about the prospect of implementing it, but it seems like the best option we have.

Closes #4216.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/4241

-- Commit Summary --

  * Pad when validating addresses
  * A big caveat
  * Datagrams, not packets
  * Revert automated formatting of tables, wrap
  * Pad PATH_RESPONSE too

-- File Changes --

    M draft-ietf-quic-transport.md (27)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/4241.patch
https://github.com/quicwg/base-drafts/pull/4241.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4241

v2.23.0 | Report a Bug | By Email