Re: [quicwg/base-drafts] Pad path validation in both directions (#4241)
Jana Iyengar <notifications@github.com> Tue, 20 October 2020 00:22 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6DC4B3A12C8 for <quic-issues@ietfa.amsl.com>; Mon, 19 Oct 2020 17:22:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZGhOyNHBr-i1 for <quic-issues@ietfa.amsl.com>; Mon, 19 Oct 2020 17:22:20 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1F263A12C6 for <quic-issues@ietf.org>; Mon, 19 Oct 2020 17:22:20 -0700 (PDT)
Received: from github.com (hubbernetes-node-72d8ae7.ash1-iad.github.net [10.56.112.60]) by smtp.github.com (Postfix) with ESMTPA id B21A190267A for <quic-issues@ietf.org>; Mon, 19 Oct 2020 17:22:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1603153339; bh=fI1jwWWIlpSNUUPMcx+9OkkmZijWH5C74I3zYqqsXrI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hucYtLHba1+a97LLv1GfTfCQ1VyOyRPV2xMHswH3Pt7k2MfdAS/cTVU63Gbo1WSf4 E9XBwbf843atvhvTjk4MoYIiUvg1mCw6Yqx00lV9TiQnSriqz9Vhyx48erOZS6GZM2 7/zRVzOxMJnFY+T6RG2WC6kIWnTI3RmVKCf4FeH4=
Date: Mon, 19 Oct 2020 17:22:19 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4XQ6E5V7LGWTWOQ3F5TIHLXEVBNHHCWKQC3Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4241/review/512245928@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4241@github.com>
References: <quicwg/base-drafts/pull/4241@github.com>
Subject: Re: [quicwg/base-drafts] Pad path validation in both directions (#4241)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f8e2dbbaebf4_5619b429907b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_GnJKMOShnkABihBttdWc724AcY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2020 00:22:22 -0000
@janaiyengar commented on this pull request. > +PATH_CHALLENGE was received. This ensures the path is functional in both +directions. This requirement MUST NOT be enforced by the endpoint that This justification could be a bit more precise. ``` This ensures that the peer's path validation succeeds only if the path is functional in both directions. ``` > frame unless constrained by congestion control. +A PATH_RESPONSE frame SHOULD be sent on the network path where the +PATH_CHALLENGE was received. This ensures the path is functional in both +directions. This requirement MUST NOT be enforced by the endpoint that +initiates path validation as that would enable an attack on migration; see +{{off-path-forward}}. + +An endpoint SHOULD expand datagrams that contain a PATH_RESPONSE frame to at Why is this optional? ```suggestion An endpoint MUST expand datagrams that contain a PATH_RESPONSE frame to at ``` > frame unless constrained by congestion control. +A PATH_RESPONSE frame SHOULD be sent on the network path where the We can require this from the endpoint, while at the same time requiring the peer to not enforce it. We've done unenforceable MUSTs in other parts of the specs. What is the justification for allowing this wiggle room? ```suggestion A PATH_RESPONSE frame MUST be sent on the network path where the ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4241#pullrequestreview-512245928
- [quicwg/base-drafts] Pad path validation in both … Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… ianswett
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… ianswett
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… ianswett
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… Kazuho Oku
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… Martin Thomson
- Re: [quicwg/base-drafts] Pad path validation in b… Magnus Westerlund
- Re: [quicwg/base-drafts] Pad path validation in b… ianswett
- Re: [quicwg/base-drafts] Pad path validation in b… mirjak
- Re: [quicwg/base-drafts] Pad path validation in b… Christian Huitema
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… ianswett
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… Christian Huitema
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar
- Re: [quicwg/base-drafts] Pad path validation in b… Jana Iyengar