Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)

ianswett <notifications@github.com> Fri, 28 February 2020 01:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F42173A0C0B for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 17:51:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w_xiAvXxntws for <quic-issues@ietfa.amsl.com>; Thu, 27 Feb 2020 17:51:12 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 886313A0BF7 for <quic-issues@ietf.org>; Thu, 27 Feb 2020 17:51:12 -0800 (PST)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id DFFA86A123E for <quic-issues@ietf.org>; Thu, 27 Feb 2020 17:51:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582854671; bh=qOlNw0ns0etUjhO7bfQlndIPw0C9bgOwx4NwDsV5c20=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FGX5YJGWF3h5CBBYCNgRc4tt89OBOjDvYiejrTMWogAcIXWzLJjD8SYnSHswARoOD cS6Wudn+Je2zawolwM5MpjUj5rYfgGxAS6FNe8Nov2JToCvXLtySyeO5fgH0nMOb3z v3HJJAFggMPlq2yGaiGTblywbQMFBe0zVYQUEauU=
Date: Thu, 27 Feb 2020 17:51:11 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5PKW4467WIAJZZ7CV4MWSI7EVBNHHCEHSQ2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3486/review/366117456@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3486@github.com>
References: <quicwg/base-drafts/pull/3486@github.com>
Subject: Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e58720fcec2a_7d853f87700cd96024854b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/25yXGgtjhVK01ukRqwzrw76pfo0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2020 01:51:21 -0000

ianswett commented on this pull request.



> @@ -476,9 +476,10 @@ When ack-eliciting packets are in-flight in multiple packet number spaces,
 the timer MUST be set for the packet number space with the earliest timeout,
 except for ApplicationData, which MUST be ignored until the handshake
 completes; see Section 4.1.1 of {{QUIC-TLS}}.  Not arming the PTO for
-ApplicationData prioritizes completing the handshake and prevents the server
-from sending a 1-RTT packet on a PTO before before it has the keys to process
-a 1-RTT packet.
+ApplicationData prioritizes completing the handshake, prevents the client
+from sending a 0-RTT packet on a PTO before it knows the server has accepted
+0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before
+before it has the keys to process a 1-RTT acknowledgment.

Fixed, thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3486#discussion_r385469775