Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)

Martin Thomson <notifications@github.com> Tue, 10 March 2020 22:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 96EF53A080B for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 15:55:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v-BWHINQOg_Z for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 15:55:49 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 137303A0808 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 15:55:48 -0700 (PDT)
Date: Tue, 10 Mar 2020 15:55:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583880947; bh=19l8QVFDFViN6rWPezvaMMpuEt+Nr7rYZo/lRGWig0o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QLcZIS3B1WSmpR69LB+ujJgpgCf2K4201G35qIkKCf79Die8tVZ/ontDUaxQ7fGuQ 0B63EVHwd6j9HjlmO2UguFDng3st25o5ABMx/2IXNnkuGlL788K08S7Cm6Yko7Ywt9 6k4eVInqhWBCAVL6E9sUUFvemQZp6HyOIl6C6h0k=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZKIKDW5NY6KNQNMIV4OP57HEVBNHHCEHSQ2I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3486/review/372376176@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3486@github.com>
References: <quicwg/base-drafts/pull/3486@github.com>
Subject: Re: [quicwg/base-drafts] Clarify not arming PTO for ApplicationData before completion (#3486)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e681af3c2956_7d213fe3640cd96036313"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/B6xaSo09pIv2gGCgeENqlHsm-PA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Mar 2020 22:55:51 -0000

martinthomson commented on this pull request.



> +ApplicationData prioritizes completing the handshake, prevents the client
+from sending a 0-RTT packet on a PTO before it knows the server has accepted
+0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before
+it has the keys to process a 1-RTT acknowledgment.

```suggestion
ApplicationData prioritizes completing the handshake, prevents a client from
retransmitting a 0-RTT packet on a PTO expiration before confirming that the
server is able to decrypt 0-RTT packets, and prevents a server from sending a
1-RTT packet on a PTO expiration before it has the keys to process an
acknowledgement.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3486#pullrequestreview-372376176